The settings are using the deprecated MDCCollectionViewController. It should be migrated to UITableView. The migration is the opportunity to add support for Dynamic Type.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e9cb283a8d07e9857a15371be61580b650a5192 commit 7e9cb283a8d07e9857a15371be61580b650a5192 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Oct 16 10:55:02 2018 [iOS] Move SettingsDetailItem to Legacy This CL moves the existing SettingsDetailItem to Legacy and creates a new SettingsDetailItem which is now a subclass of the TableViewItem. The new SettingsDetailItem now support Dynamic Type. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia001bf2bdd59bb71a81d228ebf7f905f5600eebf Reviewed-on: https://chromium-review.googlesource.com/c/1251625 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599943} [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/BUILD.gn [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.h [add] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn [add] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_detail_item.h [add] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_detail_item.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/settings_detail_item.h [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm [modify] https://crrev.com/7e9cb283a8d07e9857a15371be61580b650a5192/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bad1c7d1cbe851192145d95252ca2a906c428662 commit bad1c7d1cbe851192145d95252ca2a906c428662 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Oct 18 09:52:38 2018 [iOS] Add test support for ChromeTableViewController This CL adds a class to ease testing of subclasses of ChromeTableViewController, in the same way CollectionViewControllerTest is easing the testing of subclasses of CollectionViewController. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I159849612b16d5475d581c79601f93de04e6b705 Reviewed-on: https://chromium-review.googlesource.com/c/1283025 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#600706} [modify] https://crrev.com/bad1c7d1cbe851192145d95252ca2a906c428662/ios/chrome/browser/ui/table_view/BUILD.gn [add] https://crrev.com/bad1c7d1cbe851192145d95252ca2a906c428662/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.h [add] https://crrev.com/bad1c7d1cbe851192145d95252ca2a906c428662/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20ff0e74d11dcbf6a425214d5a1d15eb552529e3 commit 20ff0e74d11dcbf6a425214d5a1d15eb552529e3 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Oct 18 10:25:54 2018 [iOS] Create the TableView link footer This CL creates a TableView item for handling a footer which would display a link in a TextView. This is designed as a replacement for CollectionViewFooterItem. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id4b84e5b17920237016314447bed9a25140ab30c Reviewed-on: https://chromium-review.googlesource.com/c/1286416 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#600717} [modify] https://crrev.com/20ff0e74d11dcbf6a425214d5a1d15eb552529e3/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/20ff0e74d11dcbf6a425214d5a1d15eb552529e3/ios/chrome/browser/ui/table_view/cells/BUILD.gn [add] https://crrev.com/20ff0e74d11dcbf6a425214d5a1d15eb552529e3/ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.h [add] https://crrev.com/20ff0e74d11dcbf6a425214d5a1d15eb552529e3/ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af0578221d71ba1821da363a2390803977fb35c5 commit af0578221d71ba1821da363a2390803977fb35c5 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Oct 18 11:40:50 2018 [iOS] Migrate BandwidthManagement to UITableView This CL migrates the BandwidthManagementCollectionViewController to a UITableViewController base class. It also creates the SettingsRootViewControlling protocol to allow easier migration between the CollectionVC and the TableVC in settings. Bug: 894791, 894837 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7710c43f38a65359743336745afd8510ed8f9591 Reviewed-on: https://chromium-review.googlesource.com/c/1277788 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#600728} [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/a9fb0358c3b590e6841e9b4c8dc577f7b3739719/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.h [delete] https://crrev.com/a9fb0358c3b590e6841e9b4c8dc577f7b3739719/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm [add] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller.h [add] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller.mm [rename] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller_unittest.mm [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.h [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [add] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/settings/settings_root_view_controlling.h [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.mm [modify] https://crrev.com/af0578221d71ba1821da363a2390803977fb35c5/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9962b26e3b416e540f1f8c2d40369b3f99774cd commit c9962b26e3b416e540f1f8c2d40369b3f99774cd Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Oct 19 10:34:00 2018 [iOS] Add detail text item This CL creates a DetailTextItem for the TableView. This is a replacement for the SettingTextItem used in CollectionView. Here is a screenshot on the Table Cell Catalog, the cell with "Item with two labels" and "The second label..." https://drive.google.com/file/d/1cgTIs8h7mR8Ae8rnYSjvYZu9sMeqwxmX/view Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iab73928fca89131f326c7bbfc3c2bbb16fff5442 Reviewed-on: https://chromium-review.googlesource.com/c/1286141 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601103} [modify] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/BUILD.gn [modify] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [add] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.h [add] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.mm [add] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item_unittest.mm [modify] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.mm [modify] https://crrev.com/c9962b26e3b416e540f1f8c2d40369b3f99774cd/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0db47204f565d47b95e81317531ac88c72ec51c commit f0db47204f565d47b95e81317531ac88c72ec51c Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Oct 19 10:54:42 2018 [iOS] Convert DataplanVC to TableView This CL converts the DataplanUsageCollectionViewController to UITableViewController. It also adds the cellBackgroundColor property to the styler so the cells can have a background color different from the table view's background. It also adds an accessoryType for the DetailTextItem. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie1332811d3df6d8ef7650fb34fa3a17a515da3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1286142 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601109} [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller.mm [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/bandwidth_management_table_view_controller_unittest.mm [delete] https://crrev.com/120760648e9d28bea5bacc8b82071ba1167577c5/ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller_unittest.mm [rename] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/dataplan_usage_table_view_controller.h [rename] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/dataplan_usage_table_view_controller.mm [add] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/dataplan_usage_table_view_controller_unittest.mm [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.h [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.mm [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/table_view/cells/table_view_item.mm [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/table_view/chrome_table_view_styler.h [modify] https://crrev.com/f0db47204f565d47b95e81317531ac88c72ec51c/ios/chrome/browser/ui/table_view/chrome_table_view_styler.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2bd216cc6e767fd653658ed87e3e8569771c5e2 commit a2bd216cc6e767fd653658ed87e3e8569771c5e2 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Oct 23 09:53:49 2018 [iOS] Move SettingsSwitchItem to Legacy Preparation to create a new SettingsSwitchItem for TableView. Bug: 894791 Change-Id: Icd88aa0a5af519172b0750782f3b029ac2cc7d29 Reviewed-on: https://chromium-review.googlesource.com/c/1296189 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#601894} [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/block_popups_egtest.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/cells/BUILD.gn [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn [rename] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_switch_item.h [rename] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_switch_item.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller_unittest.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/test/earl_grey/chrome_actions.h [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/test/earl_grey/chrome_actions.mm [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/a2bd216cc6e767fd653658ed87e3e8569771c5e2/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4 commit ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Oct 24 13:20:55 2018 [iOS] Create SettingsSwitchItem for TableView This CL creates the SettingsSwitchItem, replacing the old item for the collection view. Bug: 894791 Change-Id: Ie78e6bf3f5d358ae41a4d2bf407a2cadf7252d96 Reviewed-on: https://chromium-review.googlesource.com/c/1296597 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602316} [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/cells/BUILD.gn [add] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/cells/settings_cells_constants.h [add] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/cells/settings_cells_constants.mm [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm [add] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/cells/settings_switch_item.h [add] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.h [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.mm [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item_unittest.mm [modify] https://crrev.com/ddcc57cbbfba4268635a9b06ba3ec3607d68b2a4/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2de0dc43f4044a0c75c230c2875d17f3d4741d03 commit 2de0dc43f4044a0c75c230c2875d17f3d4741d03 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Oct 24 15:44:57 2018 [iOS] Convert AboutChromeCollectionVC to TableView This CL converts AboutChromeCollectionViewController to use TableView instead of collection view. It also updates the VersionItem to be displayed as a cell instead of as an item. It means that the callback when the version is tapped cannot happen in the VC. So the cell has a button copying the version to the pasteboard when tapped. Bug: 894791 Change-Id: I6cdae4b09235bb6f72e2dbffac88a5dd9f78e67a Reviewed-on: https://chromium-review.googlesource.com/c/1291390 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602350} [modify] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/a6bce5f003f0fc8cb68e2a47b0ff488fc013aa4c/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.h [delete] https://crrev.com/a6bce5f003f0fc8cb68e2a47b0ff488fc013aa4c/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm [delete] https://crrev.com/a6bce5f003f0fc8cb68e2a47b0ff488fc013aa4c/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm [add] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/about_chrome_table_view_controller.h [add] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/about_chrome_table_view_controller.mm [add] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/about_chrome_table_view_controller_unittest.mm [modify] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/cells/BUILD.gn [modify] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/cells/version_item.h [modify] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/cells/version_item.mm [modify] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/cells/version_item_unittest.mm [modify] https://crrev.com/2de0dc43f4044a0c75c230c2875d17f3d4741d03/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78b9bb38c353fed0dfd7069129f7828a5af972fb commit 78b9bb38c353fed0dfd7069129f7828a5af972fb Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Oct 26 16:59:45 2018 [iOS] Convert TranslateCollectionVC to UITableView Also fixes bugs with the SwitchItem and adding test for the ChromeTableViewControllerTest platform test helper. Bug: 894791 Change-Id: Ib2d4631ac65ce380dbe18d43603a34e74baec66c Reviewed-on: https://chromium-review.googlesource.com/c/1297977 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#603121} [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/cells/settings_cells_constants.h [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/cells/settings_cells_constants.mm [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [delete] https://crrev.com/bfae0f8bd1d0003ea7914d552b921a499b4b960a/ios/chrome/browser/ui/settings/translate_collection_view_controller.h [delete] https://crrev.com/bfae0f8bd1d0003ea7914d552b921a499b4b960a/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm [add] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/translate_table_view_controller.h [add] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/translate_table_view_controller.mm [rename] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/settings/translate_table_view_controller_unittest.mm [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.h [modify] https://crrev.com/78b9bb38c353fed0dfd7069129f7828a5af972fb/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/519df6dd5bb483999d2ee57926c90e6a381684f8 commit 519df6dd5bb483999d2ee57926c90e6a381684f8 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Nov 12 11:45:23 2018 [iOS] Update SettingsRootTableViewController This CL adds features available to the collection view root panel to the table view root panel in the settings. More specifically it adds support for the top right button. It also adds a helper to remove items from the model to the ChromeTableViewController. Bug: 894791 Change-Id: I1d0f4836f160379a0d8ab71e91f3a0ad13a38e5f Reviewed-on: https://chromium-review.googlesource.com/c/1304437 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607192} [modify] https://crrev.com/519df6dd5bb483999d2ee57926c90e6a381684f8/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/519df6dd5bb483999d2ee57926c90e6a381684f8/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/519df6dd5bb483999d2ee57926c90e6a381684f8/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [add] https://crrev.com/519df6dd5bb483999d2ee57926c90e6a381684f8/ios/chrome/browser/ui/settings/settings_root_table_view_controller_unittest.mm [modify] https://crrev.com/519df6dd5bb483999d2ee57926c90e6a381684f8/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [modify] https://crrev.com/519df6dd5bb483999d2ee57926c90e6a381684f8/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b269a4b2030a61eb75b06564c555e81e0a5dcf50 commit b269a4b2030a61eb75b06564c555e81e0a5dcf50 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Nov 13 09:39:10 2018 [iOS] Add delete in SettingsTableView's toolbar This CL adds a toolbar with a "delete" item in the SettingsRootTableViewController, displayed when the item selection is not nil. Bug: 894791 Change-Id: Ifffc2b774ab96bad97814cdf80829f2f0b74d77a Reviewed-on: https://chromium-review.googlesource.com/c/1331469 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607534} [modify] https://crrev.com/b269a4b2030a61eb75b06564c555e81e0a5dcf50/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/b269a4b2030a61eb75b06564c555e81e0a5dcf50/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/b269a4b2030a61eb75b06564c555e81e0a5dcf50/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [modify] https://crrev.com/b269a4b2030a61eb75b06564c555e81e0a5dcf50/ios/chrome/browser/ui/settings/settings_root_table_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/626976f2abed296478ac20b0586cd01c122d724f commit 626976f2abed296478ac20b0586cd01c122d724f Author: Yi Su <mrsuyi@chromium.org> Date: Thu Nov 15 11:04:17 2018 Migrate ContentSettingsCollectionViewController from CollectionViewController to ChromeTableViewController. This CL migrates the ContentSettingsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: I8f389901aa11f4a19eb1049cfa6708ee8fb65c2b Reviewed-on: https://chromium-review.googlesource.com/c/1335607 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608324} [modify] https://crrev.com/626976f2abed296478ac20b0586cd01c122d724f/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/2b277a070de21e2ca35b0e07b222871c67e278c8/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.h [add] https://crrev.com/626976f2abed296478ac20b0586cd01c122d724f/ios/chrome/browser/ui/settings/content_settings_table_view_controller.h [rename] https://crrev.com/626976f2abed296478ac20b0586cd01c122d724f/ios/chrome/browser/ui/settings/content_settings_table_view_controller.mm [rename] https://crrev.com/626976f2abed296478ac20b0586cd01c122d724f/ios/chrome/browser/ui/settings/content_settings_table_view_controller_unittest.mm [modify] https://crrev.com/626976f2abed296478ac20b0586cd01c122d724f/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff commit e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff Author: Yi Su <mrsuyi@chromium.org> Date: Thu Nov 15 11:59:36 2018 Migrate VoicesearchCollectionViewController from CollectionViewController to ChromeTableViewControllerStyleWithAppBar. This CL migrates the VoicesearchCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: I3aee06d07573c2ca3560eb0dc093951382d7fb2c Reviewed-on: https://chromium-review.googlesource.com/c/1335934 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608329} [modify] https://crrev.com/e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [add] https://crrev.com/e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff/ios/chrome/browser/ui/settings/voice_search_table_view_controller.h [rename] https://crrev.com/e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff/ios/chrome/browser/ui/settings/voice_search_table_view_controller.mm [rename] https://crrev.com/e484b25d69d75f05ae4d43f2ac19f1cbbedc18ff/ios/chrome/browser/ui/settings/voice_search_table_view_controller_unittest.mm [delete] https://crrev.com/8aecdaf94381107b76dc01b78e7e003dcdf2c184/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/868a311f4cafbb04662acb508ac5f168b8b2fe47 commit 868a311f4cafbb04662acb508ac5f168b8b2fe47 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Nov 15 12:52:52 2018 [iOS] Update EG matchers for new Settings cells This CL updates the chrome matchers and actions functions to be compatible with the new type of cells in the Settings. Bug: 894791 Change-Id: I10d899a3e4946b9e171bdf8909d10ce0f50c8b2a Reviewed-on: https://chromium-review.googlesource.com/c/1333368 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#608336} [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/browser/ui/settings/block_popups_egtest.mm [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/test/earl_grey/chrome_actions.h [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/test/earl_grey/chrome_actions.mm [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/868a311f4cafbb04662acb508ac5f168b8b2fe47/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86662386b9a581028886c2d9510855655046a50b commit 86662386b9a581028886c2d9510855655046a50b Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 16 11:33:12 2018 [iOS] Migrate BlockPopupsCollectionVC to TableView This CL migrates BlockPopupsCollectionViewController so it is a UITableViewController instead of a MDCCollectionViewController. It also fixes few corner cases with the display of the bottom toolbar in the SettingsRootTableViewController. It also add a check for the SectionHeader in the Chrome Table View test case. Bug: 894791 Change-Id: I82d67940846c7a630cadaac5ff07c00cf811113b Reviewed-on: https://chromium-review.googlesource.com/c/1331387 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608731} [modify] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.h [modify] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/block_popups_egtest.mm [add] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/block_popups_table_view_controller.h [rename] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/block_popups_table_view_controller.mm [rename] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/block_popups_table_view_controller_unittest.mm [modify] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/content_settings_table_view_controller.mm [modify] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [modify] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.h [modify] https://crrev.com/86662386b9a581028886c2d9510855655046a50b/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01aa6422a62dd8773f5412b20c26e60bd05313e3 commit 01aa6422a62dd8773f5412b20c26e60bd05313e3 Author: Yi Su <mrsuyi@chromium.org> Date: Fri Nov 16 14:57:14 2018 Set selectionStyle to UITableViewCellSelectionStyleNone for SettingsSwitchCell. SettingsSwitchCell should not have a UITableViewCellSelection animation, so set selectionStyle to UITableViewCellSelectionStyleNone when configuring SettingsSwitchCell. Bug: 894791 Change-Id: I21da349f8b888f16af2466d72c1957f17adfe200 Reviewed-on: https://chromium-review.googlesource.com/c/1340260 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608777} [modify] https://crrev.com/01aa6422a62dd8773f5412b20c26e60bd05313e3/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc28aba9065fc439628e899f573720f00ffc6477 commit fc28aba9065fc439628e899f573720f00ffc6477 Author: Yi Su <mrsuyi@chromium.org> Date: Fri Nov 16 17:16:27 2018 Migrate HandoffCollectionViewController from CollectionViewController to ChromeTableViewControllerStyleWithAppBar. This CL migrates the HandoffCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: I4b6e25e3729ad2150fbc49fd6c71c54229f76f31 Reviewed-on: https://chromium-review.googlesource.com/c/1340326 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608820} [modify] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/caaf203275834c8e26b822b3d84e63ce6aeaa264/ios/chrome/browser/ui/settings/handoff_collection_view_controller.h [delete] https://crrev.com/caaf203275834c8e26b822b3d84e63ce6aeaa264/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm [add] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/ios/chrome/browser/ui/settings/handoff_table_view_controller.h [add] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/ios/chrome/browser/ui/settings/handoff_table_view_controller.mm [modify] https://crrev.com/fc28aba9065fc439628e899f573720f00ffc6477/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a1c88973a952edc45885284d8650d737b7c2be4 commit 4a1c88973a952edc45885284d8650d737b7c2be4 Author: Yi Su <mrsuyi@chromium.org> Date: Tue Nov 20 14:50:44 2018 Migrate PrivacyCollectionViewController from CollectionViewController to ChromeTableViewController. This CL migrates the PrivacyCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: Ia35b023b4fc1231d6ef35c93fb1ab8961d56ea40 Reviewed-on: https://chromium-review.googlesource.com/c/1340330 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609698} [modify] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/31713864d2dc4dd7580e90aba522eeaf24345cba/ios/chrome/browser/ui/settings/privacy_collection_view_controller.h [add] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/settings/privacy_table_view_controller.h [rename] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/settings/privacy_table_view_controller.mm [rename] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/settings/privacy_table_view_controller_unittest.mm [modify] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.h [modify] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm [modify] https://crrev.com/4a1c88973a952edc45885284d8650d737b7c2be4/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb65f6006dc29f4510ef0cf300202f5871780e0f commit cb65f6006dc29f4510ef0cf300202f5871780e0f Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Nov 20 19:15:21 2018 [iOS] Move AutofillEditItem to Legacy This CL prepares the AutofillEditItem to be changed to be used with UITableView. Bug: 894791 Change-Id: Iee510dd6cf2df483ef2977fba9ff4ca3a85f9326 Reviewed-on: https://chromium-review.googlesource.com/c/1344135 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609766} [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/autofill/cells/BUILD.gn [rename] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/autofill/cells/legacy_autofill_edit_item.h [rename] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/autofill/cells/legacy_autofill_edit_item.mm [rename] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/autofill/cells/legacy_autofill_edit_item_unittest.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/payments/payment_request_edit_view_controller_unittest.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/payments/payment_request_editor_field.h [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/cb65f6006dc29f4510ef0cf300202f5871780e0f/ios/showcase/payments/sc_payments_editor_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b59fb04398c9f782d8187c252a6bcb5dab566cb6 commit b59fb04398c9f782d8187c252a6bcb5dab566cb6 Author: Yi Su <mrsuyi@chromium.org> Date: Tue Nov 20 19:58:28 2018 Migrate SearchEngineSettingsCollectionViewController from CollectionViewController to ChromeTableViewController, and show search engines' keywords in Settings. This CL migrates the SearchEngineSettingsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. This CL also enables showing search engines' keywords in Settings for security considerations. Bug: 894791, 433824 Change-Id: I0eb6cf7081159d13cf389750f99ca13ee162c9d6 Reviewed-on: https://chromium-review.googlesource.com/c/1344134 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609781} [modify] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/27a0372562de554946280cc45f7930623aeea27d/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.h [add] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/search_engine_table_view_controller.h [rename] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/search_engine_table_view_controller.mm [rename] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/search_engine_table_view_controller_unittest.mm [modify] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/b59fb04398c9f782d8187c252a6bcb5dab566cb6/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbfb06dc31d84283f96be0f295acc0fff918d11a commit fbfb06dc31d84283f96be0f295acc0fff918d11a Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Nov 21 08:40:57 2018 [iOS] Move AutofillEditCollectionVC to legacy This is needed to move the subclasses to UITableView one by one. Bug: 894791 Change-Id: I6790f649df2ca61cfd2551ac9afe6fff732a39dd Reviewed-on: https://chromium-review.googlesource.com/c/1344057 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609953} [modify] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.h [modify] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm [delete] https://crrev.com/3d1221b69e265c2e47c9225358610bda6c14ddde/ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller+protected.h [delete] https://crrev.com/3d1221b69e265c2e47c9225358610bda6c14ddde/ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.h [modify] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.h [add] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/legacy_autofill_edit_collection_view_controller+protected.h [add] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/legacy_autofill_edit_collection_view_controller.h [rename] https://crrev.com/fbfb06dc31d84283f96be0f295acc0fff918d11a/ios/chrome/browser/ui/settings/legacy_autofill_edit_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25709b788fbf94be07203a9483955888073ed868 commit 25709b788fbf94be07203a9483955888073ed868 Author: Yi Su <mrsuyi@chromium.org> Date: Thu Nov 22 15:49:21 2018 Add "masked" property to TableViewTextItem to support showing masked text. PasswordDetailItem can display an uneditable string as plain text("abc") or masked text("XXX"). This CL add the same functionality in TableViewTextItem to avoid creating another class like TableViewPasswordItem. This is a preparation work for migrating Settings from MDC to UIKit. Bug: 894791 Change-Id: I34538659d6879246c66e9aafd4d88cb8d7822f3c Reviewed-on: https://chromium-review.googlesource.com/c/1346151 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#610414} [modify] https://crrev.com/25709b788fbf94be07203a9483955888073ed868/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/25709b788fbf94be07203a9483955888073ed868/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/25709b788fbf94be07203a9483955888073ed868/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/25709b788fbf94be07203a9483955888073ed868/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h [modify] https://crrev.com/25709b788fbf94be07203a9483955888073ed868/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm [modify] https://crrev.com/25709b788fbf94be07203a9483955888073ed868/ios/chrome/browser/ui/table_view/cells/table_view_text_item_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e43dc3b5df67c7bce0956254bdcee2f58a617ed commit 1e43dc3b5df67c7bce0956254bdcee2f58a617ed Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Nov 27 09:14:59 2018 [iOS] Create TableView AutofillEditItem This CL creates the AutofillEditItem to replace the LegacyAutofillEditItem in UITableView. The support for Dynamic Type will be done later to keep this close to the legacy implementation. Bug: 894791 Change-Id: I9e0e9ab81498dbafe5357487a7249f23c7620df5 Reviewed-on: https://chromium-review.googlesource.com/c/1344062 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#611050} [modify] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/autofill/cells/BUILD.gn [add] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.h [add] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm [add] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/autofill/cells/autofill_edit_item_unittest.mm [modify] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/collection_view/cells/collection_view_cell_style.h [modify] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/1e43dc3b5df67c7bce0956254bdcee2f58a617ed/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45abfa2024dbd48ed1481aee29aad1eeef546a0b commit 45abfa2024dbd48ed1481aee29aad1eeef546a0b Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Nov 28 10:50:02 2018 [iOS] Create AutofillEditTableVC superclass This CL creates the AutofillEditTableVC, to be the replacement of the LegacyAutofillEditCollectionVC. Bug: 894791 Change-Id: I7dfff03765db8c856e52b226905ae4555bde89b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345973 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#611641} [modify] https://crrev.com/45abfa2024dbd48ed1481aee29aad1eeef546a0b/ios/chrome/browser/ui/settings/BUILD.gn [add] https://crrev.com/45abfa2024dbd48ed1481aee29aad1eeef546a0b/ios/chrome/browser/ui/settings/autofill_edit_table_view_controller+protected.h [add] https://crrev.com/45abfa2024dbd48ed1481aee29aad1eeef546a0b/ios/chrome/browser/ui/settings/autofill_edit_table_view_controller.h [add] https://crrev.com/45abfa2024dbd48ed1481aee29aad1eeef546a0b/ios/chrome/browser/ui/settings/autofill_edit_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b1085b3a9630470e39bd65b6804382114129f6d commit 7b1085b3a9630470e39bd65b6804382114129f6d Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Nov 28 12:03:09 2018 [iOS] Convert AutofillProfileEditCollectionVC to UITableView This CL converts the ViewController, keeping the same features. Bug: 894791 Change-Id: I8cd336a878d42d6a69bed10e3b22c56d842e5c0d Reviewed-on: https://chromium-review.googlesource.com/c/1345974 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#611661} [modify] https://crrev.com/7b1085b3a9630470e39bd65b6804382114129f6d/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/7b1085b3a9630470e39bd65b6804382114129f6d/ios/chrome/browser/ui/settings/autofill_edit_table_view_controller.mm [modify] https://crrev.com/7b1085b3a9630470e39bd65b6804382114129f6d/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm [delete] https://crrev.com/386c11692f8ebf1935befd387ed0af9e36f6422c/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.h [add] https://crrev.com/7b1085b3a9630470e39bd65b6804382114129f6d/ios/chrome/browser/ui/settings/autofill_profile_edit_table_view_controller.h [rename] https://crrev.com/7b1085b3a9630470e39bd65b6804382114129f6d/ios/chrome/browser/ui/settings/autofill_profile_edit_table_view_controller.mm [rename] https://crrev.com/7b1085b3a9630470e39bd65b6804382114129f6d/ios/chrome/browser/ui/settings/autofill_profile_edit_table_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0195ac20958e8300edec91d62c3a1225e5b272f8 commit 0195ac20958e8300edec91d62c3a1225e5b272f8 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Nov 28 13:48:13 2018 [iOS] Add DynamicType to AutofillEditItem This CL adds support for Dynamic Type in the AutofillEditItem. Bug: 894791 Change-Id: I1e25084fed4cb176b332fc7fa7e4af0e7957323c Reviewed-on: https://chromium-review.googlesource.com/c/1346454 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#611675} [modify] https://crrev.com/0195ac20958e8300edec91d62c3a1225e5b272f8/ios/chrome/browser/ui/autofill/cells/BUILD.gn [modify] https://crrev.com/0195ac20958e8300edec91d62c3a1225e5b272f8/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm [modify] https://crrev.com/0195ac20958e8300edec91d62c3a1225e5b272f8/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1746c74b4336bd8964ea197bfa33bc8bc0daad40 commit 1746c74b4336bd8964ea197bfa33bc8bc0daad40 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Nov 28 14:12:22 2018 [iOS] Create new AutofillDataItem This CL moves the existing AutofillDataItem to legacy and creates a new item compatible with UITableView. Bug: 894791 Change-Id: Id3d7af497b08e99d8977e2f77385ea5e55f5c22b Reviewed-on: https://chromium-review.googlesource.com/c/1350953 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611683} [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/autofill_data_item.h [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/autofill_data_item.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/autofill_data_item_unittest.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn [add] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/legacy/legacy_autofill_data_item.h [add] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/legacy/legacy_autofill_data_item.mm [add] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/cells/legacy/legacy_autofill_data_item_unittest.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/1746c74b4336bd8964ea197bfa33bc8bc0daad40/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d3c74352969f23f1c1e9f84230f2e653747ba25 commit 5d3c74352969f23f1c1e9f84230f2e653747ba25 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Nov 29 09:27:41 2018 [iOS] Update Encryption to UITableView This CL updates the EncryptionCollectionVC to use a UITableVC instead of the MDCCollectionVC. Bug: 894791 Change-Id: I875bc29cb3a7b27242897e7301a0e7fe761d1fcd Reviewed-on: https://chromium-review.googlesource.com/c/1350832 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#612116} [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/cells/encryption_item.h [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/cells/encryption_item.mm [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/cells/encryption_item_unittest.mm [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/google_services_settings_coordinator.mm [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [delete] https://crrev.com/cd8b2fb824e19b6406a150fb4ff932a0375ea505/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.h [add] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/sync_encryption_table_view_controller.h [rename] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/sync_encryption_table_view_controller.mm [rename] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/sync_encryption_table_view_controller_unittest.mm [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm [modify] https://crrev.com/5d3c74352969f23f1c1e9f84230f2e653747ba25/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09f852a1086fd3ad4314ab0d03ff38fccc309aa5 commit 09f852a1086fd3ad4314ab0d03ff38fccc309aa5 Author: Yi Su <mrsuyi@chromium.org> Date: Thu Nov 29 12:31:49 2018 Migrate PasswordDetailsCollectionViewController from CollectionViewController to ChromeTableViewController. This CL migrates the PasswordDetailsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791,751311 Change-Id: I3f76e28c1e42720d4d316b2a9018c01313646fbb Reviewed-on: https://chromium-review.googlesource.com/c/1346951 Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612162} [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/6461382f9332d4c3302c5ead5b1d97df2e288b89/ios/chrome/browser/ui/settings/password_details_collection_view_controller.h [delete] https://crrev.com/6461382f9332d4c3302c5ead5b1d97df2e288b89/ios/chrome/browser/ui/settings/password_details_collection_view_controller_delegate.h [delete] https://crrev.com/6461382f9332d4c3302c5ead5b1d97df2e288b89/ios/chrome/browser/ui/settings/password_details_collection_view_controller_for_testing.h [delete] https://crrev.com/6461382f9332d4c3302c5ead5b1d97df2e288b89/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm [add] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/password_details_table_view_controller+testing.h [add] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/password_details_table_view_controller.h [rename] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/password_details_table_view_controller.mm [add] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/password_details_table_view_controller_delegate.h [add] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/password_details_table_view_controller_unittest.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.h [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm [modify] https://crrev.com/09f852a1086fd3ad4314ab0d03ff38fccc309aa5/ios/chrome/test/app/password_test_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38797b5c5610994ae7926976a613339d36c53b1a commit 38797b5c5610994ae7926976a613339d36c53b1a Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Nov 29 15:39:35 2018 [iOS] Convert ImportData to UITableView This CL converts ImportDataCollectionViewController to use UITableView instead of MDCCollectionViewController. Bug: 894791 Change-Id: I38a99ae849ef2b30d90820b197f4ba56edadabba Reviewed-on: https://chromium-review.googlesource.com/c/1352156 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612205} [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.h [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.mm [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item_unittest.mm [rename] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/import_data_table_view_controller.h [rename] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/import_data_table_view_controller.mm [rename] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/import_data_table_view_controller_unittest.mm [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/settings_navigation_controller.h [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/browser/ui/settings/settings_navigation_controller.mm [modify] https://crrev.com/38797b5c5610994ae7926976a613339d36c53b1a/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6a95ca71e33c6526f67260b0400bbfd907dc33f commit b6a95ca71e33c6526f67260b0400bbfd907dc33f Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 03 12:09:01 2018 [iOS] Move AutofilProfileCollectionVC to TableVC This Moves the AutofilProfileCollectionViewController to use a UITableView instead of an MDCCollectionVC. It also reset _deletionInProgress to NO after doing an update, because it seems that it wasn't reset before (removing one entry ignored all model updates). Bug: 894791 Change-Id: I96b61cb71d25aae1d6974a7ae2612659803b6404 Reviewed-on: https://chromium-review.googlesource.com/c/1350956 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#613054} [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/payments/payment_request_cancel_pay_abort_egtest.mm [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/d01059074123d6ab49659f646ec042661b55bab2/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.h [delete] https://crrev.com/d01059074123d6ab49659f646ec042661b55bab2/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm [add] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/autofill_profile_table_view_controller.h [add] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/autofill_profile_table_view_controller.mm [rename] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/autofill_profile_table_view_controller_unittest.mm [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/settings_navigation_controller.h [modify] https://crrev.com/b6a95ca71e33c6526f67260b0400bbfd907dc33f/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f89c208303009df6334d2f961e7e5e5a4e6fcc7 commit 8f89c208303009df6334d2f961e7e5e5a4e6fcc7 Author: Yi Su <mrsuyi@chromium.org> Date: Thu Dec 06 16:22:57 2018 Trivial fix in PasswordDetailsTableViewController. This CL changes the _weakDelegate of PasswordDetailsTableViewController from an instance var to a property, and replaces the mock class in PasswordDetailsTableViewControllerUnittest with OCMock. Bug: 894791 Change-Id: I1cbb95e2f8aa3fb6befd3010040b0fe1ff4463d9 Reviewed-on: https://chromium-review.googlesource.com/c/1361245 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#614376} [modify] https://crrev.com/8f89c208303009df6334d2f961e7e5e5a4e6fcc7/ios/chrome/browser/ui/settings/password_details_table_view_controller.mm [modify] https://crrev.com/8f89c208303009df6334d2f961e7e5e5a4e6fcc7/ios/chrome/browser/ui/settings/password_details_table_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f commit 1bf6ef7848e79f9503fc7a812aa6f0e065c7555f Author: Yi Su <mrsuyi@chromium.org> Date: Wed Dec 12 12:21:33 2018 Migrate SavePasswordsCollectionViewController. This CL migrates the SavePasswordsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. old version UI: https://drive.google.com/open?id=1wep_qWxpoFYed6K3k2y2uwN6nJZut5f3 https://drive.google.com/open?id=1n_Vzc5AjlnrmAL5BmaGEuY18kG_3DKL4 https://drive.google.com/open?id=1G3ceF52yDQcg2WDvthP7dIPCy-BND_w1 new version UI: https://drive.google.com/open?id=1HC33oWDWtgd0V1daf7OYceUo7zj5dB8t https://drive.google.com/open?id=1P7wi_a47hpWzzB30nzIV9JIu1puwGL8r https://drive.google.com/open?id=1E1EYLq56jsy9QjSkzqcPTUCdV0XBkeS1 Bug: 894791,751311 Change-Id: I7ae4b244a9eb18d0c4af556ae2ed39da4fec0451 Reviewed-on: https://chromium-review.googlesource.com/c/1361241 Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615861} [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/cells/settings_search_item.h [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/cells/settings_search_item.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/password_details_table_view_controller.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [add] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/passwords_table_view_controller.h [rename] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/passwords_table_view_controller.mm [add] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/passwords_table_view_controller_unittest.mm [delete] https://crrev.com/9aa69dc23c484b7364f446e0acebbb32f0f3e3f7/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.h [delete] https://crrev.com/9aa69dc23c484b7364f446e0acebbb32f0f3e3f7/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/settings_navigation_controller.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/1bf6ef7848e79f9503fc7a812aa6f0e065c7555f/ios/chrome/test/app/password_test_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f8f18b0a61db49c199f52d58123226b778fa843 commit 2f8f18b0a61db49c199f52d58123226b778fa843 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Dec 13 13:20:09 2018 [iOS] Move authentication cells to their folder This CL moves the cells used by the authentication to their own folder. It will allow the settings to use those cells later. Bug: 894791 Change-Id: I2f09eaa853fe782d4400e6f3f5a549ad544a1666 Reviewed-on: https://chromium-review.googlesource.com/c/1373763 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#616290} [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/metrics/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/metrics/ukm_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/BUILD.gn [add] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/BUILD.gn [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/account_control_item.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/account_control_item.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/account_control_item_unittest.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_item.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_item.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_item_unittest.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view_configurator.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view_configurator.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view_consumer.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view_delegate.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/signin_promo_view_unittest.mm [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/table_view_signin_promo_item.h [rename] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/cells/table_view_signin_promo_item.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/authentication/signin_promo_view_mediator_unittest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/cells/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_promo_item.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_signin_promo_cell.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/recent_tabs/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/sync_utils/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/signin_interaction/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/browser/ui/table_view/cells/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/test/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/test/app/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/test/app/signin_test_util.mm [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/2f8f18b0a61db49c199f52d58123226b778fa843/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c3c29bca55f224a900d8e6ba9d968defe2b59ef commit 0c3c29bca55f224a900d8e6ba9d968defe2b59ef Author: Yi Su <mrsuyi@chromium.org> Date: Thu Dec 13 17:04:34 2018 Migrate autofill_credit_card_edit VC. This CL migrates the AutofillCreditCardCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. This CL doesn't introduce any UI change. Bug: 894791 Change-Id: Id31f7639caf532367e1edc320f570572fcfb77a2 Reviewed-on: https://chromium-review.googlesource.com/c/1375709 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#616340} [modify] https://crrev.com/0c3c29bca55f224a900d8e6ba9d968defe2b59ef/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/0c3c29bca55f224a900d8e6ba9d968defe2b59ef/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm [delete] https://crrev.com/26294d4e68751e61da8a4fe5fba13b4f96855ce4/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.h [add] https://crrev.com/0c3c29bca55f224a900d8e6ba9d968defe2b59ef/ios/chrome/browser/ui/settings/autofill_credit_card_edit_table_view_controller.h [rename] https://crrev.com/0c3c29bca55f224a900d8e6ba9d968defe2b59ef/ios/chrome/browser/ui/settings/autofill_credit_card_edit_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc03906cd4105b6a15d9da247fc3eb484960a20e commit dc03906cd4105b6a15d9da247fc3eb484960a20e Author: Yi Su <mrsuyi@chromium.org> Date: Fri Dec 14 10:42:45 2018 Create constants for TableViewSeparatorInset. This CL creates 2 constants for TableViewSeparatorInset and remove those in classes which extend ChromeTableViewController. Bug: 894791 Change-Id: If336b07bb399e124c1716b7ebf8480d5ddc8e5ce Reviewed-on: https://chromium-review.googlesource.com/c/1375740 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#616627} [modify] https://crrev.com/dc03906cd4105b6a15d9da247fc3eb484960a20e/ios/chrome/browser/ui/settings/search_engine_table_view_controller.mm [modify] https://crrev.com/dc03906cd4105b6a15d9da247fc3eb484960a20e/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm [modify] https://crrev.com/dc03906cd4105b6a15d9da247fc3eb484960a20e/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [modify] https://crrev.com/dc03906cd4105b6a15d9da247fc3eb484960a20e/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b4f3fb965233af814928792758c869ed72c4fac commit 3b4f3fb965233af814928792758c869ed72c4fac Author: Yi Su <mrsuyi@chromium.org> Date: Fri Dec 14 13:22:56 2018 Migrate credit card VC. This CL migrates the AutofillCreditCardCollectionViewController from SettingsRootCollectionViewController, which is based on MDCCollectionViewController, to SettingsRootTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: I0fe0e31782b01bdc8b5ad5ccdad739b07781d638 Reviewed-on: https://chromium-review.googlesource.com/c/1377413 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#616650} [modify] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm [modify] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/cf9d9cc8503c2aaa67c759eaadaf1fc78afc4149/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.h [delete] https://crrev.com/cf9d9cc8503c2aaa67c759eaadaf1fc78afc4149/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm [delete] https://crrev.com/cf9d9cc8503c2aaa67c759eaadaf1fc78afc4149/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller_unittest.mm [modify] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm [add] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/autofill_credit_card_table_view_controller.h [add] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/autofill_credit_card_table_view_controller.mm [add] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/autofill_credit_card_table_view_controller_unittest.mm [modify] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/3b4f3fb965233af814928792758c869ed72c4fac/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bba8a6887b09a8b5be71426272d7721f3df4df6b commit bba8a6887b09a8b5be71426272d7721f3df4df6b Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Dec 14 14:29:48 2018 [iOS] Create TableViewAccountItem This CL creates the equivalent of CollectionViewAccountItem for TableView. Bug: 894791 Change-Id: I8ab17481bf1a8d37a33dfaedf9e5dbf6ff9b9359 Reviewed-on: https://chromium-review.googlesource.com/c/1373838 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#616664} [modify] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/authentication/cells/BUILD.gn [add] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/authentication/cells/table_view_account_item.h [add] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/authentication/cells/table_view_account_item.mm [add] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/authentication/cells/table_view_account_item_unittest.mm [modify] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.h [modify] https://crrev.com/bba8a6887b09a8b5be71426272d7721f3df4df6b/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39d38f063e6062be6d768219a722b975b9cfb5ea commit 39d38f063e6062be6d768219a722b975b9cfb5ea Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Dec 14 15:25:07 2018 [iOS] Create new AccountControlItem This CL moves the existing AccountControlItem to Legacy and creates a new AccountControlItem compatible with UITableView. Bug: 894791 Change-Id: I22a6ececd54ebd030932ea977e29b8742f6f5501 Reviewed-on: https://chromium-review.googlesource.com/c/1373820 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#616682} [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/BUILD.gn [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/account_control_item.h [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/account_control_item.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/account_control_item_unittest.mm [add] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/legacy_account_control_item.h [add] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/legacy_account_control_item.mm [add] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/cells/legacy_account_control_item_unittest.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/39d38f063e6062be6d768219a722b975b9cfb5ea/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fac749b6ae5fb19fbc39b008777ac8fc9c0c815 commit 7fac749b6ae5fb19fbc39b008777ac8fc9c0c815 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Dec 14 16:28:50 2018 [iOS] Option to prevent user interaction in settings This CL adds an option to prevent the user interactions in the settings panels backed with a TableView. This feature already exists for the panels backed with a Collection. Bug: 894791 Change-Id: I80abf7c5f8dc0ae1d1c6ae5177a6f55ec44ff1f1 Reviewed-on: https://chromium-review.googlesource.com/c/1373821 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#616703} [modify] https://crrev.com/7fac749b6ae5fb19fbc39b008777ac8fc9c0c815/ios/chrome/browser/ui/settings/settings_root_table_view_controller.h [modify] https://crrev.com/7fac749b6ae5fb19fbc39b008777ac8fc9c0c815/ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm
Issue 889702 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12c83c1d10ca587a50c1be1b3aa710a6969079e7 commit 12c83c1d10ca587a50c1be1b3aa710a6969079e7 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Dec 18 13:11:54 2018 [iOS] Fix TableViewAccountItem constraints This CL fixes the centering constraints for the TableViewAccountItem. Bug: 894791 Change-Id: Id1d2e421541e2a0595a554551468354aa6dca83b Reviewed-on: https://chromium-review.googlesource.com/c/1380015 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#617463} [modify] https://crrev.com/12c83c1d10ca587a50c1be1b3aa710a6969079e7/ios/chrome/browser/ui/authentication/cells/table_view_account_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06a6e2053bdae0fb34953bf6921bd1c4342ebbee commit 06a6e2053bdae0fb34953bf6921bd1c4342ebbee Author: Yi Su <mrsuyi@chromium.org> Date: Wed Dec 19 12:29:53 2018 Migrate SyncEncryptionPassphrase VC. This CL migrates the SyncEncryptionPassphraseCollectionViewController and SyncCreatePassphraseCollectionViewController from SettingsRootCollectionViewController, which is based on MDCCollectionViewController, to SettingsRootTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: I22f6f6420c5d63e2d3901ae93c8f52fc37b81254 Reviewed-on: https://chromium-review.googlesource.com/c/1382075 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#617808} [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/byo_textfield_item.h [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/byo_textfield_item.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/byo_textfield_item_unittest.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/card_multiline_item.h [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/card_multiline_item.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/card_multiline_item_unittest.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/passphrase_error_item.h [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/passphrase_error_item.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/cells/passphrase_error_item_unittest.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/google_services_settings_coordinator.mm [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/passphrase_table_view_controller_test.h [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/passphrase_table_view_controller_test.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/settings_navigation_controller.mm [delete] https://crrev.com/82795fc046abfd2442e83c08f1431b3885410bea/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller.h [add] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_create_passphrase_table_view_controller.h [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_create_passphrase_table_view_controller.mm [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_create_passphrase_table_view_controller_unittest.mm [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_encryption_passphrase_table_view_controller.h [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_encryption_passphrase_table_view_controller.mm [rename] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_encryption_passphrase_table_view_controller_unittest.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_encryption_table_view_controller.mm [modify] https://crrev.com/06a6e2053bdae0fb34953bf6921bd1c4342ebbee/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dd3e1214aa755a011aa25ececeb06826ed4dff7 commit 8dd3e1214aa755a011aa25ececeb06826ed4dff7 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Dec 19 21:23:15 2018 [iOS] Renaming SyncSwitchItem to LegacySyncSwitchItem This CL prepares the GoogleSyncServicesViewController to be changed to be used with UITableView. Bug: 894791 Change-Id: I348cd9ee24695d7b07792b428035dfdf2f2a5a32 Reviewed-on: https://chromium-review.googlesource.com/c/1383034 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#617949} [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/metrics/ukm_egtest.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/cells/BUILD.gn [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn [rename] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/cells/legacy/legacy_sync_switch_item.h [rename] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/cells/legacy/legacy_sync_switch_item.mm [rename] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/cells/legacy/legacy_sync_switch_item_unittest.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/google_services_settings_mediator.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/google_services_settings_view_controller.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/test/earl_grey/chrome_actions.mm [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/8dd3e1214aa755a011aa25ececeb06826ed4dff7/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9136d45219a8234c18b37d84437914d17d6656f2 commit 9136d45219a8234c18b37d84437914d17d6656f2 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Dec 26 13:33:03 2018 [iOS] Convert AccountCollectionVC to TableView This CL changes the AccountCollectionViewController to become AccountTableViewController and use a UITableView instead of the MDCCollectionView. Bug: 894791 Change-Id: I0dcb07daa96181ba0d992b0bcc952450d2a81a21 Reviewed-on: https://chromium-review.googlesource.com/c/1373765 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Yi Su <mrsuyi@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#618926} [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/2faaa6e91fe70856f6562d26f6712844e8d806ae/ios/chrome/browser/ui/settings/accounts_collection_view_controller.h [rename] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/accounts_table_egtest.mm [add] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/accounts_table_view_controller.h [rename] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/accounts_table_view_controller.mm [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/privacy_table_view_controller.mm [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/settings_navigation_controller.h [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/browser/ui/settings/settings_navigation_controller.mm [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/9136d45219a8234c18b37d84437914d17d6656f2/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d966c4d1775ae491d0aec0a43de4a8d3b6391312 commit d966c4d1775ae491d0aec0a43de4a8d3b6391312 Author: gambard <gambard@chromium.org> Date: Mon Dec 31 13:45:35 2018 [iOS] Fix TableView Catalog This CL fixes some crashes in the Collection Cell Catalog. Bug: 894791 Change-Id: I2ae86bfbbd46cde6dbee1a28808c7d611b802961 Reviewed-on: https://chromium-review.googlesource.com/c/1392095 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619307} [modify] https://crrev.com/d966c4d1775ae491d0aec0a43de4a8d3b6391312/ios/chrome/browser/ui/authentication/cells/table_view_signin_promo_item.mm [modify] https://crrev.com/d966c4d1775ae491d0aec0a43de4a8d3b6391312/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/d966c4d1775ae491d0aec0a43de4a8d3b6391312/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb9e6ed759cfd6fe884590375e307affc5752f72 commit cb9e6ed759cfd6fe884590375e307affc5752f72 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 02 17:13:57 2019 [iOS] Fix Copied to Chrome button The cell wasn't converted to UITableViewCell. Bug: 894791 Change-Id: I44fdd29f4d3179eefa0d4515c4b8655bb77cd6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1392960 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619424} [modify] https://crrev.com/cb9e6ed759cfd6fe884590375e307affc5752f72/ios/chrome/browser/ui/settings/autofill_credit_card_edit_table_view_controller.mm [modify] https://crrev.com/cb9e6ed759cfd6fe884590375e307affc5752f72/ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.h [modify] https://crrev.com/cb9e6ed759cfd6fe884590375e307affc5752f72/ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.mm [modify] https://crrev.com/cb9e6ed759cfd6fe884590375e307affc5752f72/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9b1e3f7c12705ba417611add1e5b91bd06c351e commit c9b1e3f7c12705ba417611add1e5b91bd06c351e Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Jan 07 13:05:52 2019 [iOS] Convert first Settings screen This CL converts the first screen of the settings, from an MDCCollection to a UITableView. Bug: 894791 Change-Id: I32d8da0b732f695f0a65a47db702fa7de4a121a5 Reviewed-on: https://chromium-review.googlesource.com/c/1378098 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#620302} [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/settings_navigation_controller.h [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/settings_navigation_controller.mm [rename] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/settings_table_view_controller.h [rename] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/settings_table_view_controller.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/signin_settings_egtest.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/c9b1e3f7c12705ba417611add1e5b91bd06c351e/ios/chrome/test/earl_grey/chrome_matchers.mm
Comment 1 by bugdroid1@chromium.org
, Oct 16