New issue
Advanced search Search tips

Issue 894773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 879526



Sign in to add a comment

Get and display data to track progress of v8 london team metrics

Project Member Reported by perezju@chromium.org, Oct 12

Issue description

Filing this for discussions on which data to get, and track work done to make this happen.
 
Blockedon: 879526
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f608aa22d17466ae3472905ef6b55ea381b79f67

commit f608aa22d17466ae3472905ef6b55ea381b79f67
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Oct 19 10:34:56 2018

[soundwave] Add dashboard_service module

Start creating the services.dashboard_service module with a single
Describe method for now.

Old soundwave's dashboard_communicator is also changed to route calls
to this new service module. The plan is to eventually remove the
PerfDashboardCommunicator when it can be replaced by the new module.

Bug:  chromium:890691 
Bug:  chromium:894773 
Change-Id: Ie15ca47ca482304b8b6634c1809487f43432454f
Reviewed-on: https://chromium-review.googlesource.com/c/1283450
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[add] https://crrev.com/f608aa22d17466ae3472905ef6b55ea381b79f67/experimental/soundwave/services/dashboard_service.py
[modify] https://crrev.com/f608aa22d17466ae3472905ef6b55ea381b79f67/experimental/soundwave/services/user_services.py
[modify] https://crrev.com/f608aa22d17466ae3472905ef6b55ea381b79f67/experimental/soundwave/soundwave/dashboard_api.py
[modify] https://crrev.com/f608aa22d17466ae3472905ef6b55ea381b79f67/experimental/soundwave/soundwave/dashboard_api_test.py
[add] https://crrev.com/f608aa22d17466ae3472905ef6b55ea381b79f67/experimental/soundwave/services/dashboard_service_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a0b50a9a05900a7c59c5ce4d0e6ed1a870e938f5

commit a0b50a9a05900a7c59c5ce4d0e6ed1a870e938f5
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Oct 19 11:04:19 2018

[soundwave] Add module to get timeseries data for v8 study

Adding the concept of "study" modules which will make it easier to
gather data required to track measurements related to a particular
feature or team.

Bug:  chromium:894773 
Change-Id: I14451bf89018ce8d4a04fe5f56d797fd21d35179
Reviewed-on: https://chromium-review.googlesource.com/c/1277783
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/a0b50a9a05900a7c59c5ce4d0e6ed1a870e938f5/experimental/soundwave/bin/soundwave
[add] https://crrev.com/a0b50a9a05900a7c59c5ce4d0e6ed1a870e938f5/experimental/soundwave/soundwave/studies/__init__.py
[add] https://crrev.com/a0b50a9a05900a7c59c5ce4d0e6ed1a870e938f5/experimental/soundwave/soundwave/studies/v8_study.py
[modify] https://crrev.com/a0b50a9a05900a7c59c5ce4d0e6ed1a870e938f5/experimental/soundwave/soundwave/commands.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92ddcef22979298054283376d22b64241a1ee44b

commit 92ddcef22979298054283376d22b64241a1ee44b
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 19 11:35:57 2018

Roll src/third_party/catapult 2f3bd7e85ec6..f608aa22d174 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/2f3bd7e85ec6..f608aa22d174


git log 2f3bd7e85ec6..f608aa22d174 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 perezju@chromium.org [soundwave] Add dashboard_service module
2018-10-19 perezju@chromium.org [soundwave] Add timeseries --output-csv option


Created with:
  gclient setdep -r src/third_party/catapult@f608aa22d174

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:890691 , chromium:894773 , chromium:879526 
TBR=sullivan@chromium.org

Change-Id: Ie326b24cd52919b8620f0907de755467ef428687
Reviewed-on: https://chromium-review.googlesource.com/c/1290784
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601114}
[modify] https://crrev.com/92ddcef22979298054283376d22b64241a1ee44b/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1cb85713ba939eb9f0326077aad09f3f1d52ffa

commit b1cb85713ba939eb9f0326077aad09f3f1d52ffa
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 19 13:00:21 2018

Roll src/third_party/catapult f608aa22d174..a0b50a9a0590 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/f608aa22d174..a0b50a9a0590


git log f608aa22d174..a0b50a9a0590 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 perezju@chromium.org [soundwave] Add module to get timeseries data for v8 study


Created with:
  gclient setdep -r src/third_party/catapult@a0b50a9a0590

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:894773 
TBR=sullivan@chromium.org

Change-Id: If8e1f0cb20d29514f94113a444312891f2194f87
Reviewed-on: https://chromium-review.googlesource.com/c/1291149
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601125}
[modify] https://crrev.com/b1cb85713ba939eb9f0326077aad09f3f1d52ffa/DEPS

Blockedon: 868926
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d7fce6c098ea6cc2a286717b413d151c0a88df4c

commit d7fce6c098ea6cc2a286717b413d151c0a88df4c
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Oct 22 10:20:38 2018

[pinpoint_cli] Allow multiple jobs per configuration

Allow job_configs to trigger more than one job.

This will be used by v8 team to track a few metrics on all of:
v8.browsing_mobile, system_health.{common,memory}_mobile.

Bug:  chromium:894773 
Change-Id: Ic35c9d66c6b8a3b16119d4ffe7a60f6e7ba5fa03
Reviewed-on: https://chromium-review.googlesource.com/c/1288358
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Dave Tu <dtu@chromium.org>

[modify] https://crrev.com/d7fce6c098ea6cc2a286717b413d151c0a88df4c/experimental/soundwave/pinpoint_cli/commands.py
[modify] https://crrev.com/d7fce6c098ea6cc2a286717b413d151c0a88df4c/experimental/soundwave/bin/pinpoint_cli
[modify] https://crrev.com/d7fce6c098ea6cc2a286717b413d151c0a88df4c/experimental/soundwave/job_configs/v8.json

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78541fab128abfc0d4df6db7ffda03e186646b42

commit 78541fab128abfc0d4df6db7ffda03e186646b42
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 22 12:56:07 2018

Roll src/third_party/catapult 23153d4a809c..d7fce6c098ea (1 commits)

https://chromium.googlesource.com/catapult.git/+log/23153d4a809c..d7fce6c098ea


git log 23153d4a809c..d7fce6c098ea --date=short --no-merges --format='%ad %ae %s'
2018-10-22 perezju@chromium.org [pinpoint_cli] Allow multiple jobs per configuration


Created with:
  gclient setdep -r src/third_party/catapult@d7fce6c098ea

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:894773 
TBR=sullivan@chromium.org

Change-Id: Ic1724665b00c2fc45d7988bd3aadf6aa92d47b2c
Reviewed-on: https://chromium-review.googlesource.com/c/1293248
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601542}
[modify] https://crrev.com/78541fab128abfc0d4df6db7ffda03e186646b42/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b6835fc707c786722d2563f3570c139718dca3c0

commit b6835fc707c786722d2563f3570c139718dca3c0
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Oct 22 17:12:11 2018

[soundwave] Post process data for data studios

Do some post-processing on data obtained from soundwave for easier
consumption by datastudio dashboards.

Bug:  chromium:894773 
Change-Id: Iaa82ba5e749200f8a867987fbd7690f287106e90
Reviewed-on: https://chromium-review.googlesource.com/c/1293689
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/b6835fc707c786722d2563f3570c139718dca3c0/experimental/soundwave/soundwave/studies/__init__.py
[modify] https://crrev.com/b6835fc707c786722d2563f3570c139718dca3c0/experimental/soundwave/soundwave/commands.py

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2382a804000bab65606c559ede6465b09e357bc

commit d2382a804000bab65606c559ede6465b09e357bc
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 22 20:13:03 2018

Roll src/third_party/catapult 6ab9bc6fcb3d..623a134fbd08 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/6ab9bc6fcb3d..623a134fbd08


git log 6ab9bc6fcb3d..623a134fbd08 --date=short --no-merges --format='%ad %ae %s'
2018-10-22 benjhayden@chromium.org Reland Migrate trace_viewer.gypi to gni
2018-10-22 perezju@chromium.org [soundwave] Post process data for data studios


Created with:
  gclient setdep -r src/third_party/catapult@623a134fbd08

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:895699 , chromium:894773 
TBR=sullivan@chromium.org

Change-Id: I0eb0337711b8a2b45055d5b63e4b3fde7c9d3478
Reviewed-on: https://chromium-review.googlesource.com/c/1294220
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601703}
[modify] https://crrev.com/d2382a804000bab65606c559ede6465b09e357bc/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/38911d8ac8b22226b63f465e5bdb8cadebeed786

commit 38911d8ac8b22226b63f465e5bdb8cadebeed786
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Oct 25 10:43:14 2018

[soundwave] Add --upload-csv to automatically upload data for studies

With this option updating and uploading a fresh set of data for study
visialization can be done from a single soundwave command.

Data is uploaded relying on gsutil.

Bug:  chromium:894773 
Change-Id: I2bfc5e4640b5199f2e6c43fd9f5e0e6f706bdbb2
Reviewed-on: https://chromium-review.googlesource.com/c/1296550
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[add] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/tools/gsutil.py
[modify] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/soundwave/studies/__init__.py
[modify] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/soundwave/studies/v8_study.py
[modify] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/bin/soundwave
[modify] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/soundwave/commands.py
[modify] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/common/utils.py
[add] https://crrev.com/38911d8ac8b22226b63f465e5bdb8cadebeed786/experimental/soundwave/tools/__init__.py

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb3aa7b97465ef3772a16d21f28d54a32de2e741

commit cb3aa7b97465ef3772a16d21f28d54a32de2e741
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 25 14:33:28 2018

Roll src/third_party/catapult 11b2da785a81..38911d8ac8b2 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/11b2da785a81..38911d8ac8b2


git log 11b2da785a81..38911d8ac8b2 --date=short --no-merges --format='%ad %ae %s'
2018-10-25 perezju@chromium.org [soundwave] Add --upload-csv to automatically upload data for studies


Created with:
  gclient setdep -r src/third_party/catapult@38911d8ac8b2

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:894773 
TBR=sullivan@chromium.org

Change-Id: Ieb5ce9b8f9b9c290572251cb8ddcbcf486408ff5
Reviewed-on: https://chromium-review.googlesource.com/c/1298671
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602701}
[modify] https://crrev.com/cb3aa7b97465ef3772a16d21f28d54a32de2e741/DEPS

Blockedon: -868926 899671
Blockedon: -899671
Status: Fixed (was: Started)
I think this is basically done. Feel free to re-open or file new bugs if there are further requests. :)

Sign in to add a comment