Issue metadata
Sign in to add a comment
|
Regression : Profile picture Animation effect is seen missing in sign-out screen after adding third user |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.58/11021.45.0 beta-channel Kip,Reks & Daisy OS: Chrome Pre-condition : Sign into 2 users What steps will reproduce the problem? (1)In Sign out screen -> hover on two users and observe animation effect is seen -> Now add third person and sign out (2)In Sign out screen observe for 3 rd person animation effect is seen -> now click on any user available at R.H.S(from 2 users) (3)Now observe animation effect is seen missing and click again 3rd user -> observe animation effect of profile picture is seen missing (Please refer Video) Expected: Animation effect should be seen on clicking on any User in sign-out screen Actual: Instead animation effect of profile picture is seen missing This is Regression Issue as same is working fine on M-69 Note : Issue is also seen on M-71
,
Oct 12
,
Oct 12
Too late for m70, marking RBS m71
,
Oct 12
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/484a185167ad7b93dde4613e4d883fc7504c6787 commit 484a185167ad7b93dde4613e4d883fc7504c6787 Author: Jacob Dufault <jdufault@google.com> Date: Mon Oct 15 20:16:28 2018 cros: Fix animation not displaying when switching between users Only happens where there are 2+ users (ie, user list is used). OnImageDecoded is supposed to use the animation playback type that was set in SetAnimationEnabled. However, UpdateForUser calls SetImage which updates image_->playback() to kFirstFrameOnly. This means that OnImageDecoded cannot use image_->playback() as the playback type set by SetAnimationEnabled. Bug: 894771 Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43 Reviewed-on: https://chromium-review.googlesource.com/c/1277699 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599731} [modify] https://crrev.com/484a185167ad7b93dde4613e4d883fc7504c6787/ash/login/ui/animated_rounded_image_view.h [modify] https://crrev.com/484a185167ad7b93dde4613e4d883fc7504c6787/ash/login/ui/login_user_view.cc
,
Oct 16
,
Oct 17
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59f1e34123e71e7dcce5a556a02d6ccb4ae37caa commit 59f1e34123e71e7dcce5a556a02d6ccb4ae37caa Author: Jacob Dufault <jdufault@google.com> Date: Wed Oct 17 18:53:56 2018 cros: Fix animation not displaying when switching between users Only happens where there are 2+ users (ie, user list is used). OnImageDecoded is supposed to use the animation playback type that was set in SetAnimationEnabled. However, UpdateForUser calls SetImage which updates image_->playback() to kFirstFrameOnly. This means that OnImageDecoded cannot use image_->playback() as the playback type set by SetAnimationEnabled. TBR=jdufault@google.com (cherry picked from commit 484a185167ad7b93dde4613e4d883fc7504c6787) Bug: 894771 Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43 Reviewed-on: https://chromium-review.googlesource.com/c/1277699 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599731} Reviewed-on: https://chromium-review.googlesource.com/c/1287034 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#94} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/59f1e34123e71e7dcce5a556a02d6ccb4ae37caa/ash/login/ui/animated_rounded_image_view.h [modify] https://crrev.com/59f1e34123e71e7dcce5a556a02d6ccb4ae37caa/ash/login/ui/login_user_view.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59f1e34123e71e7dcce5a556a02d6ccb4ae37caa Commit: 59f1e34123e71e7dcce5a556a02d6ccb4ae37caa Author: jdufault@google.com Commiter: jdufault@chromium.org Date: 2018-10-17 18:53:56 +0000 UTC cros: Fix animation not displaying when switching between users Only happens where there are 2+ users (ie, user list is used). OnImageDecoded is supposed to use the animation playback type that was set in SetAnimationEnabled. However, UpdateForUser calls SetImage which updates image_->playback() to kFirstFrameOnly. This means that OnImageDecoded cannot use image_->playback() as the playback type set by SetAnimationEnabled. TBR=jdufault@google.com (cherry picked from commit 484a185167ad7b93dde4613e4d883fc7504c6787) Bug: 894771 Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43 Reviewed-on: https://chromium-review.googlesource.com/c/1277699 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599731} Reviewed-on: https://chromium-review.googlesource.com/c/1287034 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#94} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Oct 1219.0 MB
19.0 MB Download