tast.video.WebRTCCamera is failing on daisy |
||||||||||||
Issue descriptiontast.video.WebRTCCamera and tast.video.WebRTCCameraPerf are 100% failing on daisy: https://stainless.corp.google.com/search?view=matrix&row=model&col=build&first_date=2018-10-06&last_date=2018-10-12&test=tast.video.WebRTC&board=daisy&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false This would be a blocker for adding this test to Chrome OS CQ. Screenshots in logs show orange screens. e.g. screenshot.png under https://stainless.corp.google.com/browse/chromeos-autotest-results/247746575-chromeos-test/. Since tast.video.WebRTCPeerConnectionWithCamera* are passing, I guess there are some problems on specifying frame size (640x480 or 1280x720).
,
Oct 12
FWIW, I can see orange screen for graphics.Screenshot* tests. The tast.video.WebRTCCamera* ones seem to have empty, white tab.
,
Oct 12
#2: Oops. I saw graphics.Screenshot* ones by mistake. Thanks. They're not related and orange screen is good. And, white tabs in WebRTCCamera's screenshots are also okay.
,
Oct 12
I wonder if this is a hardware constraints or a test device is broken, but it seems that there are no daisy in our office.
,
Oct 12
Per https://support.google.com/chrome/a/answer/6220366?hl=en, the Samsung Chromebook XE303's AU support expired in July 2018. Are these builders going away soon?
,
Oct 12
no, daisy is not EOL, and won't be EOL this year. check out this doc: https://chromium.googlesource.com/chromiumos/docs/+/abd2c0de56588d608136a3d651c750949cf973d0/eol_aue_process.md i'd be a bit surprised if daisy fails but daisy-skate & daisy-spring passed ... iirc, they were pretty similar hardware, but maybe something wrt the camera was changed.
,
Oct 15
AFAIS, daisy-skate and daisy-spring are also always failing on same tests; WebRTCCamera and WebRTCCameraPerf. So, it seems a hardware-side limitation. derat@: If a daisy device is available in your office, could you please run tast.video.WebRTCCamera on it? Also, I'd like to make sure that daisy really doesn't support required frame sizes. WebRTCCamera requires 640x480 and 1280x720. You can get supported frame sizes by running the following command on DUT $ v4l2-ctl -d /dev/video0 --list-framesizes=<pixel format> , where "pixel format" is a string whose length is 4 (e.g. 'NV12', 'MJPG'), which can be obtained by: $ v4l2-ctl -d /dev/video0 --list-formats-ext --- If this is really a hardware limitation, how can we skip these tests on daisy-family? One possible idea is to extend autotest-capability, but I'm not sure this is the best way. To deal with this problem in this way, we need a more detailed capability than usb_camera. (maybe, something like usb_camera_1280_720?) But, it might be too much because all devices that have usb_camera also have the new capability except daisy family. Do you have any idea?
,
Oct 15
Oops. I mistakenly un-CC'd shik@. Sorry.
,
Oct 15
Sorry again.
,
Oct 15
Through the magic of our test lab, anybody on the team should be able to test this without having a daisy device in front of them. :-) (I don't have one either.) See http://cautotest/ . I don't know if there's any good documentation about how to find hosts. Checking chromeos2-row11-rack3-host4, it looks like 1280x720 is unsupported: localhost ~ # v4l2-ctl -d /dev/video0 --list-formats-ext ioctl: VIDIOC_ENUM_FMT Index : 0 Type : Video Capture Pixel Format: 'YUYV' Name : YUV 4:2:2 (YUYV) Size: Discrete 640x480 Interval: Discrete 0.033s (30.000 fps) Interval: Discrete 0.067s (15.000 fps) Size: Discrete 160x120 Interval: Discrete 0.033s (30.000 fps) Interval: Discrete 0.067s (15.000 fps) Size: Discrete 176x144 Interval: Discrete 0.033s (30.000 fps) Interval: Discrete 0.067s (15.000 fps) Size: Discrete 320x240 Interval: Discrete 0.033s (30.000 fps) Interval: Discrete 0.067s (15.000 fps) Size: Discrete 352x288 Interval: Discrete 0.033s (30.000 fps) Interval: Discrete 0.067s (15.000 fps) Size: Discrete 640x480 Interval: Discrete 0.033s (30.000 fps) Interval: Discrete 0.067s (15.000 fps) localhost ~ # v4l2-ctl -d /dev/video0 --list-framesizes=YUYV ioctl: VIDIOC_ENUM_FRAMESIZES Size: Discrete 640x480 Size: Discrete 160x120 Size: Discrete 176x144 Size: Discrete 320x240 Size: Discrete 352x288 Size: Discrete 640x480 If you can figure out what on daisy results in this resolution being unsupported (is it a particular chipset?), then you could add a USE flag for it (or just use the "daisy" USE flag or whatever if there's not a component that's responsible for it) and add a test dependency like "frame_size_1280" that could be used to skip running the test. If that doesn't work, then I can try to come up with something else.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eecc19aeeebe8fbc4fc9d1c92dd295dd678fc13f commit eecc19aeeebe8fbc4fc9d1c92dd295dd678fc13f Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Oct 17 12:55:06 2018 tast-use-flags: Add flags for daisy-variants boards to IUSE. The daisy-variants boards (daisy, daisy-skate, daisy-spring) has usb cameras that don't support 1280x720 frame size. Make tast-use-flags capture USE flags for these boards so that we can skip running tests requiring a camera supporting the frame size. BUG= chromium:894767 TEST=emerged tast-use-flags Change-Id: Iea481041825b1b8fc51b66194337f0c3007f6a6e Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1283489 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [rename] https://crrev.com/eecc19aeeebe8fbc4fc9d1c92dd295dd678fc13f/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r11.ebuild [modify] https://crrev.com/eecc19aeeebe8fbc4fc9d1c92dd295dd678fc13f/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/d0ea8d6f70628afc8a7ab7b161abe7fcc056c5d2 commit d0ea8d6f70628afc8a7ab7b161abe7fcc056c5d2 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Thu Oct 18 05:43:09 2018 tast-tests: Add camera_720p dependency in video.WebRTCCamera tests Add a dependency in video.WebRTCCamera tests to stop running these tests on devices whose cameras don't support 1280x720 frame size. (e.g. daisy) BUG= chromium:894767 TEST=cros tryjob -g 1283489 -g 1282785 -g 1282638 daisy-release-tryjob CQ-DEPEND=CL:1283489, CL:1282785 Change-Id: I6b2a32d770e7793429a714931260d426faf3d395 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1282638 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/d0ea8d6f70628afc8a7ab7b161abe7fcc056c5d2/src/chromiumos/tast/local/bundles/cros/video/webrtc_camera.go [modify] https://crrev.com/d0ea8d6f70628afc8a7ab7b161abe7fcc056c5d2/src/chromiumos/tast/local/bundles/cros/video/webrtc_camera_perf.go
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/c7acad0db1ba2d123856ca9ecb4e378819877829 commit c7acad0db1ba2d123856ca9ecb4e378819877829 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Thu Oct 18 05:43:09 2018 tast: Add "camera_720p" software dependency. Add a dependency "camera_720p" to exclude boards that have a webcam that doesn't support the frame size 1280x720. BUG= chromium:894767 TEST=cros tryjob -g 1283489 -g 1282785 -g 1282638 daisy-release-tryjob CQ-DEPEND=CL:1283489 Change-Id: Iff226f8d45f6a6590d066f66bd8519ad07a751f5 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1282785 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/c7acad0db1ba2d123856ca9ecb4e378819877829/src/chromiumos/cmd/local_test_runner/main.go [modify] https://crrev.com/c7acad0db1ba2d123856ca9ecb4e378819877829/docs/test_dependencies.md
,
Oct 19
tast.video.WebRTCCamera* tests stopped running on daisy from R72-11170.0.0. https://stainless.corp.google.com/search?view=matrix&row=model&col=build&first_date=2018-10-13&last_date=2018-10-19&test=tast.video.WebRTC&board=daisy&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false
,
Oct 22
We want to cherry-pick the following 3 CLs to R71-branch: - crrev.com/c/1283489 - crrev.com/c/1282785 - crrev.com/c/1282638
,
Oct 22
Issue 897618 has been merged into this issue.
,
Oct 22
Issue 897618 has been merged into this issue.
,
Oct 22
I created 3 CLs for cherry-pick to R71. - crrev.com/c/1293252 - crrev.com/c/1292702 - crrev.com/c/1293390 Cherry-picking is needed for the following failures: https://stainless.corp.google.com/search?view=matrix&row=model&col=build&first_date=2018-10-20&last_date=2018-10-22&test=tast.video.WebRTC&build=R71&board=daisy&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false
,
Oct 23
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/437d6f93b227a020c1fe09c7f01bb532164909ff commit 437d6f93b227a020c1fe09c7f01bb532164909ff Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Oct 24 06:27:49 2018 tast-use-flags: Add flags for daisy-variants boards to IUSE. The daisy-variants boards (daisy, daisy-skate, daisy-spring) has usb cameras that don't support 1280x720 frame size. Make tast-use-flags capture USE flags for these boards so that we can skip running tests requiring a camera supporting the frame size. BUG= chromium:894767 TEST=emerged tast-use-flags Change-Id: Iea481041825b1b8fc51b66194337f0c3007f6a6e Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1283489 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> (cherry picked from commit eecc19aeeebe8fbc4fc9d1c92dd295dd678fc13f) Reviewed-on: https://chromium-review.googlesource.com/c/1293252 [rename] https://crrev.com/437d6f93b227a020c1fe09c7f01bb532164909ff/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r11.ebuild [modify] https://crrev.com/437d6f93b227a020c1fe09c7f01bb532164909ff/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/c4224ad2a57c42a6e34843684e30a201899564ca commit c4224ad2a57c42a6e34843684e30a201899564ca Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Oct 24 06:27:51 2018 tast: Add "camera_720p" software dependency. Add a dependency "camera_720p" to exclude boards that have a webcam that doesn't support the frame size 1280x720. BUG= chromium:894767 TEST=cros tryjob -g 1283489 -g 1282785 -g 1282638 daisy-release-tryjob CQ-DEPEND=CL:1293252 Change-Id: Iff226f8d45f6a6590d066f66bd8519ad07a751f5 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1282785 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Shuhei Takahashi <nya@chromium.org> (cherry picked from commit c7acad0db1ba2d123856ca9ecb4e378819877829) Reviewed-on: https://chromium-review.googlesource.com/c/1292702 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/c4224ad2a57c42a6e34843684e30a201899564ca/src/chromiumos/cmd/local_test_runner/main.go [modify] https://crrev.com/c4224ad2a57c42a6e34843684e30a201899564ca/docs/test_dependencies.md
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/62cc36e3890ec8f2f92cc2a2c3b7228aca22bd9a commit 62cc36e3890ec8f2f92cc2a2c3b7228aca22bd9a Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Oct 24 06:27:52 2018 tast-tests: Add camera_720p dependency in video.WebRTCCamera tests Add a dependency in video.WebRTCCamera tests to stop running these tests on devices whose cameras don't support 1280x720 frame size. (e.g. daisy) BUG= chromium:894767 TEST=cros tryjob -g 1283489 -g 1282785 -g 1282638 daisy-release-tryjob CQ-DEPEND=CL:1293252, CL:1292702 Change-Id: I6b2a32d770e7793429a714931260d426faf3d395 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1282638 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Dan Erat <derat@chromium.org> (cherry picked from commit d0ea8d6f70628afc8a7ab7b161abe7fcc056c5d2) Reviewed-on: https://chromium-review.googlesource.com/c/1293390 Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/62cc36e3890ec8f2f92cc2a2c3b7228aca22bd9a/src/chromiumos/tast/local/bundles/cros/video/webrtc_camera.go [modify] https://crrev.com/62cc36e3890ec8f2f92cc2a2c3b7228aca22bd9a/src/chromiumos/tast/local/bundles/cros/video/webrtc_camera_perf.go
,
Oct 24
,
Oct 26
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 Deleted