Registrations are wiped on the browser shutdown. |
||||||
Issue description[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering. * The service shouldn't unregister from the topics, when handler the Handler is unregistering from topic (as stated in the documentation for for UnregisterHandler). * Sync shouldn't unregister on browser shutdown
,
Oct 13
,
Oct 14
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 15
Pls merge your change to M71 branch #3578 ASAP so we can pick it up for next M71 dev release. Thank you.
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6a554f2bb17f3d9588514c937c0275caadfc45 commit 8f6a554f2bb17f3d9588514c937c0275caadfc45 Author: Tanja Gornak <melandory@chromium.org> Date: Mon Oct 15 07:50:38 2018 [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering. * The service shouldn't unregister from the topics, when handler the Handler is unregistering from topic (as stated in the documentation for for UnregisterHandler). * Sync shouldn't unregister on browser shutdown TBR=gab@chromium.org, melandory@chromium.org, pavely@chromium.org (cherry picked from commit 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13) Bug: 894752 , 801985 Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76 Reviewed-on: https://chromium-review.googlesource.com/c/1277908 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599206} Reviewed-on: https://chromium-review.googlesource.com/c/1280202 Cr-Commit-Position: refs/branch-heads/3578@{#17} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/8f6a554f2bb17f3d9588514c937c0275caadfc45/components/invalidation/public/invalidation_util.h
,
Oct 15
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6a554f2bb17f3d9588514c937c0275caadfc45 Commit: 8f6a554f2bb17f3d9588514c937c0275caadfc45 Author: melandory@chromium.org Commiter: melandory@chromium.org Date: 2018-10-15 07:50:38 +0000 UTC [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering. * The service shouldn't unregister from the topics, when handler the Handler is unregistering from topic (as stated in the documentation for for UnregisterHandler). * Sync shouldn't unregister on browser shutdown TBR=gab@chromium.org, melandory@chromium.org, pavely@chromium.org (cherry picked from commit 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13) Bug: 894752 , 801985 Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76 Reviewed-on: https://chromium-review.googlesource.com/c/1277908 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599206} Reviewed-on: https://chromium-review.googlesource.com/c/1280202 Cr-Commit-Position: refs/branch-heads/3578@{#17} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 12