New issue
Advanced search Search tips

Issue 894752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 15
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Registrations are wiped on the browser shutdown.

Project Member Reported by melandory@chromium.org, Oct 12

Issue description

[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13

commit 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13
Author: Tanja Gornak <melandory@chromium.org>
Date: Fri Oct 12 14:39:54 2018

[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

TBR=gab@chromium.org, pavely@chromium.org

Bug:  894752 , 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599206}
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/BUILD.gn
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/fcm_fake_invalidator.cc
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/fcm_invalidation_listener.cc
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/fcm_invalidation_listener.h
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/fcm_invalidation_service.cc
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/fcm_invalidation_service.h
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/fcm_invalidation_service_unittest.cc
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/invalidator_registrar.cc
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/invalidator_registrar.h
[add] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/invalidator_registrar_with_memory.cc
[add] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/impl/invalidator_registrar_with_memory.h
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/invalidation/public/invalidation_util.h
[modify] https://crrev.com/5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13/components/sync/driver/glue/sync_backend_host_impl.cc

Labels: Merge-Request-71
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 14

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M71 branch #3578 ASAP so we can pick it up for next M71 dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 15

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f6a554f2bb17f3d9588514c937c0275caadfc45

commit 8f6a554f2bb17f3d9588514c937c0275caadfc45
Author: Tanja Gornak <melandory@chromium.org>
Date: Mon Oct 15 07:50:38 2018

[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

TBR=gab@chromium.org, melandory@chromium.org, pavely@chromium.org

(cherry picked from commit 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13)

Bug:  894752 , 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599206}
Reviewed-on: https://chromium-review.googlesource.com/c/1280202
Cr-Commit-Position: refs/branch-heads/3578@{#17}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/8f6a554f2bb17f3d9588514c937c0275caadfc45/components/invalidation/public/invalidation_util.h

Status: Fixed (was: Assigned)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/8f6a554f2bb17f3d9588514c937c0275caadfc45

Commit: 8f6a554f2bb17f3d9588514c937c0275caadfc45
Author: melandory@chromium.org
Commiter: melandory@chromium.org
Date: 2018-10-15 07:50:38 +0000 UTC

[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

TBR=gab@chromium.org, melandory@chromium.org, pavely@chromium.org

(cherry picked from commit 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13)

Bug:  894752 , 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599206}
Reviewed-on: https://chromium-review.googlesource.com/c/1280202
Cr-Commit-Position: refs/branch-heads/3578@{#17}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment