Lack of orderfile on arm64 prevents memory optimizations |
|||
Issue descriptionTurning on --orderfile-memory-optimization causes a check failure on arm64 as there is no orderfile, eg telemetry_perf_unittests on Android device Nexus 5X arm64: [1011/202929.739110:FATAL:library_prefetcher.cc(323)] Check failed: IsOrderingSane().
,
Oct 12
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea3132cbbc836b398e523438627cc27349505196 commit ea3132cbbc836b398e523438627cc27349505196 Author: Matthew Cary <mattcary@chromium.org> Date: Fri Oct 12 14:19:58 2018 Orderfile: skip madvise if ordering has not been done. Change a CHECK to an logged warning if madvise is attempted when code ordering has not been performed. This happens on upstream builds including arm64 builds. Bug: 894748 Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a Reviewed-on: https://chromium-review.googlesource.com/c/1278746 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Matthew Cary <mattcary@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#599201} [modify] https://crrev.com/ea3132cbbc836b398e523438627cc27349505196/base/android/library_loader/library_prefetcher.cc
,
Oct 12
,
Oct 12
For posterity: the title is a bit miseleading, ordering is enabled on ARM64, but only for official downstream builds, causing failures upstream. In addition, Nexus 5X actually run the ARM32 variant of chrome.
,
Oct 12
That was the original failing bot. Why there's a build labeled arm64 nexus5 is beyond me...
,
Oct 12
s/nexus5/nexus5x/ - it's a 64bit device ... |
|||
►
Sign in to add a comment |
|||
Comment 1 by mattcary@chromium.org
, Oct 12