script/cros_vm: move all VM logic into lib.vm |
|||
Issue descriptionwe have chromite.lib.vm and chromite.scripts.cros_vm which duplicate a lot of VM management logic. probably all of the VM logic should be ripped out of cros_vm and kept in lib.vm so we can drop all the cros_start_vm usage which is deprecated.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e3d5e57065d4fbfe8dde9a6c9e50cdc6ed9ca58b commit e3d5e57065d4fbfe8dde9a6c9e50cdc6ed9ca58b Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Nov 21 13:52:57 2018 cros_vm: Move Device/VM to lib/vm.py No code change in the block of code moved from scripts/cros_vm.py to lib/vm.py Device will go into a separate lib in a follow-up CL. BUG= chromium:894730 TEST=cros_vm --start; cros_run_vm_test Change-Id: I5b42135afd7553e1051f7d3400b74d5951a835b2 Reviewed-on: https://chromium-review.googlesource.com/1341450 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/e3d5e57065d4fbfe8dde9a6c9e50cdc6ed9ca58b/lib/vm.py [modify] https://crrev.com/e3d5e57065d4fbfe8dde9a6c9e50cdc6ed9ca58b/scripts/cros_run_vm_test.py [modify] https://crrev.com/e3d5e57065d4fbfe8dde9a6c9e50cdc6ed9ca58b/scripts/cros_vm.py
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ee331b1db422ade30d4a70c311e3cdeba35df5ec commit ee331b1db422ade30d4a70c311e3cdeba35df5ec Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Nov 30 03:31:15 2018 cros_run_vm_test: Move to lib/cros_test.py * Move code to lib/cros_test.py * Create CLI stub cros_test.py * Soft link cros_run_vm_test.py to cros_test.py * Soft link bin/cros_test BUG= chromium:894730 TEST=cros_run_vm_test; cros_run_test Change-Id: Ifacff727697390e6af5a1590bd9c1ed44dce3200 Reviewed-on: https://chromium-review.googlesource.com/1345533 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [add] https://crrev.com/ee331b1db422ade30d4a70c311e3cdeba35df5ec/scripts/cros_run_test.py [add] https://crrev.com/ee331b1db422ade30d4a70c311e3cdeba35df5ec/scripts/cros_run_vm_test.py [add] https://crrev.com/ee331b1db422ade30d4a70c311e3cdeba35df5ec/bin/cros_run_test [rename] https://crrev.com/ee331b1db422ade30d4a70c311e3cdeba35df5ec/lib/cros_test.py
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ac9b0ff799ae22093fe578a769e6767c3c1bd358 commit ac9b0ff799ae22093fe578a769e6767c3c1bd358 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Sat Dec 01 09:08:42 2018 device: Move Device to separate lib. BUG= chromium:894730 TEST=cros_run_vm_test Change-Id: I9ce0e877f38b8736ecc0b7871aa122eeced9fe2b Reviewed-on: https://chromium-review.googlesource.com/1354386 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [add] https://crrev.com/ac9b0ff799ae22093fe578a769e6767c3c1bd358/lib/device.py [modify] https://crrev.com/ac9b0ff799ae22093fe578a769e6767c3c1bd358/lib/vm.py [modify] https://crrev.com/ac9b0ff799ae22093fe578a769e6767c3c1bd358/lib/cros_test.py
,
Jan 8
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/08ce937c630e19d23d08b87e1278844aa101d8aa commit 08ce937c630e19d23d08b87e1278844aa101d8aa Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Jan 09 19:55:37 2019 vm: Delete VMInstance. BUG= chromium:894730 TEST=bots Change-Id: I2ec3a0cbbb91dde0ee3b08e7b96ae3f22a97e2dc Reviewed-on: https://chromium-review.googlesource.com/1399824 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org> [modify] https://crrev.com/08ce937c630e19d23d08b87e1278844aa101d8aa/lib/vm.py
,
Jan 15
|
|||
►
Sign in to add a comment |
|||
Comment 1 by achuith@chromium.org
, Nov 17Owner: achuith@chromium.org
Status: Started (was: Available)