New issue
Advanced search Search tips

Issue 894717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'FPS meter' is seen misplaced after resizing dev tools window.

Reported by db...@etouch.net, Oct 12

Issue description

Chrome Version: 71.0.3577.0 Revision fc334a55a70eec12fc77853c53979f81e8496c21-refs/branch-heads/3577@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6)

What steps will reproduce the problem?
(1) Launch chrome, open NTP nbd open dev tools window on it.
(2) Press 'Esc' key (such that drawer opens) and click on 'more option' menu(i.e Three dots) to open 'Rendering' tab.
(3) Select 'FPS meter' and resize dev tools window, observe 'FPS meter'.

Actual: 'FPS meter' is seen misplaced after resizing dev tools window.

Expected: 'FPS meter' should not seen misplaced even after resizing dev tools window.

This is a regression issue, broken in 'M71', below is bisect info:

Good Build:71.0.3542.0(Revision: 589076)
Bad Build:71.0.3544.0(Revision: 588440)

You are probably looking for a change made after 588575 (known good), but no lat
er than 588583 (first known bad).
CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/fff19ae55cbbb705cd7cdf810affbdf9c3aea4b6..0b9fcfe9befdf310f87c1ba2116b0a16a36f0645

Suspect: https://chromium.googlesource.com/chromium/src/+/e9f51e1afe36de7be3affa78fbbf2ecb948b1bda

skobes@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting error "RuntimeError: We don't have enough builds to bisect"

Kindly refer attached screen cast.

Thank You..!!

 
Actual_Window.mp4
2.2 MB View Download
Expected_Window.mp4
1.3 MB View Download
I am able to reproduce this in 71.0.3577.0 (Official Build) canary (64-bit) (cohort: Clang-64), but not in 69.0.3497.100 (Official Build) (64-bit) (cohort: Stable). 
Notice how the frame rate dialog jumps around seemingly randomly every time the page is rendered. 
2018-10-12_10-22-58.mp4
6.2 MB View Download
With respect to comment1:

Issue is reproduce on build #71.0.3577.0 and also on #71.0.3578.0, but issue is not seen on Stable build #69.0.3497.100

Thank you.
Actual_issue.mp4
1.3 MB View Download
Owner: pdr@chromium.org
This is not r588579, but it might be r588577.  pdr can you take a look?
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6

commit 1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Oct 12 17:55:13 2018

Fix HUD location and size when displaying the FPS meter

The author of https://crrev.com/588577 did not realize the HUD layer
could be used for non-full-viewport rect debug information such as the
FPS meter. This patch restores the non-rect size logic from
https://crrev.com/588577 and adds a test of the FPS meter size.

Bug:  894717 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ied6d6c80e396ab59dbc201994db5214ed1db09a0
Reviewed-on: https://chromium-review.googlesource.com/c/1277658
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599282}
[modify] https://crrev.com/1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6/cc/layers/heads_up_display_layer.cc
[modify] https://crrev.com/1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6/cc/layers/heads_up_display_layer.h
[modify] https://crrev.com/1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6/cc/layers/heads_up_display_unittest.cc
[modify] https://crrev.com/1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/1e1bdbbd406db941c6a0ff4c99271d7d1a9e89f6/cc/trees/layer_tree_host.h

Status: Fixed (was: Started)
This is a fairly-obscure debug feature so I do not think we need to merge this fix.
Labels: -Type-Bug Type-Bug-Regression

Sign in to add a comment