A notification "OS update successful. You can now use Android apps." is shown unexpectedly. |
|||||||
Issue descriptionThis issue a crbug counterpart of b/112553954. We got many reports that "OS update successful. You can now use Android apps." is notified even though the update was done several milestones ago and the user have been using Android apps. Somehow we show the notification at a wrong timing. The simplest fix is to remove the notification. Most users have already migrated to ext4 crypto, so the notification should be less useful now.
,
Oct 17
,
Oct 17
This bug requires manual review: There is .grd file changes and we are only 47 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
Has the change been verified as fixing the issue?
,
Oct 18
Yes, I verified that it was fixed on Kevin using the same version of today's Canary(11167.0.0).
,
Oct 18
Approving merge to M71 Chrome OS.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d647c0673d3ccffb07e28b4965bb273f6f63ae1 commit 7d647c0673d3ccffb07e28b4965bb273f6f63ae1 Author: Naoki Fukino <fukino@chromium.org> Date: Fri Oct 19 02:17:11 2018 Remove "OS update successful." notification. We have been showing the notification after successful ext4 migration. This notification is getting less useful since most users have already migrated to ext4, and we hear several feedback reports that the notification was shown at unexpected timing. Let's remove the notification as a simple fix and a clean-up. (Removing the notification was approved by PM.) Bug: 894707 Test: Manually confirmed that the notification was not shown after migration on Kevin. Change-Id: Ide3237a57a127974eed6f1619fc5e096f911f72a Reviewed-on: https://chromium-review.googlesource.com/c/1278666 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599568}(cherry picked from commit b671af6d8b890524426dbed9609f694c8a6f16c8) Reviewed-on: https://chromium-review.googlesource.com/c/1290050 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#146} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/7d647c0673d3ccffb07e28b4965bb273f6f63ae1/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/7d647c0673d3ccffb07e28b4965bb273f6f63ae1/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc [modify] https://crrev.com/7d647c0673d3ccffb07e28b4965bb273f6f63ae1/chrome/browser/chromeos/arc/arc_migration_guide_notification.h [modify] https://crrev.com/7d647c0673d3ccffb07e28b4965bb273f6f63ae1/chrome/browser/chromeos/arc/arc_util.h [modify] https://crrev.com/7d647c0673d3ccffb07e28b4965bb273f6f63ae1/chrome/browser/chromeos/arc/arc_util_unittest.cc [modify] https://crrev.com/7d647c0673d3ccffb07e28b4965bb273f6f63ae1/chrome/browser/chromeos/login/session/user_session_manager.cc
,
Oct 19
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d647c0673d3ccffb07e28b4965bb273f6f63ae1 Commit: 7d647c0673d3ccffb07e28b4965bb273f6f63ae1 Author: fukino@chromium.org Commiter: fukino@chromium.org Date: 2018-10-19 02:17:11 +0000 UTC Remove "OS update successful." notification. We have been showing the notification after successful ext4 migration. This notification is getting less useful since most users have already migrated to ext4, and we hear several feedback reports that the notification was shown at unexpected timing. Let's remove the notification as a simple fix and a clean-up. (Removing the notification was approved by PM.) Bug: 894707 Test: Manually confirmed that the notification was not shown after migration on Kevin. Change-Id: Ide3237a57a127974eed6f1619fc5e096f911f72a Reviewed-on: https://chromium-review.googlesource.com/c/1278666 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599568}(cherry picked from commit b671af6d8b890524426dbed9609f694c8a6f16c8) Reviewed-on: https://chromium-review.googlesource.com/c/1290050 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#146} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 15