Issue metadata
Sign in to add a comment
|
BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF is flaky |
||||||||||||||||||||||
Issue descriptionFlaky test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=407f0dd9c37dce10 Test output log: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I064944f125bebcb746f329af4cfb117f3be94ff0 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5NTE2L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1FuSnZkM05sY2xOcFpHVkdiR2x1WjBKeWIzZHpaWEpVWlhOMExsUnZkV05vYzJOeVpXVnVSbXhwYm1kQ2RXSmliR1Z6Um5KdmJVOVBVRWxHDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5NTE2L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1FuSnZkM05sY2xOcFpHVkdiR2x1WjBKeWIzZHpaWEpVWlhOMExsUnZkV05vYzJOeVpXVnVSbXhwYm1kQ2RXSmliR1Z6Um5KdmJVOVBVRWxHDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
,
Oct 12
Removing the label as change was reverted.
,
Oct 12
Assigning to author of reverted CL.
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e82d7b7509c3b9297efff38ec22a39cc91b1eee commit 1e82d7b7509c3b9297efff38ec22a39cc91b1eee Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Mon Oct 15 14:54:46 2018 Revert "Fling bubbles from OOPIF properly." This reverts commit a12ef847a57f4aa0282ca47b555c04da18b00f9e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516 Sample Failed Step: content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Fling bubbles from OOPIF properly. > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > of both the oopif and the bubbling target. The fling controller of the oopif > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > immediately before getting sent to the renderer since we are in bubbling mode. > Then the oopif's fling controller receives the unconsumed GSU ack and generates > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > fling controller receives and processes the GFS and generates GSUs which are > sent to the target's renderer. > > If the GSE generated by the oopif's fling controller gets bubbled before > the GFS, the bubbling target gets reset and the target does not receive the > GFS. This cl fixes the issue by making sure that the events generated by the > oopif's fling controller are not bubbled to the target. Also in case of > GFS bubbling, the GFC should also get sent to the bubbling target to make > sure that the fling controller in charge of flinging receives the GFC. > > > Bug: 884728 , 249063 > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599001} Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884728 , 249063 , 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1278536 Cr-Original-Commit-Position: refs/heads/master@{#599094}(cherry picked from commit bb03212f2a4bd93f4f87da036a5f9eaeb2256466) Reviewed-on: https://chromium-review.googlesource.com/c/1280621 Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#21} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/1e82d7b7509c3b9297efff38ec22a39cc91b1eee/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/1e82d7b7509c3b9297efff38ec22a39cc91b1eee/content/browser/renderer_host/input/fling_browsertest.cc [modify] https://crrev.com/1e82d7b7509c3b9297efff38ec22a39cc91b1eee/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/1e82d7b7509c3b9297efff38ec22a39cc91b1eee/content/browser/renderer_host/render_widget_host_input_event_router.h [modify] https://crrev.com/1e82d7b7509c3b9297efff38ec22a39cc91b1eee/content/browser/renderer_host/render_widget_host_view_child_frame.cc
,
Oct 16
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f24f12ddac76fded4bbbd2b4631952b9acd29cc1 commit f24f12ddac76fded4bbbd2b4631952b9acd29cc1 Author: Sahel Sharify <sahel@chromium.org> Date: Wed Oct 17 19:11:54 2018 Added Fling Bubbling browsertests. The tests were initially landed in the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1278963 The logic of the cl is re-landed in a separate cl(r599781) to give it more time to bake. This cl re-lands the browser tests after applying the following changes: 1- Addressed renaming nit. 2- Used MainThreadFrameObserver to make sure that compositor is synced after scrolling on main thread. Bug: 894703 Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 Reviewed-on: https://chromium-review.googlesource.com/c/1286875 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600509} [modify] https://crrev.com/f24f12ddac76fded4bbbd2b4631952b9acd29cc1/content/browser/renderer_host/input/fling_browsertest.cc
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92e39c00aaf6766776089f84f4aced87f93c0a9c commit 92e39c00aaf6766776089f84f4aced87f93c0a9c Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Oct 18 01:04:57 2018 Revert "Added Fling Bubbling browsertests." This reverts commit f24f12ddac76fded4bbbd2b4631952b9acd29cc1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600509 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjI0ZjEyZGRhYzc2ZmRlZDRiYmJkMmI0NjMxOTUyYjlhY2QyOWNjMQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14827 Sample Failed Step: viz_content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Added Fling Bubbling browsertests. > > The tests were initially landed in the following cl: > https://chromium-review.googlesource.com/c/chromium/src/+/1278963 > > The logic of the cl is re-landed in a separate cl(r599781) to give it > more time to bake. This cl re-lands the browser tests after applying > the following changes: > > 1- Addressed renaming nit. > 2- Used MainThreadFrameObserver to make sure that compositor is synced > after scrolling on main thread. > > Bug: 894703 > Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 > Reviewed-on: https://chromium-review.googlesource.com/c/1286875 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600509} Change-Id: Ie617c2ccc9b0048d24804ab59cdb5753f99a3e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894703 , 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1287077 Cr-Commit-Position: refs/heads/master@{#600627} [modify] https://crrev.com/92e39c00aaf6766776089f84f4aced87f93c0a9c/content/browser/renderer_host/input/fling_browsertest.cc
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/437b8ad49dc7b0b959794c7ef309ae3447e5018e commit 437b8ad49dc7b0b959794c7ef309ae3447e5018e Author: Sahel Sharify <sahel@chromium.org> Date: Thu Oct 18 22:05:31 2018 Reland "Added Fling Bubbling browsertests." This is a reland of f24f12ddac76fded4bbbd2b4631952b9acd29cc1 This cl is using RenderFrameDeletedObserver to avoid crbug.com/889002 which is the cause of the crashes in flakiness dashboard: https://chromium-swarm.appspot.com/task?id=409ddad025e7a610&refresh=10&show_raw=1 Original change's description: > Added Fling Bubbling browsertests. > > The tests were initially landed in the following cl: > https://chromium-review.googlesource.com/c/chromium/src/+/1278963 > > The logic of the cl is re-landed in a separate cl(r599781) to give it > more time to bake. This cl re-lands the browser tests after applying > the following changes: > > 1- Addressed renaming nit. > 2- Used MainThreadFrameObserver to make sure that compositor is synced > after scrolling on main thread. > > Bug: 894703 > Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 > Reviewed-on: https://chromium-review.googlesource.com/c/1286875 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600509} Bug: 894703 Change-Id: I07b802b807c93beb684378e2fe18357fabf3ecbe Reviewed-on: https://chromium-review.googlesource.com/c/1289515 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600931} [modify] https://crrev.com/437b8ad49dc7b0b959794c7ef309ae3447e5018e/content/browser/renderer_host/input/fling_browsertest.cc
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a82328cdea795ad7225c1fc6c7665bd2d571edc3 commit a82328cdea795ad7225c1fc6c7665bd2d571edc3 Author: Sahel Sharify <sahel@chromium.org> Date: Fri Oct 19 19:32:45 2018 Enable touchpad fling bubbling test. This cl enables BrowserSideFlingBrowserTest.TouchpadFlingBubblesFromOOPIF to see if it still flakes or not. I expect the test to be stable after the changes that landed in https://chromium-review.googlesource.com/c/chromium/src/+/1289515 TBR=creis@chromium.org Bug: 894703 Change-Id: I17164061e0d41886eb73537936cac94e61a91011 Reviewed-on: https://chromium-review.googlesource.com/c/1291811 Reviewed-by: Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601256} [modify] https://crrev.com/a82328cdea795ad7225c1fc6c7665bd2d571edc3/content/browser/renderer_host/input/fling_browsertest.cc
,
Oct 22
The tests are stable now.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e82d7b7509c3b9297efff38ec22a39cc91b1eee Commit: 1e82d7b7509c3b9297efff38ec22a39cc91b1eee Author: findit-for-me@appspot.gserviceaccount.com Commiter: sahel@chromium.org Date: 2018-10-15 14:54:46 +0000 UTC Revert "Fling bubbles from OOPIF properly." This reverts commit a12ef847a57f4aa0282ca47b555c04da18b00f9e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516 Sample Failed Step: content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Fling bubbles from OOPIF properly. > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > of both the oopif and the bubbling target. The fling controller of the oopif > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > immediately before getting sent to the renderer since we are in bubbling mode. > Then the oopif's fling controller receives the unconsumed GSU ack and generates > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > fling controller receives and processes the GFS and generates GSUs which are > sent to the target's renderer. > > If the GSE generated by the oopif's fling controller gets bubbled before > the GFS, the bubbling target gets reset and the target does not receive the > GFS. This cl fixes the issue by making sure that the events generated by the > oopif's fling controller are not bubbled to the target. Also in case of > GFS bubbling, the GFC should also get sent to the bubbling target to make > sure that the fling controller in charge of flinging receives the GFC. > > > Bug: 884728 , 249063 > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599001} Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884728 , 249063 , 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1278536 Cr-Original-Commit-Position: refs/heads/master@{#599094}(cherry picked from commit bb03212f2a4bd93f4f87da036a5f9eaeb2256466) Reviewed-on: https://chromium-review.googlesource.com/c/1280621 Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#21} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 12