New issue
Advanced search Search tips

Issue 894682 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 678905



Sign in to add a comment

Implement ServiceWorkerContainer.startMessages()

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Oct 12

Issue description

WPT import https://crrev.com/c/1278142 introduced new failures in external/wpt/service-workers:

List of new failures:
virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/postmessage-to-client.https.html [ Timeout ]
external/wpt/service-workers/service-worker/postmessage-to-client.https.html [ Timeout ]
virtual/outofblink-cors/external/wpt/service-workers/service-worker/postmessage-to-client.https.html [ Timeout ]
virtual/service-worker-servicification/external/wpt/service-workers/service-worker/postmessage-to-client.https.html [ Timeout ]

This import contains upstream changes from e048b62ee65e141c8e5a1e621fae41f1e7dd0a37 to 639d29d0f4f7932109ce83039d3d057f4cac75b0:
Implement ServiceWorkerContainer.startMessages(): https://github.com/web-platform-tests/wpt/commit/639d29d0f4f7932109ce83039d3d057f4cac75b0 [affecting this directory]
Fix flakiness in resource_timing_buffer_full_250: https://github.com/web-platform-tests/wpt/commit/ed3b742cd294a5d39d40bc4f8271e9ebe864245f
Clean Picture-in-Picture Web Platform Tests: https://github.com/web-platform-tests/wpt/commit/b05cafed9d8fd0db62d9ba0ccff75f1c782fbe92
[Background Fetch] Add WPT tests for BackgroundFetchRegistration::abort: https://github.com/web-platform-tests/wpt/commit/c54a084daf22377e9c9ac3b50f9220ad0df27858
[css-properties-values-api] Avoid viewport dependent tests.: https://github.com/web-platform-tests/wpt/commit/674e8801c0e11fbd489fb065785b2717d6220a9b
[Background Fetch] Notify observers of BackgroundFetchRegistration: https://github.com/web-platform-tests/wpt/commit/2ada2e794af8672b3988f8b9f085301207e5f78d
Make DTMF tone change more deterministic: https://github.com/web-platform-tests/wpt/commit/a67acb73fa2f29bb85ba29c428587dd12b8940bc
Python 3: Support checking for multiple headers (#13453): https://github.com/web-platform-tests/wpt/commit/b91e0cd905d8e5db777586e239079c801533440a

 
Blocking: 678905
Labels: Pri-3 Type-Feature
Status: Available (was: Untriaged)
Summary: Implement ServiceWorkerContainer.startMessages() (was: [WPT] New failures introduced in external/wpt/service-workers by import https://crrev.com/c/1278142)
Chrome fails the WPT postmessage-to-client.https.html because it doesn't implement ServiceWorkerContainer.startMessages().

- Spec issue: https://github.com/w3c/ServiceWorker/issues/728
- Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1263734
- WPT commit: https://github.com/web-platform-tests/wpt/commit/639d29d0f4f7932109ce83039d3d057f4cac75b0
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7a3092d2bda780efb519237883db312fae06a42

commit f7a3092d2bda780efb519237883db312fae06a42
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Oct 30 08:34:29 2018

ServiceWorker: Move WPTs for ServiceWorkerContainer.startMessages() into its own file

This CL moves tests for ServiceWorkerContainer.startMessages() and message
queues from postmessage-to-client.https.html to
postmessage-to-client-message-queue.https.html. This doesn't change test
behavior.

The motivations of this change are as follows:

- Tests for startMessages() are timing out on all web browsers[1]. This hides
  the results of typical tests for WindowClient.postMessage(), and makes it
  difficult to add new tests for WorkerClient.postMessage().
- Test formats are totally different among them. This makes it difficult to read
  test scripts.

[1] https://wpt.fyi/results/service-workers/service-worker/postmessage-to-client.https.html?aligned&label=stable

Bug: 894682
Change-Id: Ia66af523ccff4529f85aac23df5059be099290a2
Reviewed-on: https://chromium-review.googlesource.com/c/1307025
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603837}
[modify] https://crrev.com/f7a3092d2bda780efb519237883db312fae06a42/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/f7a3092d2bda780efb519237883db312fae06a42/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-to-client-message-queue.https.html
[modify] https://crrev.com/f7a3092d2bda780efb519237883db312fae06a42/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-to-client.https.html

Labels: -Pri-3 Target-73 Pri-1

Sign in to add a comment