New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894665 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Rename ConciergeClientResult to CrostiniResult

Project Member Reported by rjwright@chromium.org, Oct 12

Issue description

This type is no longer only being used for results from Concierge so it needs a more appropriate name
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed

commit f09c5b78a4ce3f7afde8c520ea17cd8c94135aed
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Oct 15 03:08:23 2018

Rename ConciergeClientResult to CrostiniResult

Bug:  894665 
Change-Id: Ie894955b7f5095c19135385437392d8c12dc3223
Reviewed-on: https://chromium-review.googlesource.com/c/1278428
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599558}
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_package_installer_service.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_package_installer_service.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_registry_service.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_registry_service.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_remover.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_remover.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/crostini/crostini_util.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/views/crostini/crostini_installer_view.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/views/crostini/crostini_installer_view.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/views/crostini/crostini_uninstaller_view.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/views/crostini/crostini_uninstaller_view.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/views/crostini/crostini_upgrade_view.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/webui/settings/chromeos/crostini_handler.h
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/f09c5b78a4ce3f7afde8c520ea17cd8c94135aed/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.h

Status: Fixed (was: Started)

Sign in to add a comment