New issue
Advanced search Search tips

Issue 894663 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Select-to-Speak shouldn't read its own icon in the tray

Project Member Reported by katie@chromium.org, Oct 12

Issue description

This is a regression perhaps starting with the new system UI?
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/487bfbd808ca64cdaf1dd04e62e4cc6da1fc404b

commit 487bfbd808ca64cdaf1dd04e62e4cc6da1fc404b
Author: Katie D <katie@chromium.org>
Date: Tue Oct 16 17:56:22 2018

STS must search ancestors to determine if a node is the tray icon.

In the newer shelf UI, the node classname might not be the tray classname,
but one of its ancestors is instead.

Bug:  894663 
Change-Id: I90f5c09d186b7d1d0cb278c310b3ad42e6c1c62d
Reviewed-on: https://chromium-review.googlesource.com/c/1278268
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600040}
[modify] https://crrev.com/487bfbd808ca64cdaf1dd04e62e4cc6da1fc404b/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js

Status: Fixed (was: Started)

Sign in to add a comment