New issue
Advanced search Search tips

Issue 894647 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

"Switch to this tab" matches an old/incorrect title string for gmail tab

Project Member Reported by tapted@chromium.org, Oct 11

Issue description

Chrome Version       : 71.0.3559.6

See attached. I typed "assess performance" in the omnibox and it offers my gmail tab.

When clicking "switch to this tab", I'm taken to that gmail tab, but the title has been updated (and has been for a while).

The title shown in omnibox results is no longer associated with any tab.

Note the URL *does* match.

Feature work ->  Issue 780835
 
Screenshot from 2018-10-12 09-54-41.png
201 KB View Download
Cc: jdonnelly@chromium.org
There are a couple things going on here that conspire to make a confusing picture. First, the suggestion description comes from the user's history, so, yes, it could be old; this is WAI. But when we attach the "Switch to this tab" button, it implies that this message is open now, when that precise message isn't.

The reason that it matches is because we strip hash references - text in the URL after the # - when matching, because we'd like links to further down a page, for example, to match that page. Unfortunately, Gmail (but not the only site) puts context into its hash references. In this case, clicking on an individual message adds a hash ref to the URL.

Solutions: We might not strip hash refs (but this would then not produce matches for Docs, after simply paging down, for example), or close this is as WAI (or do more extreme things like only honor hash refs on certain sites, but we don't want to maintain a changing list.) A more correct but difficult solution would be to dynamically keep track of sites whose URL changes after the user scrolls. Anyways, that's the reason why you're seeing it.

Labels: Needs-Triage-M71
Owner: tommycli@chromium.org
+tommycli or Justin, krb@ sums this up really well -- should we keep this as an FR, mark it for review later, or mark it WAI given GMail updates URLs frequently?
Status: Assigned (was: Unconfirmed)
Cc: -k...@chromium.org tommycli@chromium.org
Owner: k...@chromium.org
I can take this - it's a follow-on to tab switch suggestions - but I'm fine with reviewing later.
drive-by: I don't know if this matters for whatever solution you have in mind, but the history system stop paying attention to title updates of a page after a short time.  See
https://bugs.chromium.org/p/chromium/issues/detail?id=782064&desc=2#c34

Sign in to add a comment