Downloads Home items metrics should be split between suggested and non-suggested content |
|||||
Issue descriptionCurrently all Android.DownloadManager.* metrics lump together suggested and non-suggested items (meaning automatically and manually downloaded, respectively). Offline pages are the only case where this is a problem right now as suggested articles completely overtake the metric, being in much larger number. But in the future this might be the case for other item types too. We should split these metrics to separate suggested and non-suggested content, to facilitate the tracking of manually and automatically downloaded items.
,
Oct 19
This has been added to the current Downloads Home code. Reassigning to dtrainor@ to make sure this is carried over to the new DH.
,
Oct 19
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41 commit ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41 Author: Carlos Knippschild <carlosk@chromium.org> Date: Tue Oct 23 22:08:00 2018 Adds missing OfflinePage downloads metrics reporting (M71 merge) This change also splits the reporting of offline page counts between prefetched and non-prefetched. Bug: 896095, 894643 Change-Id: Ic3bfc53ecd2558df1b349af66bbe7d3f88bd6531 Reviewed-on: https://chromium-review.googlesource.com/c/1285750 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601015}(cherry picked from commit 6195222c2431e6d83b569a4b5297c5d9be8ce890) Reviewed-on: https://chromium-review.googlesource.com/c/1297303 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#277} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java [modify] https://crrev.com/ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41/tools/metrics/histograms/histograms.xml
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41 Commit: ec9a3902c6bcaefa0a08ac47ea31894ebdc0bf41 Author: carlosk@chromium.org Commiter: carlosk@chromium.org Date: 2018-10-23 22:08:00 +0000 UTC Adds missing OfflinePage downloads metrics reporting (M71 merge) This change also splits the reporting of offline page counts between prefetched and non-prefetched. Bug: 896095, 894643 Change-Id: Ic3bfc53ecd2558df1b349af66bbe7d3f88bd6531 Reviewed-on: https://chromium-review.googlesource.com/c/1285750 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601015}(cherry picked from commit 6195222c2431e6d83b569a4b5297c5d9be8ce890) Reviewed-on: https://chromium-review.googlesource.com/c/1297303 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#277} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 19