When replacing a notification which has a reply action with one that doesn't, the old reply field stays visible |
||
Issue descriptionChrome Version: 71.0.3575.1 OS: ChromeOS What steps will reproduce the problem? (1) [in js] Show a notification with a reply field. (2) Open tray and enter in a reply. (3) [in js] replace the notification with a new notification that shares the same tag but doesn't have a reply action (renotify:true) What is the expected result? See the new notification without a reply field What happens instead? New notification shows up, but old reply field stays visible until you hide the notification and open the tray again. video: https://drive.google.com/open?id=1U97GPzPiONd1jVyp4Pg6Ucv04BoXgznm
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18ca34c6f0414c26b5626f7b7f743950e91d120c commit 18ca34c6f0414c26b5626f7b7f743950e91d120c Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 23 03:19:23 2018 message_center: Remove inline reply on change Notification inline reply did not support notification update after its creation properly. TEST=NotificationViewMD.TestInlineReplyRemovedByUpdate BUG= 894638 Change-Id: Ib03b92ea580fa45d5c4fc58de0bca2a1c7399e50 Reviewed-on: https://chromium-review.googlesource.com/c/1290234 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601840} [modify] https://crrev.com/18ca34c6f0414c26b5626f7b7f743950e91d120c/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/18ca34c6f0414c26b5626f7b7f743950e91d120c/ui/message_center/views/notification_view_md.h [modify] https://crrev.com/18ca34c6f0414c26b5626f7b7f743950e91d120c/ui/message_center/views/notification_view_md_unittest.cc
,
Oct 23
|
||
►
Sign in to add a comment |
||
Comment 1 by tetsui@chromium.org
, Oct 19