[Downloads Home] Close button on tablets should not close the activity |
|||||||||
Issue descriptionClose button on tablets should only close the current tab. This is also broken on old download home where tapping on the close button doesn't do anything.
,
Oct 13
,
Oct 15
,
Oct 15
,
Oct 16
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b24b397681fcd0b2c5383dfe2e80b5fa7accc2b7 commit b24b397681fcd0b2c5383dfe2e80b5fa7accc2b7 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Oct 16 17:46:54 2018 Download Home : Fixed close button behavior on tablets The close button shouldn't be show on the tablets which was broken. Bug: 894625 Change-Id: I4f9740132a329d2e62d43b8dc0ef858780a21c91 Reviewed-on: https://chromium-review.googlesource.com/c/1278165 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599422}(cherry picked from commit 8d4e0742142f383556c0ecd71d53c270e301b2dd) Reviewed-on: https://chromium-review.googlesource.com/c/1283989 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#43} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/b24b397681fcd0b2c5383dfe2e80b5fa7accc2b7/chrome/android/java/src/org/chromium/chrome/browser/download/home/toolbar/DownloadHomeToolbar.java [modify] https://crrev.com/b24b397681fcd0b2c5383dfe2e80b5fa7accc2b7/chrome/android/java/src/org/chromium/chrome/browser/download/home/toolbar/ToolbarCoordinator.java
,
Oct 16
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b24b397681fcd0b2c5383dfe2e80b5fa7accc2b7 Commit: b24b397681fcd0b2c5383dfe2e80b5fa7accc2b7 Author: shaktisahu@chromium.org Commiter: shaktisahu@chromium.org Date: 2018-10-16 17:46:54 +0000 UTC Download Home : Fixed close button behavior on tablets The close button shouldn't be show on the tablets which was broken. Bug: 894625 Change-Id: I4f9740132a329d2e62d43b8dc0ef858780a21c91 Reviewed-on: https://chromium-review.googlesource.com/c/1278165 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599422}(cherry picked from commit 8d4e0742142f383556c0ecd71d53c270e301b2dd) Reviewed-on: https://chromium-review.googlesource.com/c/1283989 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#43} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 25
Close button is now not available on "Downloads Home" page on tablets, verified on Samsung Galaxy Tab 3(GT-P5210)/KOT49H on latest M72- 72.0.3591.0 and 71-71.0.3578.23 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 12