Revive UI Devtools' protocol and handlings |
||
Issue descriptionUI Devtools have not be updated for a while. The protocol used to communicate with backend is outdated, so is their handling code. This might contribute to some of the crashes we see on Windows.
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7ff68ad4694f996e543b68eb001994fd7ea4471 commit a7ff68ad4694f996e543b68eb001994fd7ea4471 Author: Wei Li <weili@chromium.org> Date: Mon Oct 15 18:28:22 2018 UIDevTools: Update protocol and handling code UI DevTools have been out of sync with platform DevTools protocol. This will cause some runtime errors due to protocol incompatibility. This CL updates UI Devtools' protocol and corresponding handling code. For protocol update, we update the domain fields and its properties according to browser_protocol.pdl. We also arrange the order to put the name or id at the first, and use consistent order across different fields to make it more readable and easier for future updates. BUG= 894623 Change-Id: Ic650c126155044d2e25c4ff068c5a7a17144584f Reviewed-on: https://chromium-review.googlesource.com/c/1277835 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#599686} [modify] https://crrev.com/a7ff68ad4694f996e543b68eb001994fd7ea4471/components/ui_devtools/css_agent.cc [modify] https://crrev.com/a7ff68ad4694f996e543b68eb001994fd7ea4471/components/ui_devtools/css_agent_unittest.cc [modify] https://crrev.com/a7ff68ad4694f996e543b68eb001994fd7ea4471/components/ui_devtools/dom_agent.cc [modify] https://crrev.com/a7ff68ad4694f996e543b68eb001994fd7ea4471/components/ui_devtools/dom_agent.h [modify] https://crrev.com/a7ff68ad4694f996e543b68eb001994fd7ea4471/components/ui_devtools/overlay_agent.cc [modify] https://crrev.com/a7ff68ad4694f996e543b68eb001994fd7ea4471/components/ui_devtools/protocol.json
,
Oct 15
|
||
►
Sign in to add a comment |
||
Comment 1 by weili@chromium.org
, Oct 11