[iOS] FeatureEngagementTestCase/testNewTabTipPromoShouldShow fails. |
||||||
Issue descriptionBVC's |-isTabScrolledToTopForBubblePresenter:| implementation needs to account for the content inset as well, since it's no longer guaranteed to be UIEdgeInsetsZero.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61701cc0ee389e0dae437516d9b8edad2f874b18 commit 61701cc0ee389e0dae437516d9b8edad2f874b18 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Oct 12 10:24:10 2018 [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|. Now that the scroll proxy's contentInset is not guaranteed to be zero, we need to check against the contentInset instead of CGPointZero. Bug: 894617 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46 Reviewed-on: https://chromium-review.googlesource.com/c/1277674 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599161} [modify] https://crrev.com/61701cc0ee389e0dae437516d9b8edad2f874b18/ios/chrome/browser/ui/browser_view_controller.mm
,
Oct 12
,
Oct 29
I just noticed when looking at the beta-simulator bot that this test fix also needs to be cherry-picked to M71. PTAL, Kariah!
,
Oct 29
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
,
Nov 1
Assigning to Kariah for review for merge |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkhorimoto@chromium.org
, Oct 11