New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[EoS] Fix vertical spacing and fonts for ESP

Project Member Reported by dewittj@chromium.org, Oct 11

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2512be5cfadcae2f185fafd52338c3004636e33f

commit 2512be5cfadcae2f185fafd52338c3004636e33f
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Oct 11 22:07:50 2018

[EoS] Spacing and font fixes for ESP

This fixes several aspects of the ESP:
* Category titles are now 900 grey and 14sp.
* Vertical spacing between title, categories, and site tiles are
  corrected.
* Horizontal spacing is not correct yet.

Bug:  894609 
Change-Id: Iab25518496ab1f8fb993fa1aea19f0a1c3834211
Reviewed-on: https://chromium-review.googlesource.com/c/1278125
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598974}
[modify] https://crrev.com/2512be5cfadcae2f185fafd52338c3004636e33f/chrome/android/java/res/layout/explore_sites_category_card_view.xml
[modify] https://crrev.com/2512be5cfadcae2f185fafd52338c3004636e33f/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/2512be5cfadcae2f185fafd52338c3004636e33f/chrome/android/java/res/layout/explore_sites_title_card.xml
[modify] https://crrev.com/2512be5cfadcae2f185fafd52338c3004636e33f/chrome/android/java/res/values/dimens.xml

Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)

Sign in to add a comment