New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894600 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Smart Lock settings: Off state includes "options" text

Project Member Reported by hansberry@chromium.org, Oct 11

Issue description

See attached screenshots: When Smart Lock is turned off, its text "Screen lock options" is still present. 

Shiba, should it be hidden as well when Smart Lock is off?


 
Screenshot 2018-10-11 at 1.51.03 PM.png
25.5 KB View Download
Screenshot 2018-10-11 at 1.50.53 PM.png
38.9 KB View Download
Owner: ----
Status: Available (was: Assigned)
Yeah, Ryan, we should hide that section title if the rest of the section is hidden.
Owner: shibasheikh@chromium.org
Status: Assigned (was: Available)
OK, so I don't think that's the only conclusion that is necessary on this issue.  Given that I am moving the enabled/disabled toggle up into the subpage header (per the design), if we remove the entire 'screen lock options' section when Smart Lock is disabled, the user will see a blank page (and I believe that is an issue).

We can use that space to educate the user about what the feature is and why they should enable it, etc.  Or we can do something else with the space.  But either way we'll need designs/mocks for that.
Ah ok, thanks for the additional context, James. That makes sense.
Owner: jon...@chromium.org
When Smart lock is off we can use a descriptor text for the feature. 
'Unlock your Chromebook with your Android Phone. Learn more'

+ Jon Ann and Elizabeth for any additional feedback?

Screen Shot 2018-10-17 at 8.11.48 AM.png
781 KB View Download
My only edit is to lowercase "phone."
Thanks Shiba!
Owner: jlklein@chromium.org
Owner: hansberry@chromium.org
Cc: jessejames@chromium.org
Cc: -jessejames@google.com

Sign in to add a comment