[iOS] ContextMenuTestCase/testContextMenuDisplayedOnImage failing |
||||||
Issue descriptionAfter crrev.com/c/1252364, the frame of the WKWebView relative to the image has changed. The test needs to be updated with a new touch point that includes the top unsafe area. https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-simulator-x64%2F8728%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_integration_egtests__iPhone_5s_iOS_12.0__on_Mac%2F0%2Flogs%2FContextMenuTestCase__x2f_testContextMenuDisplayedOnImage%2F0
,
Oct 12
Does this need cherrypicking to M71 *if* the fix in comment 1 lands after M71 branch is cut?
,
Oct 12
Yes, that's right.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72a47feacbf4554331511037d8570bb1f5dad9cc commit 72a47feacbf4554331511037d8570bb1f5dad9cc Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Oct 12 00:38:28 2018 [iOS] Pick new touch location for context menu test The WKWebView frame relative to the image frame has been changed; so update the touch location. Bug: 894597 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifdf34f7596352a9414c562fee09e4b2b561702b9 Reviewed-on: https://chromium-review.googlesource.com/c/1277831 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599039} [modify] https://crrev.com/72a47feacbf4554331511037d8570bb1f5dad9cc/ios/chrome/browser/context_menu/BUILD.gn [modify] https://crrev.com/72a47feacbf4554331511037d8570bb1f5dad9cc/ios/chrome/browser/context_menu/context_menu_egtest.mm
,
Oct 12
Test is fixed; most likely after branch point though.
,
Oct 12
This bug requires manual review: We don't branch M71 until 2018-10-11. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 034619febe0d02815a5a090c38665066646dffa2 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/034619febe0d02815a5a090c38665066646dffa2 Commit: 034619febe0d02815a5a090c38665066646dffa2 Author: kkhorimoto@chromium.org Commiter: kkhorimoto@chromium.org Date: 2018-10-29 21:03:45 +0000 UTC [iOS] Pick new touch location for context menu test The WKWebView frame relative to the image frame has been changed; so update the touch location. Bug: 894597 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifdf34f7596352a9414c562fee09e4b2b561702b9 Reviewed-on: https://chromium-review.googlesource.com/c/1277831 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599039}(cherry picked from commit 72a47feacbf4554331511037d8570bb1f5dad9cc) Reviewed-on: https://chromium-review.googlesource.com/c/1306338 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#374} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/034619febe0d02815a5a090c38665066646dffa2 commit 034619febe0d02815a5a090c38665066646dffa2 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Mon Oct 29 21:03:45 2018 [iOS] Pick new touch location for context menu test The WKWebView frame relative to the image frame has been changed; so update the touch location. Bug: 894597 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifdf34f7596352a9414c562fee09e4b2b561702b9 Reviewed-on: https://chromium-review.googlesource.com/c/1277831 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599039}(cherry picked from commit 72a47feacbf4554331511037d8570bb1f5dad9cc) Reviewed-on: https://chromium-review.googlesource.com/c/1306338 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#374} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/034619febe0d02815a5a090c38665066646dffa2/ios/chrome/browser/context_menu/BUILD.gn [modify] https://crrev.com/034619febe0d02815a5a090c38665066646dffa2/ios/chrome/browser/context_menu/context_menu_egtest.mm
,
Oct 29
Merge approval for this cherry-pick was given on crbug.com/897183. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkhorimoto@chromium.org
, Oct 11