New issue
Advanced search Search tips

Issue 894582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK failure in AppListView::GetAppListTransitionProgress()

Project Member Reported by afakhry@chromium.org, Oct 11

Issue description

ToT today.

- Enable the docked magnifier (Search+Ctrl+D).
- Click on the launcher icon in the shelf.
- Chrome crashes at the DCHECK_LE(current_height_above_peeking, fullscreen_height_above_peeking);

[181376:181376:1011/131600.751629:FATAL:app_list_view.cc(1505)] Check failed: current_height_above_peeking <= fullscreen_height_above_peeking (484 vs. 218)
#0 0x7f646ff25e7f base::debug::StackTrace::StackTrace()
#1 0x7f646fe5956b logging::LogMessage::~LogMessage()
#2 0x7f645e333649 app_list::AppListView::GetAppListTransitionProgress()
#3 0x7f645e33341c app_list::AppListView::Layout()
#4 0x7f6469e5ae83 views::View::SetBoundsRect()
#5 0x7f6469e4ff38 views::FillLayout::Layout()
#6 0x7f6469e5d960 views::View::Layout()
#7 0x7f6469e6aa54 views::Widget::SetContentsView()
#8 0x7f6469e6a1b9 views::Widget::Init()
#9 0x7f645e33247a app_list::AppListView::InitializeFullscreen()
#10 0x7f645e332036 app_list::AppListView::Initialize()
#11 0x7f64695a0bf0 ash::AppListPresenterDelegateImpl::Init()
#12 0x7f645e3aa028 app_list::AppListPresenterImpl::Show()
#13 0x7f646959c7d2 ash::AppListControllerImpl::ToggleAppList()
#14 0x7f646967a7ae ash::AppListShelfItemDelegate::ItemSelected()
#15 0x7f646969983f ash::ShelfView::ButtonPressed()
#16 0x7f6469df0b84 views::Button::OnMousePressed()
#17 0x7f6469679b92 ash::AppListButton::OnMousePressed()
#18 0x7f6469e5ffb4 views::View::ProcessMousePressed()
#19 0x7f6469e5fe07 views::View::OnMouseEvent()
#20 0x7f6469ddd919 views::InkDropHostView::OnMouseEvent()
#21 0x7f646b8bcd8a ui::EventHandler::OnEvent()
#22 0x7f646b8bbd5e ui::EventDispatcher::ProcessEvent()
#23 0x7f646b8bbaf3 ui::EventDispatcherDelegate::DispatchEvent()
#24 0x7f6469e6704c views::internal::RootView::OnMousePressed()
#25 0x7f6469e6d9e7 views::Widget::OnMouseEvent()
#26 0x7f6469e8a666 views::NativeWidgetAura::OnMouseEvent()
#27 0x7f646b8bcd8a ui::EventHandler::OnEvent()
#28 0x7f646b8bbd5e ui::EventDispatcher::ProcessEvent()
#29 0x7f646b8bbaf3 ui::EventDispatcherDelegate::DispatchEvent()
#30 0x7f646b8bd7c2 ui::EventProcessor::OnEventFromSource()
#31 0x7f646b8bdd8e ui::EventSource::SendEventToSinkFromRewriter()
#32 0x7f6469611164 ash::AshWindowTreeHostPlatform::DispatchEvent()
#33 0x7f646b8c20b9 ui::DispatchEventFromNativeUiEvent()
#34 0x7f6468f815fe ui::X11WindowOzone::DispatchEvent()
#35 0x7f646c014923 ui::PlatformEventSource::DispatchEvent()
#36 0x7f645e1a2c89 ui::X11EventSourceLibevent::DispatchPlatformEvent()
#37 0x7f645e1a2721 ui::X11EventSourceLibevent::ProcessXEvent()
#38 0x7f645e19dae1 ui::X11EventSource::DispatchXEvents()
#39 0x7f646ff49002 base::MessagePumpLibevent::OnLibeventNotification()
#40 0x7f646ff6626d event_base_loop
#41 0x7f646ff4931b base::MessagePumpLibevent::Run()
#42 0x7f646fe67694 base::MessageLoop::Run()
#43 0x7f646fe99d99 base::RunLoop::Run()
#44 0x565131c2dbed ChromeBrowserMainParts::MainMessageLoopRun()
#45 0x7f646d857a17 content::BrowserMainLoop::RunMainMessageLoopParts()
#46 0x7f646d85a516 content::BrowserMainRunnerImpl::Run()
#47 0x7f646d853ff9 content::BrowserMain()
#48 0x7f646e36362e content::ContentMainRunnerImpl::Run()
#49 0x7f64701f30d5 service_manager::Main()
#50 0x7f646e361974 content::ContentMain()
#51 0x565130fa8de3 ChromeMain
#52 0x7f645f5da2b1 __libc_start_main
#53 0x565130fa8c5a _start

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39face36234ad96435a8bc205cc5fa4b7b4e0f6d

commit 39face36234ad96435a8bc205cc5fa4b7b4e0f6d
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Oct 12 23:10:35 2018

Fix DCHECK failure in AppListView::GetAppListTransitionProgress()

Bug:  894582 

Change-Id: I08b1740c9e653bb6f3aa5c57653643888d13e630
Reviewed-on: https://chromium-review.googlesource.com/c/1279239
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599402}
[modify] https://crrev.com/39face36234ad96435a8bc205cc5fa4b7b4e0f6d/ash/app_list/views/app_list_view.cc

Labels: Merge-Request-71
Status: Fixed (was: Assigned)
Thanks, Weidong!
No problem, thanks for reporting the issue!
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 13

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 13

Labels: -merge-approved-71 merge-merged-3575
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55b93a05865ed6848d4e85ec7f84c2cda1ee4098

commit 55b93a05865ed6848d4e85ec7f84c2cda1ee4098
Author: Weidong Guo <weidongg@chromium.org>
Date: Sat Oct 13 23:22:13 2018

Merge to M71: Fix DCHECK failure in AppListView::GetAppListTransitionProgress()

Bug:  894582 

Change-Id: I08b1740c9e653bb6f3aa5c57653643888d13e630
Reviewed-on: https://chromium-review.googlesource.com/c/1279239
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599402}(cherry picked from commit 39face36234ad96435a8bc205cc5fa4b7b4e0f6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1279299
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3575@{#5}
Cr-Branched-From: 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c-refs/heads/master@{#597882}
[modify] https://crrev.com/55b93a05865ed6848d4e85ec7f84c2cda1ee4098/ash/app_list/views/app_list_view.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 22

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feea0d9277c00204996589f450c64bef3e218801

commit feea0d9277c00204996589f450c64bef3e218801
Author: Weidong Guo <weidongg@chromium.org>
Date: Mon Oct 22 21:21:49 2018

Merge to M71: Fix DCHECK failure in AppListView::GetAppListTransitionProgress()

Bug:  894582 

Change-Id: I08b1740c9e653bb6f3aa5c57653643888d13e630
Reviewed-on: https://chromium-review.googlesource.com/c/1279239
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599402}(cherry picked from commit 39face36234ad96435a8bc205cc5fa4b7b4e0f6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1279299
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3575@{#5}
Cr-Original-Branched-From: 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c-refs/heads/master@{#597882}(cherry picked from commit 55b93a05865ed6848d4e85ec7f84c2cda1ee4098)
Reviewed-on: https://chromium-review.googlesource.com/c/1294837
Cr-Commit-Position: refs/branch-heads/3578@{#248}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/feea0d9277c00204996589f450c64bef3e218801/ash/app_list/views/app_list_view.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/feea0d9277c00204996589f450c64bef3e218801

Commit: feea0d9277c00204996589f450c64bef3e218801
Author: weidongg@chromium.org
Commiter: weidongg@chromium.org
Date: 2018-10-22 21:21:49 +0000 UTC

Merge to M71: Fix DCHECK failure in AppListView::GetAppListTransitionProgress()

Bug:  894582 

Change-Id: I08b1740c9e653bb6f3aa5c57653643888d13e630
Reviewed-on: https://chromium-review.googlesource.com/c/1279239
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599402}(cherry picked from commit 39face36234ad96435a8bc205cc5fa4b7b4e0f6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1279299
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3575@{#5}
Cr-Original-Branched-From: 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c-refs/heads/master@{#597882}(cherry picked from commit 55b93a05865ed6848d4e85ec7f84c2cda1ee4098)
Reviewed-on: https://chromium-review.googlesource.com/c/1294837
Cr-Commit-Position: refs/branch-heads/3578@{#248}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment