New issue
Advanced search Search tips

Issue 894563 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Oct 15
Cc:
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Older "firmwarebranch" builders don't support --withdebugsymbols

Project Member Reported by dgarr...@chromium.org, Oct 11 
This build (firmware-zako-5219.B-firmwarebranch) gets this error in BuildPackages:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8932948011230287664

09:41:09: INFO: RunCommand: /b/swarming/w/ir/cache/cbuild/workspace/chromite/bin/cros_sdk 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmprnyLUc' 'USE=-cros-debug chrome_internal chromeless_tty' 'FEATURES=separatedebug' 'IGNORE_PREFLIGHT_BINHOST=1' -- ./build_packages '--board=zako' '--accept_licenses=@CHROMEOS' --withdebugsymbols --nowithautotest --skip_chroot_upgrade --nousepkg --reuse_pkgs_from_local_boards virtual/chromeos-firmware in /b/swarming/w/ir/cache/cbuild/workspace
flags:WARN getopt: unrecognized option '--withdebugsymbols'
 --board 'zako' --accept_licenses '@CHROMEOS' --nowithautotest --skip_chroot_upgrade --nousepkg --reuse_pkgs_from_local_boards -- 'virtual/chromeos-firmware'
flags:FATAL unable to parse provided options with getopt.
Running ['/b/swarming/w/ir/cache/cbuild/workspace/src/scripts/sdk_lib/enter_chroot.sh', '--chroot', '/b/swarming/w/ir/cache/cbuild/workspace/chroot', '--cache_dir', '/b/swarming/w/ir/cache/cbuild/repository/.cache', '--', 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmprnyLUc', 'USE=-cros-debug chrome_internal chromeless_tty', 'FEATURES=separatedebug', 'IGNORE_PREFLIGHT_BINHOST=1', './build_packages', '--board=zako', '--accept_licenses=@CHROMEOS', '--withdebugsymbols', '--nowithautotest', '--skip_chroot_upgrade', '--nousepkg', '--reuse_pkgs_from_local_boards', 'virtual/chromeos-firmware'] failed with exit code 1
09:41:10: ERROR:
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3e9599355207b3e9ac1b1839e2e686200900121b

commit 3e9599355207b3e9ac1b1839e2e686200900121b
Author: Don Garrett <dgarrett@google.com>
Date: Fri Oct 12 22:18:27 2018

WorkspaceBuildPackages: Turn off debug symbols.

build_packages doesn't support --withdebugsymbols on some branches, so
turn it off based on version number.

To allow finer grained control over the build_packages command line,
this moves the invocation into the stage, and stops using
commands.Build().

Misc workspace limit handling improvements:

Turn the BeforeLimit helper into AfterLimit, since it
seems that most uses will be "turn X on after the limit".

Make the version number limit names a little friendlier.

BUG= chromium:894563 
TEST=run_tests
     cros tryjob firmware-zako-5219.B-firmwarebranch-tryjob

Change-Id: I5ef906e177359edb41e8aebbc3c2e1c06b68594b
Reviewed-on: https://chromium-review.googlesource.com/1277612
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/3e9599355207b3e9ac1b1839e2e686200900121b/cbuildbot/stages/workspace_stages.py
[modify] https://crrev.com/3e9599355207b3e9ac1b1839e2e686200900121b/cbuildbot/commands.py
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/157cda08dccdee450f03556d6616da8e9a36768b

commit 157cda08dccdee450f03556d6616da8e9a36768b
Author: Don Garrett <dgarrett@google.com>
Date: Mon Oct 15 19:13:36 2018

WorkspaceBuildPackages: Adjust --withdebugsymbols cutoff.

It seems that --withdebugsymbols is not accepted until at least after
version 6302.0.0, so adjust the limit.

BUG= chromium:894563 
TEST=cros tryjobs for every firmwarebranch config.

Change-Id: Ib03cd44cc655a0a68a9e79fbda286caa0a12e31f
Reviewed-on: https://chromium-review.googlesource.com/c/1280888
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/157cda08dccdee450f03556d6616da8e9a36768b/cbuildbot/stages/workspace_stages.py

Comment 3 by dgarr...@chromium.org, Oct 15 

Retesting branches:

firmware-nyan-5771.B-firmwarebranch-tryjob
firmware-kitty-5771.61.B-firmwarebranch-tryjob
firmware-mccloud-5827.B-firmwarebranch-tryjob
firmware-tricky-5829.B-firmwarebranch-tryjob
firmware-samus-6300.B-firmwarebranch-tryjob
firmware-auron-6301.B-firmwarebranch-tryjob
firmware-paine-6301.58.B-firmwarebranch-tryjob
firmware-yuna-6301.59.B-firmwarebranch-tryjob
firmware-guado-6301.108.B-firmwarebranch-tryjob
firmware-tidus-6301.109.B-firmwarebranch-tryjob
firmware-rikku-6301.110.B-firmwarebranch-tryjob
firmware-lulu-6301.136.B-firmwarebranch-tryjob
firmware-gandof-6301.155.B-firmwarebranch-tryjob
firmware-buddy-6301.202.B-firmwarebranch-tryjob

Comment 4 by dgarr...@chromium.org, Oct 15

Status: Fixed (was: Started)
►

Sign in to add a comment