New issue
Advanced search Search tips

Issue 894559 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 846770
Owner:
Closed: Oct 11
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

tricky-chrome-pfq and peach_pit-chrome-pfq failing due to security_AltSysCall throwing TestNAError: ALT_SYSCALL not supported

Project Member Reported by newcomer@chromium.org, Oct 11

Issue description

In the suite details [1] we see that security_AltSysCall gets tried three times.

It seems like this should be a warning instead of an Error. 


[1]
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/suiteDetails?cidbBuildId=3026368


10/11 04:58:31.139 WARNI|              test:0606| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/security_AltSyscall/security_AltSyscall.py", line 63, in run_once
    raise error.TestNAError("ALT_SYSCALL not supported")
TestNAError: ALT_SYSCALL not supported
 
Pls apply appropriate OSs label. Thank you.
Labels: OS-Chrome
Owner: newcomer@chromium.org
TestNAError is already a warning. In any case, I'm leaving Chrome OS, so you might need to find a new owner.
Mergedinto: 846770
Status: Duplicate (was: Assigned)
The problem is that TestNAError is pretty undefined. There is random outcome to it. It is better to not use it, especially in bvt-*. Instead use logging.warning and exit cleanly.

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/896c93a463869f47ad4ae23e4dae3f0eaa4b0bf1

commit 896c93a463869f47ad4ae23e4dae3f0eaa4b0bf1
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Fri Oct 12 04:33:12 2018

security_AltSyscall: reduce TestNAError to warning.

When launched from builders it causes retries for no good reason.

BUG=chromium:846770,  chromium:894559 
TEST=pylint

Change-Id: I6d299bd8eafbede2b9e5c0ebbc1916df80ba1d87
Reviewed-on: https://chromium-review.googlesource.com/c/1277969
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Trybot-Ready: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/896c93a463869f47ad4ae23e4dae3f0eaa4b0bf1/client/site_tests/security_AltSyscall/security_AltSyscall.py

Sign in to add a comment