Check How Entity Suggestions Are Suggested from History |
||
Issue descriptionWhen a user selects an entity suggestion, it gets stored in the user's query history database and the shortcuts database. We should check how these are suggested. In particular, we should check (i) when SearchProvider suggests a query from history that was an entity query: - does it display as an entity suggestion? - does selecting it go to an entity suggestion? What's most important is that these two things are consistent. The display should reflect what the search does. I have a slight preference for actually displaying queries that were originally entity suggestions as entities when re-suggested--aGSA does this--but I don't think that's strictly necessary. (ii) when Shortcuts provider suggests a query from history that was an entity query: [same questions here]
,
Oct 12
I've been looking into this, will update soon.
,
Oct 15
The results of a click on an entity suggestion vs. a click on a non-entity suggestion with the same query terms are indistinguishable from another. See two attached screenshots, which are the result of: 1. Clicking on the *Winston Churchill* entity. 2. Entering matching text (first screenshot). 3. Clearing that suggestion from my history. 4. Clicking on a plain [winston churchill] suggestion. 5. Entering matching text (second screenshot). In both cases, a URL without the additional params that force an entity suggestion is what's recorded and thus that non-entity URL is what's suggested by both the search provider and the shortcuts provider, with no additional data or URL params. To explicitly answer the questions in the bug description, for both the search provider and the shortcuts provider: - No, the history suggestion resulting from clicking on an entity suggestion does not display as an entity suggestion. - No, selecting it does not go to the forced entity search results page. |
||
►
Sign in to add a comment |
||
Comment 1 by mpear...@chromium.org
, Oct 11