New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894546 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Oct 11
Cc:
fs...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Change the 8-8-8-8 literal to uint8 in canvas color management

Project Member Reported by zakerinasab@chromium.org, Oct 11 
In canvas color management code and tests we use 8-8-8-8 literal to refer to the legacy 8 bit per pixel storage mode. This should change to uint8 as part of the upcoming changes in the proposal / spec.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a40ab63b6d7e06a5f1395cc0dafc524458300f

commit a5a40ab63b6d7e06a5f1395cc0dafc524458300f
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Thu Oct 11 20:19:22 2018

Change 8-8-8-8 literal in canvas color management code to uint8

Bug:  894546 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2dc2757f678bc0c2e8f7a575989b6bbaf1d2d592
Reviewed-on: https://chromium-review.googlesource.com/c/1277593
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598911}
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-toBlob-toDataURL.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorspace-arguments.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-p3.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-rec2020.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createPutGetImageData-colorManaged.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/draw-high-bit-depth-images.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorManagedBehavior.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/WebKit/LayoutTests/fast/canvas/color-space/transferFromImageBitmap.html
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.h
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/html/canvas/canvas_context_creation_attributes_core.h
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/html/canvas/image_data.h
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/html/canvas/image_encode_options.idl
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/imagebitmap/image_bitmap.h
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/imagebitmap/image_bitmap_options.idl
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/core/imagebitmap/image_bitmap_test.cc
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_settings.idl
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/modules/canvas/htmlcanvas/canvas_context_creation_attributes_module.idl
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/a5a40ab63b6d7e06a5f1395cc0dafc524458300f/third_party/blink/renderer/platform/image-decoders/image_decoder.h

Comment 2 by zakerinasab@chromium.org, Oct 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment