Enable a cpplint.py analyzer in chromium/src |
||||
Issue descriptionThis is a low-hanging fruit that will likely bring some utility before clang-tidy is finished. Some potential checks to include are: [readability/todo] [readability/braces] [readability/check] [readability/casting] [build/include_what_you_use] [whitespace/semicolon] [whitespace/comma] [whitespace/parens] [whitespace/braces] [whitespace/newline] Related: https://docs.google.com/spreadsheets/d/1nlpN87SgIeOgZTEiKeOpo2suEvtJTWLF2nicU9WmNTk/view (internal) (Discussion on tricium-dev@google.com)
,
Nov 20
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/142733033c271d3217475670772a036cda518524 commit 142733033c271d3217475670772a036cda518524 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Jan 09 18:53:44 2019 [tricium cpplint] Add flags for controlling cpplint These flags are intended to be specified in project configs, to enable easily enabling and disabling per-project warnings. Bug: 894530 Change-Id: I6dbe4da52f81f78c7bd2fff82d70ddb60ebfc8dd Reviewed-on: https://chromium-review.googlesource.com/c/1391395 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#19866} [modify] https://crrev.com/142733033c271d3217475670772a036cda518524/go/src/infra/tricium/functions/cpplint/cpplint_parser_test.go [modify] https://crrev.com/142733033c271d3217475670772a036cda518524/go/src/infra/tricium/functions/cpplint/cpplint_parser.go
,
Jan 10
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-tricium/+/f3a04c2ae73c6f71efc59987e182a8d18a4a47c3 commit f3a04c2ae73c6f71efc59987e182a8d18a4a47c3 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Jan 11 19:35:14 2019 Add cpplint options to tricium playground config This will be done to test out cpplint in playground. TBR=maruel TBR_REASON=playground repo Bug: 894530 Change-Id: Ie6f5d2205236690e344f85c9c2b70928d90f39e4 [modify] https://crrev.com/f3a04c2ae73c6f71efc59987e182a8d18a4a47c3/tricium-dev.cfg
,
Jan 15
Behavior confirmed to work as expected in https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1412933/5
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/e519334f743b7c7ab8a750e0de930f62bafecc13 commit e519334f743b7c7ab8a750e0de930f62bafecc13 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Jan 16 17:34:41 2019
,
Today
(10 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35269c72f0da937d9f09515f53a7b98bf9903c5e commit 35269c72f0da937d9f09515f53a7b98bf9903c5e Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Jan 22 22:17:38 2019 [tricium] Enable cpplint analyzer in chromium/src Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/I2fjO9pSVDU Since we already enforce clang-format on C++ code in Chromium, it's not very helpful to do a separate and possibly occasionally conflicting set of formatting checks using cpplint, so whitespace checks should be disabled. The initial set filters are: - disable all by default +readability/todo todo should be followed by parentheses +readability/check dcheck macros +readability/casting use static_cast +readability/fn_size avoid long functions +runtime/explicit mark single arg ctors are explicit +build/include_what_you_use add include headers +build/header_guard use header guards +build/include_order sort includes Bug: 894530 Change-Id: I962b73a6be83285110b4a678de7a3ac27995c44f Reviewed-on: https://chromium-review.googlesource.com/c/1415258 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#624960} [modify] https://crrev.com/35269c72f0da937d9f09515f53a7b98bf9903c5e/infra/config/global/tricium-prod.cfg |
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Nov 20