New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894516 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Oct 23
Cc:
brianosman@chromium.org
mtklein@chromium.org
fs...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 634542



Sign in to add a comment

Set the default color space of half float backed canvas to e-sRGB

Project Member Reported by zakerinasab@chromium.org, Oct 11 
As discussed with fserb@ and to match with the upcoming changes in the spec, the default color space of the half float backed canvas should be set to extended sRGB.

Along with that, we need to make sure proper test coverage exists for extended sRGB canvas in both layout tests and unit tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401

commit c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Oct 23 15:42:34 2018

Set the default color space of half float backed canvas to e-sRGB

Bug:  894516 ,  859102 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I38739a0c7e84426d4345632c1fad474bd3629cb3
Reviewed-on: https://chromium-review.googlesource.com/c/1283481
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601964}
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/ImageData-fidelity.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-toBlob-toDataURL.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorspace-arguments.html
[add] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-e_srgb.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-p3.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-rec2020.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createPutGetImageData-colorManaged.html
[rename] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-draw-high-bit-depth-images.html
[add] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-e_srgb.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-linear-rgb.html
[add] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-offscreenCanvas.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-p3.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-drawImage-rec2020.html
[add] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-getImageData-e_srgb.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-getImageData-linear-rgb.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/display_linear-rgb.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorManagedBehavior.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/WebKit/LayoutTests/fast/canvas/color-space/transferFromImageBitmap.html
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/bindings/core/v8/serialization/serialized_color_params.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/bindings/core/v8/serialization/serialized_color_params.h
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/core/html/canvas/image_data.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/core/html/canvas/image_data_color_settings.idl
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/core/html/canvas/image_data_test.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/platform/graphics/canvas_color_params.h
[modify] https://crrev.com/c1b25cfc5de812cc5c58d6e2a5f68f2766ad2401/third_party/blink/renderer/platform/graphics/canvas_color_params_test.cc

Comment 2 by zakerinasab@chromium.org, Oct 23

Status: Fixed (was: Assigned)
►

Sign in to add a comment