Pipe FCM based invalidations on ios |
|||||
Issue descriptionSince ios uses different factory, the invalidation should be piped separately.
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/379a2b51394938410541977cde696d67f3ceefef commit 379a2b51394938410541977cde696d67f3ceefef Author: Tanja Gornak <melandory@chromium.org> Date: Sat Oct 13 09:53:28 2018 [Tango->FCM] IOS.InvalidationProviderFactory, which uses FCMInvalidationService. Bug: 801985, 894501 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I20613ab10fbce214fcd9f430ae9e9d09913429c4 Reviewed-on: https://chromium-review.googlesource.com/c/1276648 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#599504} [modify] https://crrev.com/379a2b51394938410541977cde696d67f3ceefef/ios/chrome/browser/invalidation/BUILD.gn [add] https://crrev.com/379a2b51394938410541977cde696d67f3ceefef/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.h [add] https://crrev.com/379a2b51394938410541977cde696d67f3ceefef/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/301dcc4342d8c79705a262ce7fcb3958e3c7038b commit 301dcc4342d8c79705a262ce7fcb3958e3c7038b Author: Tanja Gornak <melandory@chromium.org> Date: Sat Oct 13 10:23:22 2018 [Tango->FCM] Ios. Use IOSChromeProfileInvalidationProviderFactory for Sync. Bug: 801985, 894501 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2c4930a7b157393bbfd8656d85d7475fcbc1b782 Reviewed-on: https://chromium-review.googlesource.com/c/1277656 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#599505} [modify] https://crrev.com/301dcc4342d8c79705a262ce7fcb3958e3c7038b/ios/chrome/browser/sync/ios_chrome_sync_client.mm [modify] https://crrev.com/301dcc4342d8c79705a262ce7fcb3958e3c7038b/ios/chrome/browser/sync/profile_sync_service_factory.cc
,
Oct 15
,
Oct 16
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
,
Oct 22
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 26
This has not been merged for over a month. I am now rejecting this merge, as it is too late for M71. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by olivierrobin@chromium.org
, Oct 12