New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Pipe FCM based invalidations on ios

Project Member Reported by melandory@chromium.org, Oct 11

Issue description

Since ios uses different factory, the invalidation should be piped separately.
 
Components: Services>Sync
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/379a2b51394938410541977cde696d67f3ceefef

commit 379a2b51394938410541977cde696d67f3ceefef
Author: Tanja Gornak <melandory@chromium.org>
Date: Sat Oct 13 09:53:28 2018

[Tango->FCM] IOS.InvalidationProviderFactory, which uses FCMInvalidationService.

Bug: 801985,  894501 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I20613ab10fbce214fcd9f430ae9e9d09913429c4
Reviewed-on: https://chromium-review.googlesource.com/c/1276648
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599504}
[modify] https://crrev.com/379a2b51394938410541977cde696d67f3ceefef/ios/chrome/browser/invalidation/BUILD.gn
[add] https://crrev.com/379a2b51394938410541977cde696d67f3ceefef/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.h
[add] https://crrev.com/379a2b51394938410541977cde696d67f3ceefef/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/301dcc4342d8c79705a262ce7fcb3958e3c7038b

commit 301dcc4342d8c79705a262ce7fcb3958e3c7038b
Author: Tanja Gornak <melandory@chromium.org>
Date: Sat Oct 13 10:23:22 2018

[Tango->FCM] Ios. Use IOSChromeProfileInvalidationProviderFactory for Sync.

Bug: 801985,  894501 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2c4930a7b157393bbfd8656d85d7475fcbc1b782
Reviewed-on: https://chromium-review.googlesource.com/c/1277656
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599505}
[modify] https://crrev.com/301dcc4342d8c79705a262ce7fcb3958e3c7038b/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/301dcc4342d8c79705a262ce7fcb3958e3c7038b/ios/chrome/browser/sync/profile_sync_service_factory.cc

Labels: -Pri-3 Merge-Request-71 Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 16

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 19

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 22

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-71 Merge-Rejected-71
This has not been merged for over a month. I am now rejecting this merge, as it is too late for M71.

Sign in to add a comment