New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894499 link

Starred by 2 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Navi] Localization

Project Member Reported by cyflee@google.com, Oct 11

Issue description

need to collect all the assets for email and google apps for each country, and translate the experience to all language X country pair. 

 
Cc: -scottchen@chromium.org cyflee@chromium.org
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
After discussion with Narmrata:

1. Agree that for email selection, we should keep the email provider name (strings) in their local languages. 

2. For Google apps, still makes sense for us to match the Apps names to the browser language (locale) since selection is limited even at global level (<10 Google Apps). If this prove to be too much trouble, can keep everything in English. 

Next step is for Namrata to provide the icon assets for all the email and Google Apps. 

Scott/Hector- can you work the localization piece into your plan? Assigning Scott you as the owner for now.
One thing i missed: For Google Apps, we can keep the URL to the US home page (e.g. www.google.com) and let the local servers redirect to country specific domains. 
I have updated the folder which the localization team had started. 
In cases where there where no logos/incorrect logos available, I have added a "to use" folder.
https://drive.google.com/corp/drive/folders/1zeseIzPvXp3_2y_-VeXPI6nL-nHS62Bw

Cc: scottchen@chromium.org
Owner: ----
Status: Available (was: Assigned)
Owner: scottchen@chromium.org
Labels: -Pri-2 Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68aafc3c9ac6c6345799375ad3e8bb31cb808175

commit 68aafc3c9ac6c6345799375ad3e8bb31cb808175
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Nov 20 20:19:15 2018

Search Engines: moved country-code functions to standalone component

This CL moves all functions related to figuring out user's country code
from component/search_engines/ to a stand-alone component, so that they
can be reused by other features that also want to know the user's country
code.

Bug: 894499
Change-Id: I1a79a4db6a5a8abcc32101db3fb7dce8013a1f16
Reviewed-on: https://chromium-review.googlesource.com/c/1334859
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609788}
[add] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/country_codes/BUILD.gn
[add] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/country_codes/DEPS
[add] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/country_codes/OWNERS
[add] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/country_codes/country_codes.cc
[add] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/country_codes/country_codes.h
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/BUILD.gn
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/DEPS
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/search_engines_pref_names.cc
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/search_engines_pref_names.h
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/template_url_prepopulate_data.cc
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/template_url_prepopulate_data.h
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/ios/chrome/browser/DEPS
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/ios/chrome/browser/search_engines/BUILD.gn
[modify] https://crrev.com/68aafc3c9ac6c6345799375ad3e8bb31cb808175/ios/chrome/browser/search_engines/search_engines_util.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de5c9c198b1eab1892fc8a4644c91e577b9c0db

commit 5de5c9c198b1eab1892fc8a4644c91e577b9c0db
Author: Ken Rockot <rockot@google.com>
Date: Wed Nov 28 19:21:58 2018

Revert "Navi: Localize Google Apps strings."

This reverts commit 5fd55b4bc1712b796a9c9b17719f28d14e99d0b7.

Reason for revert: I am fairly certain this is causing static initializer check failures on the official builder, because it changes BookmarkItem to be a non-POD type, and there are static BookmarkItem constants in the build:  https://crbug.com/909828  

Original change's description:
> Navi: Localize Google Apps strings.
> 
> Bug: 894499
> Change-Id: I698b51eac47cdb7af63e4bb2ace338f87c5e7493
> Reviewed-on: https://chromium-review.googlesource.com/c/1351779
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611759}

TBR=hcarmona@chromium.org,scottchen@chromium.org

Change-Id: I72aff79d75c2c578c509bf4525d120c0e402cc17
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894499
Reviewed-on: https://chromium-review.googlesource.com/c/1352682
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611813}
[modify] https://crrev.com/5de5c9c198b1eab1892fc8a4644c91e577b9c0db/chrome/app/onboarding_welcome_strings.grdp
[modify] https://crrev.com/5de5c9c198b1eab1892fc8a4644c91e577b9c0db/chrome/browser/ui/webui/welcome/nux/bookmark_item.h
[modify] https://crrev.com/5de5c9c198b1eab1892fc8a4644c91e577b9c0db/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/5de5c9c198b1eab1892fc8a4644c91e577b9c0db/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h

Labels: -Pri-1 M-73 Pri-2
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feab88afa2c4b43bd4646936925d934a92c74dcc

commit feab88afa2c4b43bd4646936925d934a92c74dcc
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Dec 05 18:57:33 2018

Navi: Localize Google Apps strings.

Issue was reverted previously. See: https://crrev.com/c/1352682

Bug: 894499
Change-Id: If6c418b355a60e8d5174ae45c0b3b99fdc05f4a9
Reviewed-on: https://chromium-review.googlesource.com/c/1354406
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614044}
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/app/onboarding_welcome_strings.grdp
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/bookmark_item.cc
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/bookmark_item.h
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/email_handler.cc
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/email_providers_list.cc
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/email_providers_list.h
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/feab88afa2c4b43bd4646936925d934a92c74dcc/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h

Owner: hcarmona@chromium.org
From discussion between hcarmona and namratakannan on jan 9th2019

- We evaluated the various options- agreed that disabling email selector module (option 2) for users outside of en-us is a good solution. 
- Apps selector module will not include gmail, consistent with the en-us selection. 
- Apps selection will be consistent for all locales (for now)
- After M72 us-en stable results, we will evaluate if it makes sense for us to do additional experiment in us-en for disabling email selector module all together.  
- Team will investigate a more scalable localization solution using similar techniques and data source as Clank team (e.g. topapps pipeline). This is a longer effort in preparation for the apps module v2 that includes non google sites

Sign in to add a comment