New issue
Advanced search Search tips

Issue 894492 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Enable SortRenderTargets for Skia GrContext

Project Member Reported by penghuang@chromium.org, Oct 11

Issue description

Enable SortRenderTargets for Skia GrContext
 
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12efe94ce40000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\it4grvlm\\tmpzeohaftelemetry\\histograms.json'
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12479a6ce40000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itRJ2eCb/tmppQfSdOtelemetry/histograms.json'
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14defe56e40000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/swarming/w/itdPZPTq/tmpqQIqRctelemetry/histograms.json'
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/148c104ee40000
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb762482ab99e54be75368d8da949d52af00059

commit 0cb762482ab99e54be75368d8da949d52af00059
Author: Peng Huang <penghuang@chromium.org>
Date: Fri Oct 12 19:16:22 2018

Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets.

Enable those two options which may improve skia performance.

Bug:  894492 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d
Reviewed-on: https://chromium-review.googlesource.com/c/1273267
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#599321}
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/components/viz/test/data/rotated_drop_shadow_filter_gl.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/components/viz/test/data/rotated_filter_gl.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/gpu/skia_bindings/grcontext_for_gles2_interface.cc
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/linux/compositing/masks/mask-with-added-filters-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.png
[add] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-layer-crash-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/compositing/masks/mask-with-added-filters-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
[add] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/0cb762482ab99e54be75368d8da949d52af00059/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-layer-crash-expected.png
[delete] https://crrev.com/845a997fcdcde2d43bb3f2adc2595768a4a4094e/third_party/WebKit/LayoutTests/virtual/video-surface-layer/media/video-layer-crash-expected.png

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75

commit e1fc3396bdc0b6a7091e3ad318a0085cd0989a75
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Oct 15 20:50:31 2018

Revert "Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets."

This reverts commit 0cb762482ab99e54be75368d8da949d52af00059.

Reason for revert: performance regressions

Original change's description:
> Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets.
>
> Enable those two options which may improve skia performance.
>
> Bug:  894492 
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d
> Reviewed-on: https://chromium-review.googlesource.com/c/1273267
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Cr-Commit-Position: refs/heads/master@{#599321}

TBR=penghuang@chromium.org,robertphillips@google.com,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  894492 ,895408, 895384 , 895377 , 895369 , 895280 
Change-Id: I657077091716a618d18a3d1109531e6b3819108c
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1281055
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599741}
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/components/viz/test/data/rotated_drop_shadow_filter_gl.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/components/viz/test/data/rotated_filter_gl.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/gpu/skia_bindings/grcontext_for_gles2_interface.cc
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/compositing/masks/mask-with-added-filters-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.png
[delete] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-layer-crash-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/compositing/masks/mask-with-added-filters-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
[delete] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/WebKit/LayoutTests/platform/win/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png
[modify] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-layer-crash-expected.png
[add] https://crrev.com/e1fc3396bdc0b6a7091e3ad318a0085cd0989a75/third_party/WebKit/LayoutTests/virtual/video-surface-layer/media/video-layer-crash-expected.png

Sign in to add a comment