New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

grunt: Cherry-pick altfw feature to firmware branch

Project Member Reported by sjg@chromium.org, Oct 11

Issue description

This feature needs to be picked over to be part of firmware



 
Owner: sjg@chromium.org
Status: Started (was: Available)
chromeos_overlay:
chromeos-bootimage: Build support for alternative boot loaders
edk2: Install the tianocore image
chromeos-bootimage: Add support for tianocore in altfw

dc:
Split out code from legacy bootloader support
Add support for jumping into alternative firmware

vboot_reference:
Add support for booting into alternative boot loaders

To make U-Boot work we also need a patch and to switch to a different branch. I'm not sure how to do that...

This is in now, but the firmware updater does not use RW_LEGACY now. It will once this CL is in:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1292995

For now I think I will add a temporary fix
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5c06eb665979b0bc0a840808ed68b181fb15fd5c

commit 5c06eb665979b0bc0a840808ed68b181fb15fd5c
Author: Simon Glass <sjg@chromium.org>
Date: Tue Oct 30 04:20:23 2018

chromeos-bootimage: Add the tag for silent firmware updating

At present this feature is disabled for altfw while we wait for the rest
of the CLs to land. For now, enable it in two places (legacy and altfw)
so that grunt will update the RW_LEGACY region still.

BUG= chromium:894488 
BUG=b:116605639
TEST=emerge-grunt chromeos-firmware-grunt
$ cbfstool /build/grunt/firmware/image-grunt.bin print -r RW_LEGACY \
	|grep auto_update
cros_allow_auto_update         0xfa9c0    raw                 0 none

Change-Id: I47c4a1826a55992df1021ce2962627249ed973c7
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1302814
Reviewed-by: Martin Roth <martinroth@chromium.org>

[modify] https://crrev.com/5c06eb665979b0bc0a840808ed68b181fb15fd5c/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild
[rename] https://crrev.com/5c06eb665979b0bc0a840808ed68b181fb15fd5c/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r40.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30

Labels: merge-merged-firmware-grunt-11031.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b9def4f5ca93e0787c404a60100e8740ccc983c0

commit b9def4f5ca93e0787c404a60100e8740ccc983c0
Author: Simon Glass <sjg@chromium.org>
Date: Tue Oct 30 20:55:20 2018

chromeos-bootimage: Add the tag for silent firmware updating

At present this feature is disabled for altfw while we wait for the rest
of the CLs to land. For now, enable it in two places (legacy and altfw)
so that grunt will update the RW_LEGACY region still.

BUG= chromium:894488 
BUG=b:116605639
TEST=emerge-grunt chromeos-firmware-grunt
$ cbfstool /build/grunt/firmware/image-grunt.bin print -r RW_LEGACY \
	|grep auto_update
cros_allow_auto_update         0xfa9c0    raw                 0 none

Change-Id: I47c4a1826a55992df1021ce2962627249ed973c7
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1302815
Reviewed-by: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>

[modify] https://crrev.com/b9def4f5ca93e0787c404a60100e8740ccc983c0/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild
[add] https://crrev.com/b9def4f5ca93e0787c404a60100e8740ccc983c0/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r39.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a25dc281f14b41dccfa0cc1b497d12831daed807

commit a25dc281f14b41dccfa0cc1b497d12831daed807
Author: Simon Glass <sjg@chromium.org>
Date: Wed Oct 31 01:48:11 2018

chromeos-bootimage: Add the tag for silent firmware updating

At present this feature is disabled for altfw while we wait for the rest
of the CLs to land. For now, enable it in two places (legacy and altfw)
so that grunt will update the RW_LEGACY region still.

BUG= chromium:894488 
BUG=b:116605639
TEST=emerge-grunt chromeos-firmware-grunt
$ cbfstool /build/grunt/firmware/image-grunt.bin print -r RW_LEGACY \
	|grep auto_update
cros_allow_auto_update         0xfa9c0    raw                 0 none

Change-Id: Ie5d46b4ed394a13a13b4f90332416674816419e3
Signed-off-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1302814
Reviewed-by: Martin Roth <martinroth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1309422
Tested-by: Martin Roth <martinroth@chromium.org>

[delete] https://crrev.com/c565d96488ffd96607809cec2167b69218c96d0c/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r38.ebuild
[modify] https://crrev.com/a25dc281f14b41dccfa0cc1b497d12831daed807/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild
[delete] https://crrev.com/c565d96488ffd96607809cec2167b69218c96d0c/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r36.ebuild
[add] https://crrev.com/a25dc281f14b41dccfa0cc1b497d12831daed807/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r40.ebuild

Status: Fixed (was: Started)
This is working now

Sign in to add a comment