Network Service: webRequest API redirecting to about:blank is broken |
||||||||||
Issue descriptionChrome Version: ToT OS: Desktop What steps will reproduce the problem? (1) Go to a.com in one tab (2) Install an extension that redirects a.com navigations to about:blank (3) Visit any a.com URL What is the expected result? The a.com navigations are redirected to about:blank. What happens instead? The navigation is treated as external protocol handler and on Linux xdg-open is invoked. Please use labels and text to provide additional information. I believe some ad blocking extensions use this trick to redirect unwanted requests to about:blank, so it is quite possible we have functional regressions with those.
,
Oct 11
,
Oct 11
,
Oct 11
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e55815861b7a73781b2c68bdc849d6e2d656255c commit e55815861b7a73781b2c68bdc849d6e2d656255c Author: Clark DuVall <cduvall@chromium.org> Date: Thu Oct 11 22:02:26 2018 Add about: handler for redirects in network service This is used by some extensions to redirect to using webrequest. This matches the behavior of URLRequestAboutJob. Bug: 894480 Change-Id: I565bb1072a657d1135273f14b1b91822033124de Reviewed-on: https://chromium-review.googlesource.com/c/1277265 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#598970} [modify] https://crrev.com/e55815861b7a73781b2c68bdc849d6e2d656255c/chrome/test/data/extensions/api_test/webrequest/test_redirects.js [modify] https://crrev.com/e55815861b7a73781b2c68bdc849d6e2d656255c/content/browser/loader/loader_browsertest.cc [modify] https://crrev.com/e55815861b7a73781b2c68bdc849d6e2d656255c/content/browser/loader/navigation_url_loader_impl.cc
,
Oct 11
,
Oct 11
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da29c7f2a3be80010b0f379b075628b1b8adfd6f commit da29c7f2a3be80010b0f379b075628b1b8adfd6f Author: Clark DuVall <cduvall@chromium.org> Date: Thu Oct 11 22:30:14 2018 Add redirect tests for all unsafe schemes This should match the behavior of IsSafeRedirectTarget for the ProtocolHandler for these schemes. Bug: 894480 Change-Id: Id52b94740c2fa488b163b0862be61e4805918072 Reviewed-on: https://chromium-review.googlesource.com/c/1277785 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#598985} [modify] https://crrev.com/da29c7f2a3be80010b0f379b075628b1b8adfd6f/content/public/common/url_utils.cc [modify] https://crrev.com/da29c7f2a3be80010b0f379b075628b1b8adfd6f/content/public/common/url_utils_unittest.cc
,
Oct 12
,
Oct 12
Verified this is fixed on the latest canary.
,
Oct 12
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c7e787eac52581d0142d7ebb0fe11a94d81c83 commit 94c7e787eac52581d0142d7ebb0fe11a94d81c83 Author: Clark DuVall <cduvall@chromium.org> Date: Fri Oct 12 19:29:04 2018 Add about: handler for redirects in network service This is used by some extensions to redirect to using webrequest. This matches the behavior of URLRequestAboutJob. Bug: 894480 Change-Id: I565bb1072a657d1135273f14b1b91822033124de Reviewed-on: https://chromium-review.googlesource.com/c/1277265 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598970}(cherry picked from commit e55815861b7a73781b2c68bdc849d6e2d656255c) Reviewed-on: https://chromium-review.googlesource.com/c/1277694 Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#985} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/94c7e787eac52581d0142d7ebb0fe11a94d81c83/chrome/test/data/extensions/api_test/webrequest/test_redirects.js [modify] https://crrev.com/94c7e787eac52581d0142d7ebb0fe11a94d81c83/content/browser/loader/loader_browsertest.cc [modify] https://crrev.com/94c7e787eac52581d0142d7ebb0fe11a94d81c83/content/browser/loader/navigation_url_loader_impl.cc
,
Oct 12
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c7e787eac52581d0142d7ebb0fe11a94d81c83 Commit: 94c7e787eac52581d0142d7ebb0fe11a94d81c83 Author: cduvall@chromium.org Commiter: cduvall@chromium.org Date: 2018-10-12 19:29:04 +0000 UTC Add about: handler for redirects in network service This is used by some extensions to redirect to using webrequest. This matches the behavior of URLRequestAboutJob. Bug: 894480 Change-Id: I565bb1072a657d1135273f14b1b91822033124de Reviewed-on: https://chromium-review.googlesource.com/c/1277265 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598970}(cherry picked from commit e55815861b7a73781b2c68bdc849d6e2d656255c) Reviewed-on: https://chromium-review.googlesource.com/c/1277694 Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#985} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by jam@chromium.org
, Oct 11Owner: cduvall@chromium.org