New issue
Advanced search Search tips

Issue 894457 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT] virtual/layout_ng_experimental/external/wpt/css/css-flexbox/dynamic-bsize-change.html hits a DCHECK

Project Member Reported by robertma@chromium.org, Oct 11

Issue description

A new test from WPT upstream css/css-flexbox/dynamic-bsize-change.html (https://github.com/web-platform-tests/wpt/commit/2792963d80565a8aac7a961152d59da6ab8d7404) is hitting a DCHECK when running in the layout_ng_experimental virtual suite during import:

https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/207021/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: [1:1:1011/064604.536158:FATAL:ng_flex_layout_algorithm.cc(24)] Check failed: !Style().IsColumnFlexDirection(). Column flexboxes aren't supported yet
STDERR: #0 0x0000041acc7f base::debug::StackTrace::StackTrace()
STDERR: #1 0x000004104d4b logging::LogMessage::~LogMessage()
STDERR: #2 0x000006ac92aa blink::NGFlexLayoutAlgorithm::Layout()
STDERR: #3 0x000006ab4258 blink::(anonymous namespace)::LayoutWithAlgorithm()
STDERR: #4 0x000006ab300e blink::NGBlockNode::Layout()
STDERR: #5 0x000006abf826 blink::NGBlockLayoutAlgorithm::LayoutNewFormattingContext()
STDERR: #6 0x000006abbdce blink::NGBlockLayoutAlgorithm::HandleNewFormattingContext()
STDERR: #7 0x000006aba74d blink::NGBlockLayoutAlgorithm::Layout()
STDERR: #8 0x000006ab440b blink::(anonymous namespace)::LayoutWithAlgorithm()
STDERR: #9 0x000006ab300e blink::NGBlockNode::Layout()
STDERR: #10 0x000006ad1a87 blink::NGLayoutInputNode::Layout()
STDERR: #11 0x000006abce93 blink::NGBlockLayoutAlgorithm::HandleInflow()
STDERR: #12 0x000006aba3e0 blink::NGBlockLayoutAlgorithm::Layout()
STDERR: #13 0x000006ab440b blink::(anonymous namespace)::LayoutWithAlgorithm()
STDERR: #14 0x000006ab300e blink::NGBlockNode::Layout()
STDERR: #15 0x000006aa5bb5 blink::LayoutNGBlockFlow::UpdateBlockLayout()
STDERR: #16 0x0000068fc388 blink::LayoutBlock::UpdateLayout()
STDERR: #17 0x00000690dd05 blink::LayoutBlockFlow::PositionAndLayoutOnceIfNeeded()
STDERR: #18 0x00000690e1e8 blink::LayoutBlockFlow::LayoutBlockChild()
STDERR: #19 0x00000690cad6 blink::LayoutBlockFlow::LayoutBlockChildren()
STDERR: #20 0x00000690aedb blink::LayoutBlockFlow::LayoutChildren()
STDERR: #21 0x00000690a4ab blink::LayoutBlockFlow::UpdateBlockLayout()
STDERR: #22 0x000006a32424 blink::LayoutView::UpdateBlockLayout()
STDERR: #23 0x0000068fc388 blink::LayoutBlock::UpdateLayout()
STDERR: #24 0x000006a32701 blink::LayoutView::UpdateLayout()
STDERR: #25 0x000006507c4c blink::LocalFrameView::PerformLayout()
STDERR: #26 0x000006505fb7 blink::LocalFrameView::UpdateLayout()
STDERR: #27 0x0000061c1626 blink::Document::UpdateStyleAndLayout()
STDERR: #28 0x0000061c1fb8 blink::Document::EnsurePaintLocationDataValidForNode()
STDERR: #29 0x00000668771d blink::HTMLElement::offsetTopForBinding()
STDERR: #30 0x000005b3a189 blink::V8HTMLElement::offsetTopAttributeGetterCallback()
STDERR: #31 0x000002733734 v8::internal::FunctionCallbackArguments::Call()
STDERR: #32 0x000002731db8 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
STDERR: #33 0x000002730bdb v8::internal::Builtins::InvokeApiFunction()
STDERR: #34 0x000002c9b922 v8::internal::Object::GetPropertyWithAccessor()
STDERR: #35 0x000002c9a8ae v8::internal::Object::GetProperty()
STDERR: #36 0x000002ba8f1a v8::internal::LoadIC::Load()
STDERR: #37 0x000002bb7c67 v8::internal::__RT_impl_Runtime_LoadIC_Miss()
STDERR: #38 0x0000033ab5b5 <unknown>
STDERR: 
STDERR: [31249:31273:1011/064604.911651:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ...
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec5cc117c24dcaadbcc0ff576cc4288c676781f2

commit ec5cc117c24dcaadbcc0ff576cc4288c676781f2
Author: Robert Ma <robertma@chromium.org>
Date: Thu Oct 11 15:43:10 2018

Add an expectation for a new test failing DCHECK

TBR=foolip

No-Try: True
Bug: 894457
Change-Id: I078420e54ad1b4626d5064b926da72048c6761c8
Reviewed-on: https://chromium-review.googlesource.com/c/1276828
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598774}
[modify] https://crrev.com/ec5cc117c24dcaadbcc0ff576cc4288c676781f2/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment