Save card infobar doesn't update its position when secondary toolbar appears |
|||
Issue descriptionIf the secondary toolbar is hidden when the save card infobar shows, the infobar won't update its position after the secondary toolbar reappears and partially gets covered by it.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eed8b574888374203877c0efea951fd6768b069f commit eed8b574888374203877c0efea951fd6768b069f Author: sczs <sczs@chromium.org> Date: Wed Nov 14 02:02:29 2018 [ios] Displays SaveCardInfobar above of Bottom Toolbar. - Updates the bottomAnchorConstraint constant on sizeThatFits so its updated by the Fullscreen changes. This will also push the Infobar above the bottom toolbar, causing it not to be covered by the toolbar. - Adds missing super calls to will willMoveToSuperview and didMoveToSuperview. Screenshots: https://drive.google.com/open?id=1F8hUj6Cb5VEcOHuSOa8vv6wc8IXY5CeW https://drive.google.com/open?id=1dlDS3HktGQE8iAwgsJDxcGlEo-MOBvND Bug: 894449 Change-Id: I987f5eb3e8a8580323a0367d45c885406edcd7a0 Reviewed-on: https://chromium-review.googlesource.com/c/1334658 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607839} [modify] https://crrev.com/eed8b574888374203877c0efea951fd6768b069f/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
,
Nov 14
,
Nov 20
Save Card infobar adjusts correctly when secondary toolbar appears and disappears. Verified on M72.0.3616.0 dev iPhoneX, iOS12.1.1 beta3 |
|||
►
Sign in to add a comment |
|||
Comment 1 by mahmadi@chromium.org
, Oct 11Owner: mahmadi@chromium.org
Status: Assigned (was: Untriaged)