New issue
Advanced search Search tips

Issue 894439 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

AEC3: Avoid ducking when render signal is stationary at call startup

Project Member Reported by peah@chromium.org, Oct 11

Issue description

When the render signal consists of stationary noise immediately during call startup it can cause excessive ducking.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/74cd1ef9f59d26fd651325e608d25fdb1319d83e

commit 74cd1ef9f59d26fd651325e608d25fdb1319d83e
Author: Jesús de Vicente Peña <devicentepena@webrtc.org>
Date: Thu Oct 11 16:14:22 2018

AEC3: Enabling by default the use of the stationarity properties at render at init

In this CL the use of the stationarity properties at init is set to true by default.

Bug:  webrtc:9865 ,  chromium:894439 
Change-Id: I716ce0d792a50616dc38cc0ba6f2c702549a81cc
Reviewed-on: https://webrtc-review.googlesource.com/c/105303
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25123}
[modify] https://crrev.com/74cd1ef9f59d26fd651325e608d25fdb1319d83e/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/74cd1ef9f59d26fd651325e608d25fdb1319d83e/modules/audio_processing/aec3/echo_canceller3.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc36ab03f1e4ca2ca8d1565109b32b51f3dda7bf

commit fc36ab03f1e4ca2ca8d1565109b32b51f3dda7bf
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 12 00:53:24 2018

Roll src/third_party/webrtc fb226af64dad..1cd39fa9ea0c (14 commits)

https://webrtc.googlesource.com/src.git/+log/fb226af64dad..1cd39fa9ea0c


git log fb226af64dad..1cd39fa9ea0c --date=short --no-merges --format='%ad %ae %s'
2018-10-11 jonaso@webrtc.org make CreateOffer/CreateAnswer use ice credentials of pooled sessions.
2018-10-11 yvesg@webrtc.org Headers shouldn't include themselves.
2018-10-11 benwright@webrtc.org Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h
2018-10-11 srte@webrtc.org Adds handling of untracked data to congestion controller.
2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f34485ffde..9d052f4b6f (598711:598839)
2018-10-11 srte@webrtc.org Removes socket addresses from PacketInfo struct.
2018-10-11 srte@webrtc.org Adds tracking of allocated but unacknowledged bitrate.
2018-10-11 nisse@webrtc.org Delete unused utf8 conversion utilities
2018-10-11 srte@webrtc.org Adds IP overhead info to PacketInfo.
2018-10-11 devicentepena@webrtc.org AEC3: Enabling by default the use of the stationarity properties at render at init
2018-10-11 terelius@webrtc.org RtcEventLogSource no longer uses deprecated parsing functions.
2018-10-11 yvesg@webrtc.org Fix race conditions for ReofferDoesNotCallOnTrack test.
2018-10-11 gustaf@webrtc.org AEC3: Kill kill-switches
2018-10-11 srte@webrtc.org Adds default values for feedback/allocation indicators.


Created with:
  gclient setdep -r src/third_party/webrtc@1cd39fa9ea0c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:894439
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idd9b3d88e5b4ce791774fabce00dfddd33a9ad21
Reviewed-on: https://chromium-review.googlesource.com/c/1277758
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599043}
[modify] https://crrev.com/fc36ab03f1e4ca2ca8d1565109b32b51f3dda7bf/DEPS

Status: Assigned (was: Untriaged)
Assigning these all to you, since it looks like you reported them and they're about AEC3. Untriaged needs to get triaged. :)
Labels: Merge-Request-71
We'd like to merge this to M71. It addresses issues in M69-M70 where the AEC may have a  choppy transparency if the other endpoint is noisy.

The issue has been well tested in a release testing session as well as on offline recordings, is active beneath a finch experiment and has a killswitch. Therefore, the merge is to be considered very safe.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 19

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #4.
Pls merge your change to M71 branch #3578 latest by Monday morning PT so we can pick it up for next M71 Beta release. Thank you.


Pls merge your change to M71 branch 3578 latest by 1:00 PM PT, Monday, 10/22 so we can pick it up for next week beta release. Thank you. 
This CL has been merged.
The merging CL was
-https://webrtc-review.googlesource.com/c/src/+/107343
Labels: Merge-Merged
Labels: -Merge-Merged -Merge-Approved-71 Merge-Merged-71
Applying "Merge-Merged-71" label per comment #9.

Sign in to add a comment