Failure in loading_metric.html on Android WebView perf bot |
||||||
Issue description
(ERROR) 2018-10-11 11:29:31,411 page_test_results.Fail:540 Failure recorded: TypeError: Cannot read property 'rendererHelpers' of undefined
at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:35)
at runMetrics (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:61:16)
at metricMapFunction (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:190:24)
at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
at mapSingleTraceWithResult (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
at Object.mapSingleTraceMain (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)
at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:90:15)
at Object.loadHTMLFile (/b/swarming/w/ir/third_party/catapult/third_party/vinn/vinn/html_imports_loader.js:140:5)
Full log: https://chrome-swarming.appspot.com/task?id=407ba7f094e0f810
,
Oct 15
Looks like this is a pretty flaky failure on the webview bot: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=performance_webview_test_suite&tests=loading.mobile%2FFacebook_3g We could easily add a check to make sure that chromeHelper is defined here: https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/system_health/loading_metric.html?q=loading_metric.html&sq=package:chromium&g=0&l=425 but the bigger question is why is it not in these cases? Model.getOrCreateHelper() will return undefined if a helper does not support a model: https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/model/model.html?q=getOrCreateHelper&sq=package:chromium&dr=C&l=133 Looks like supportsModel is looking for browser processes and doesn't find any: https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/model/helpers/chrome_model_helper.html?l=79 Adding some people to see if they have insight here as to why the webview bots might be failing on this.
,
Oct 15
+Torne, Boliu: webview experts
,
Oct 15
,
Oct 22
Ping to Torne and Boliu for any thoughts.
,
Oct 22
Sorry, not at all familiar with what this test is doing :|
,
Nov 13
It seems like the first step is to make it so that Telemetry uploads the trace files when metric computation fails. I'm sending out a CL right now to do that.
,
Nov 21
Juan noticed that this reproduces on Mac for a new story: https://chromium-review.googlesource.com/c/chromium/src/+/1296593 (ERROR) 2018-11-21 03:55:03,797 page_test_results.Fail:545 Failure recorded: TypeError: Cannot read property 'rendererHelpers' of undefined at RegisteredTypeInfo.loadingMetric [as constructor] (/tracing/metrics/system_health/loading_metric.html:476:36) https://chrome-swarming.appspot.com/task?id=414eeeec880cfb10&refresh=10&show_raw=1&wide_logs=true |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sullivan@chromium.org
, Oct 12