New issue
Advanced search Search tips

Issue 894428 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
ftirelo@chromium.org
se...@chromium.org
rogerm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Fix unittests that rely on data-url support

Project Member Reported by rogerm@chromium.org, Oct 11 
Autofill is, be default, restricted to content from HTTP/S origins.

Most unittests that were using data-url loading to exercise autofill have been updated to launch an embedded test server to serve the data. 

Some tests/helpers still need to be updated.

In: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/
  - AutofillPopupTest.java
  - AutofillPopupWithKeyboardTest.java
  - keyboard_accessory/ManualFillingIntegrationTest.java
  - keyboard_accessory/ManualFillingTestHelper.java
  - keyboard_accessory/PasswordAccessoryIntegrationTest.java

In: chrome/browser/autofill/
  - autofill_server_browsertest.cc

In support of these tests, a feature was added to enable autofill for non-HTTP(S) pages during testing.

The tests should be fixed and the feature (or at least it's use)_retired.

Comment 1 by rogerm@chromium.org, Oct 11 

 Issue 892152  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7300efea63d93b082e780c02b953bd3ed32e9b09

commit 7300efea63d93b082e780c02b953bd3ed32e9b09
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Oct 11 17:37:45 2018

[autofill] Only consider forms from HTTP(S) origins.

Autofill will not query/upload form information for form URLS
having a non HTTP(S) scheme.

Bug:  607907 , 894428
Change-Id: Ic03afbec002e3cf005d22ac25fd96e90b0be1273
Reviewed-on: https://chromium-review.googlesource.com/c/1257184
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598824}
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/form_data_importer_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/7300efea63d93b082e780c02b953bd3ed32e9b09/components/password_manager/core/browser/password_form_manager_unittest.cc
►

Sign in to add a comment