New issue
Advanced search Search tips

Issue 894427 link

Starred by 2 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Oct 15
Cc:
thomasanderson@chromium.org
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Use _LIBCPP_ENABLE_NODISCARD, _LIBCPP_NODISCARD_EXT

Project Member Reported by thakis@google.com, Oct 11 
https://reviews.llvm.org/rL342808 added opt-ins for having [[nodiscard]] on more libc++ functions.

_LIBCPP_ENABLE_NODISCARD enables the ones dictated by C++17, but without having to use C++17. _LIBCPP_NODISCARD_EXT enables more "useful" [[nodiscard]]s.

This sounds useful; we should roll that in and use it.

Comment 1 by thomasanderson@chromium.org, Oct 11

Owner: thomasanderson@chromium.org
Status: Started (was: Untriaged)
sgtm

Comment 3 by thakis@google.com, Oct 11

Cc: -dchervov@google.com dcheng@chromium.org
(fixing autocomplete fail)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/817dd11741bc7c32229eb3df2b48d09db72f697b

commit 817dd11741bc7c32229eb3df2b48d09db72f697b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Oct 11 21:42:38 2018

Fix v8::internal::Simulator::ResetState on arm

BUG= chromium:894427 
R=machenbach

Change-Id: I129f512960ffc81b607bcdae1e43ddb94358d1df
Reviewed-on: https://chromium-review.googlesource.com/c/1277609
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56580}
[modify] https://crrev.com/817dd11741bc7c32229eb3df2b48d09db72f697b/src/arm64/simulator-arm64.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f76ea334a7df6c53a6253cb1bfdd88dd998e430

commit 6f76ea334a7df6c53a6253cb1bfdd88dd998e430
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Oct 15 20:26:13 2018

Build with _LIBCPP_ENABLE_NODISCARD

Also rolls buildtools [1] and includes some small cleanups.

[1] https://chromium.googlesource.com/chromium/buildtools/+log/2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96..13a00f110ef910a25763346d6538b60f12845656

BUG= 894427 
R=thakis

Change-Id: I52fd273ab2e93f8c5e461fd3bf7a34b09135d384
Reviewed-on: https://chromium-review.googlesource.com/c/1277374
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599734}
[modify] https://crrev.com/6f76ea334a7df6c53a6253cb1bfdd88dd998e430/DEPS
[modify] https://crrev.com/6f76ea334a7df6c53a6253cb1bfdd88dd998e430/build/config/posix/BUILD.gn
[modify] https://crrev.com/6f76ea334a7df6c53a6253cb1bfdd88dd998e430/build/config/win/BUILD.gn

Comment 6 by thomasanderson@chromium.org, Oct 15

Status: Fixed (was: Started)

Comment 7 by thakis@chromium.org, Oct 16 

Thanks much for doing this, thomasanderson :-)
►

Sign in to add a comment