New issue
Advanced search Search tips

Issue 894420 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MediaStream check in */media_control_overlay_play_button_element.cc

Project Member Reported by guidou@chromium.org, Oct 11

Issue description

third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc

In these files there is a logic that is supposed to apply only when the media element is playing a regular src URL (i.e., not when it's a MediaStream).

During the removal of MediaStreamRegistry a check that it was not a MediaStream URL was removed. This check was incomplete (and is now unnecessary since MediaStream URLs don't exist anymore).

However, a check that the element is not playing a MediaStream should be added.


See https://chromium-review.googlesource.com/c/chromium/src/+/1221320
 
Components: Blink>Media>Controls
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment