New issue
Advanced search Search tips

Issue 894410 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 774955



Sign in to add a comment

No manual password saving on https://www.teacherspayteachers.com/Signup/Buyer

Project Member Reported by vabr@chromium.org, Oct 11

Issue description

Chrome Version: 71.0.3578.0 (Developer Build) (64-bit)
OS: GNU/Linux

What steps will reproduce the problem?
(1) Go to https://www.teacherspayteachers.com/Signup/Buyer
(2) Type into the password field

What is the expected result?
A key icon in the Omnibox shows up as soon as the password field is not empty.

What happens instead?
No key icon.


Notes: The visible field is of type="text", there is also a type="hidden" one with the actual password value, named "data[User][password]". The form contains only one type="password" field, and that one is nameless and not visible. However, at the time of parsing, a field named "data[User][password]" is seen as type="password".
 
We could try to address this by changing WebInputElement::IsPasswordFieldForAutofill() to also return true if the current type is hidden. I don't know whether this would fix it nor whether that would be an advisable change, though.
I tend to think that this would be overfitting.
We would need to make sure that hidden fields are never considered for filling, which could make stealing passwords easier.

If we offer hidden fields for saving, in the presence of a better alternatives (and without automatically popping up the save prompt), it might be useful without too much noise caused.

However, overfitting seems to be a concern to me too -- if this is fits a very rare login-form-handling pattern and we are not sure about the impact on a broader set of sites, perhaps it's not worth it.

Note that the login form on the site does not have this problem. So while the user would need to remember the password from sign-up, they only need to input it once on login.

Sign in to add a comment