New issue
Advanced search Search tips

Issue 894406 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Active Directory login is broken for Chrome OS linux build

Project Member Reported by rsorokin@chromium.org, Oct 11

Issue description

Chrome Version: TOT
OS: Chrome OS linux build

What steps will reproduce the problem?
(1) Enroll and join device to Active Directory management
(2) Try to login

What is the expected result?
Normal login

What happens instead?
Crash (see more above)

Regression CL: https://chromium-review.googlesource.com/c/chromium/src/+/1256570

Check go/streamlinesteps for Gaia creds. For Active Directory creds any sane strings would work.

[195021:195021:1011/141036.770904:FATAL:thread_restrictions.cc(32)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices).
#0 0x7ff81f96450f base::debug::StackTrace::StackTrace()
#1 0x7ff81f89794b logging::LogMessage::~LogMessage()
#2 0x7ff81f931cf9 base::AssertBlockingAllowed()
#3 0x7ff81f969eec base::PathExists()
#4 0x7ff81fb27351 ui::PathProvider()
#5 0x7ff81f8ca6fa base::PathService::Get()
#6 0x7ff81fb22ee6 ui::ResourceBundle::GetLocaleFilePath()
#7 0x7ff81fb22e72 ui::ResourceBundle::LocaleDataPakExists()
#8 0x7ff81fb11325 (anonymous namespace)::IsLocaleAvailable()
#9 0x7ff81fb10c2f l10n_util::CheckAndResolveLocale()
#10 0x5617f8445c66 chromeos::locale_util::IsNativeUILanguage()
#11 0x5617f85b23d2 chromeos::UserSessionManager::RespectLocalePreference()
#12 0x5617f85b6443 chromeos::UserSessionManager::RespectLocalePreferenceWrapper()
#13 0x5617f89af905 ProfileImpl::OnPrefsLoaded()
#14 0x7ff81a7f1307 PrefNotifierImpl::OnInitializationCompleted()
#15 0x7ff81a263804 policy::ConfigurationPolicyPrefStore::OnPolicyServiceInitialized()
#16 0x7ff81a29c6b0 policy::PolicyServiceImpl::CheckInitializationComplete()
#17 0x7ff81a29b534 policy::PolicyServiceImpl::MergeAndTriggerUpdates()
#18 0x7ff81a26cb87 _ZN4base8internal7InvokerINS0_9BindStateIMN6policy19URLBlacklistManagerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#19 0x7ff81f87acba base::debug::TaskAnnotator::RunTask()
#20 0x7ff81f8a5e9f base::MessageLoop::RunTask()
#21 0x7ff81f8a6293 base::MessageLoop::DoWork()
#22 0x7ff81f9878f9 base::MessagePumpLibevent::Run()
#23 0x7ff81f8a5a44 base::MessageLoop::Run()
#24 0x7ff81f8d82f9 base::RunLoop::Run()
#25 0x5617f88dbe7d ChromeBrowserMainParts::MainMessageLoopRun()
#26 0x7ff81c899e07 content::BrowserMainLoop::RunMainMessageLoopParts()
#27 0x7ff81c89c906 content::BrowserMainRunnerImpl::Run()
#28 0x7ff81c8963c9 content::BrowserMain()
#29 0x7ff81d32405e content::ContentMainRunnerImpl::Run()
#30 0x7ff81fc26025 service_manager::Main()
#31 0x7ff81d3223a4 content::ContentMain()
#32 0x5617f7c8ded3 ChromeMain
#33 0x7ff81053b2b1 __libc_start_main
#34 0x5617f7c8dd4a _start

Received signal 6
#0 0x7ff81f96450f base::debug::StackTrace::StackTrace()
#1 0x7ff81f964011 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7ff811e160c0 <unknown>
#3 0x7ff81054dfcf gsignal
#4 0x7ff81054f3fa abort
#5 0x7ff81f962e85 base::debug::BreakDebugger()
#6 0x7ff81f897d16 logging::LogMessage::~LogMessage()
#7 0x7ff81f931cf9 base::AssertBlockingAllowed()
#8 0x7ff81f969eec base::PathExists()
#9 0x7ff81fb27351 ui::PathProvider()
#10 0x7ff81f8ca6fa base::PathService::Get()
#11 0x7ff81fb22ee6 ui::ResourceBundle::GetLocaleFilePath()
#12 0x7ff81fb22e72 ui::ResourceBundle::LocaleDataPakExists()
#13 0x7ff81fb11325 (anonymous namespace)::IsLocaleAvailable()
#14 0x7ff81fb10c2f l10n_util::CheckAndResolveLocale()
#15 0x5617f8445c66 chromeos::locale_util::IsNativeUILanguage()
#16 0x5617f85b23d2 chromeos::UserSessionManager::RespectLocalePreference()
#17 0x5617f85b6443 chromeos::UserSessionManager::RespectLocalePreferenceWrapper()
#18 0x5617f89af905 ProfileImpl::OnPrefsLoaded()
#19 0x7ff81a7f1307 PrefNotifierImpl::OnInitializationCompleted()
#20 0x7ff81a263804 policy::ConfigurationPolicyPrefStore::OnPolicyServiceInitialized()
#21 0x7ff81a29c6b0 policy::PolicyServiceImpl::CheckInitializationComplete()
#22 0x7ff81a29b534 policy::PolicyServiceImpl::MergeAndTriggerUpdates()
#23 0x7ff81a26cb87 _ZN4base8internal7InvokerINS0_9BindStateIMN6policy19URLBlacklistManagerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#24 0x7ff81f87acba base::debug::TaskAnnotator::RunTask()
#25 0x7ff81f8a5e9f base::MessageLoop::RunTask()
#26 0x7ff81f8a6293 base::MessageLoop::DoWork()
#27 0x7ff81f9878f9 base::MessagePumpLibevent::Run()
#28 0x7ff81f8a5a44 base::MessageLoop::Run()
#29 0x7ff81f8d82f9 base::RunLoop::Run()
#30 0x5617f88dbe7d ChromeBrowserMainParts::MainMessageLoopRun()
#31 0x7ff81c899e07 content::BrowserMainLoop::RunMainMessageLoopParts()
#32 0x7ff81c89c906 content::BrowserMainRunnerImpl::Run()
#33 0x7ff81c8963c9 content::BrowserMain()
#34 0x7ff81d32405e content::ContentMainRunnerImpl::Run()
#35 0x7ff81fc26025 service_manager::Main()
#36 0x7ff81d3223a4 content::ContentMain()
#37 0x5617f7c8ded3 ChromeMain
#38 0x7ff81053b2b1 __libc_start_main
#39 0x5617f7c8dd4a _start
  r8: 0000000000000000  r9: 00007ffdf89a9570 r10: 0000000000000008 r11: 0000000000000246
 r12: 00007ffdf89aa040 r13: 00007ffdf89aa030 r14: 00007ffdf89aa038 r15: 00007ffdf89a9fe1
  di: 0000000000000002  si: 00007ffdf89a9570  bp: 00007ffdf89a97b0  bx: 0000000000000006
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007ff81054dfcf  sp: 00007ffdf89a95e8
  ip: 00007ff81054dfcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

 
cat out/Default/args.gn 
# Build arguments go here. Examples:
#   is_component_build = true
#   is_debug = false
symbol_level = 0
is_component_build = true
enable_nacl = false
use_goma = true
target_os = "chromeos"
is_official_build = false
is_chrome_branded = false
is_debug = false
remove_webcore_debug_symbols = true
dcheck_always_on = true

autoninja -C out/Default/ chrome && out/Default/chrome --login-manager --login-profile=user --disable-setuid-sandbox --no-sandbox --user-data-dir=/tmp/chromad
The issue is that now IsNativeUILanguage() is called even when kAllowedLanguages is empty: https://chromium-review.googlesource.com/c/chromium/src/+/1256570/14/chrome/browser/chromeos/base/locale_util.cc#161


Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13

commit ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13
Author: Alexander Hendrich <hendrich@chromium.org>
Date: Sat Oct 13 09:52:08 2018

Revert "Updated AllowedUILocales to handle preferred languages."

This reverts commit 75d0995fa069994cee37b7ba3c940c6927e7d91b.

Reason for revert: Causes DCHECK crashes on sign-in

Original change's description:
> Updated AllowedUILocales to handle preferred languages.
> 
> Updated AllowedUILocales to limit not only the ui locales but also the
> available preferred languages. Renamed AllowedUILocales to AllowedLanguages to
> better indicate that.
> 
> Bug:  579660 ,  876494 ,  894406 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3
> Reviewed-on: https://chromium-review.googlesource.com/c/1256570
> Commit-Queue: Zakhar Voit <voit@google.com>
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597559}

TBR=stevenjb@chromium.org,droger@chromium.org,poromov@chromium.org,hendrich@chromium.org,voit@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  579660 
Change-Id: I6107a6668abde445d972a97e63dca93446b0ab0d
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/c/1278761
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599503}
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/chromeos/base/locale_util.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/chromeos/base/locale_util.h
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/chromeos/preferences.h
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/profiles/profile.h
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/resources/settings/languages_page/languages_types.js
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/browser/ui/webui/settings/languages_handler.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/common/extensions/api/language_settings_private.idl
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/common/pref_names.cc
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/common/pref_names.h
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/components/policy/resources/policy_templates.json
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/third_party/closure_compiler/externs/language_settings_private.js
[modify] https://crrev.com/ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13/tools/metrics/histograms/enums.xml

Status: Verified (was: Assigned)
Thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 22

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24d2e318f99b4eea30ada95a37122e91fddc116

commit f24d2e318f99b4eea30ada95a37122e91fddc116
Author: Alexander Hendrich <hendrich@chromium.org>
Date: Mon Oct 22 16:01:55 2018

[Merge M71] Revert "Updated AllowedUILocales to handle preferred languages."

This reverts commit 75d0995fa069994cee37b7ba3c940c6927e7d91b.

Reason for revert: Causes DCHECK crashes on sign-in

Original change's description:
> Updated AllowedUILocales to handle preferred languages.
>
> Updated AllowedUILocales to limit not only the ui locales but also the
> available preferred languages. Renamed AllowedUILocales to AllowedLanguages to
> better indicate that.
>
> Bug:  579660 ,  876494 ,  894406 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3
> Reviewed-on: https://chromium-review.googlesource.com/c/1256570
> Commit-Queue: Zakhar Voit <voit@google.com>
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597559}

TBR=stevenjb@chromium.org,droger@chromium.org,poromov@chromium.org,hendrich@chromium.org,voit@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  579660 
Change-Id: I6107a6668abde445d972a97e63dca93446b0ab0d
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/c/1278761
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599503}(cherry picked from commit ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13)
Reviewed-on: https://chromium-review.googlesource.com/c/1293909
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#210}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/chromeos/base/locale_util.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/chromeos/base/locale_util.h
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/chromeos/preferences.h
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/profiles/profile.h
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/resources/settings/languages_page/languages_types.js
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/browser/ui/webui/settings/languages_handler.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/common/extensions/api/language_settings_private.idl
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/common/pref_names.cc
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/common/pref_names.h
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/components/policy/resources/policy_templates.json
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/third_party/closure_compiler/externs/language_settings_private.js
[modify] https://crrev.com/f24d2e318f99b4eea30ada95a37122e91fddc116/tools/metrics/histograms/enums.xml

Sign in to add a comment