New issue
Advanced search Search tips

Issue 894392 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Unnecessarily 'Close' icon is seen in 'Join Wi-Fi network' overlay

Project Member Reported by mmanchala@chromium.org, Oct 11

Issue description

Chrome Version: 70.0.3538.55/11021.44.0 beta channel Kip,Reks & Daisy   
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> 'Join Wi-Fi network' overlay is seen -> now observe 'Close' icon is seen unnecessarily even though  'Cancel' option is available 
(Please refer Screenshot)

Note : In 'Configure ...' & 'Confirm your password' overlay  close icon is not available 
(Please refer 'Expected_NoCloseIcon' screenshot)

Expected: unnecessarily  'Close' icon should not be seen in 'Join Wi-Fi network' overlay 
Actual: Instead unnecessarily  'Close' icon is seen

This is Non-Regression Issue seen from M-62
 
Actual_CloseIcon.jpg
476 KB View Download
Expected_NoCloseIconInConfigureOverlay.jpg
769 KB View Download
Expected_NoCloseIconInConfirmOverlay.jpg
681 KB View Download
Cc: sgabr...@chromium.org
Labels: -M-70 M-72 FoundIn-70
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
It's the difference between WebUI dialogs (opened from Settings), and stand-alone dialogs (opened directly from the System Menu).

I'll try to take a look at making them consistent for 72, but we knew there would be discrepancies when we started the Settings UI MD2 refresh.

Issue 902056 has been merged into this issue.
Labels: -M-72 M-73
Components: Design
Labels: Needs-Feedback
Owner: sgabr...@chromium.org
sgabriel@: It should be possible to make system dialogs match the look of the Settings dialogs. The question is whether we want to.

Examples of system dialogs:
* Adding a new wifi or VPN network from the system menu.
* Pairing to a bluetooth device from the system menu.
* Opting in to the assistant

Specifically:
1) Should we use rounded corners?
2) Should we hide the 'X' close button in the upper-right hand corner? (All dialogs should have a close or cancel button; I would be sure to confirm that).

1) Yes
2) Yes 

Thanks!
Owner: steve...@chromium.org
I started investigating implementing the rounded corners for system dialogs, and have not found a simple / straightforward solution.

* I don't think we want to implement the rounded corners in the HTML because it takes a second for the content to load, during which the corners are not rounded. (We would also need to make the background transparent; I couldn't immediately figure that out. That would make the UI feel sluggish until the HTML renders anyway).

* We probably need to do something with the dialog background or border, but it wasn't immediately clear to me where to do this; views::WebDialogView is pretty complex.

I'll ask some folks about the best approach, but this is not currently at the top of my priority list.

Sign in to add a comment