New issue
Advanced search Search tips

Issue 894385 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Radio button does not appear selected on mouse action on chrome://settings/syncSetup

Project Member Reported by sanyam.g...@etouch.net, Oct 11

Issue description

Chrome version : 71.0.3577.0 (Official Build) fc334a55a70eec12fc77853c53979f81e8496c21-refs/branch-heads/3577@{#1}(32/64 Bit)
OS : Win(7,8,8.1,10), Mac( 10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTS) OS

Pre-condition: Sign in to chrome with an account having a passphrase set.

Steps to reproduce:
1. Launch chrome and navigate to chrome://settings/syncSetup.
2. Click on ‘reset sync’ (it navigates to ‘https://chrome.google.com/sync?hl=en-GB’) and click on Reset Sync button.
3. Navigate to ‘chrome://settings/people’ and click on ‘Turn on Sync’.
4. On ‘chrome://settings/syncSetup’ page click on 2nd radio button under Encryption Options and observe.

Actual Result  : Radio button does not appear selected on mouse action.
Expected Result: Radio button should appear selected on mouse action.

This is a regression issue broken in ‘M-71’ and will soon update bisect info.
Good build: 71.0.3544.0(Revision: 589077)
Bad build : 71.0.3545.0(Revision: 589377)

You are probably looking for a change made after 589370 (known good), but no later than 589371 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b8fa1ab33246b17f5e4f1b1e9488460759d9d5f8..652922aab5efd6488608d7b23257c012457a61c1

Suspect: https://chromium.googlesource.com/chromium/src/+/652922aab5efd6488608d7b23257c012457a61c1

From the CL above, assigning the issue to the concern owner 

@tangltom - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
 
Thanks!

 
Actual_Behaviour.mov
3.8 MB View Download
Expected_Behaviour.mov
5.3 MB View Download
Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b00f3499c1dc74c8e0419384a69f041ebcd2442

commit 9b00f3499c1dc74c8e0419384a69f041ebcd2442
Author: Thomas Tangl <tangltom@chromium.org>
Date: Fri Oct 12 10:04:02 2018

Fix radio button bug on sync_page.html

The second radio button in the passphrase section
was not visibly checked on selection.

To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.

Additional change:
 - Remove aria-label attribute because the visible text
   is used automatically as radio button title.

Bug:  894385 
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599157}
[modify] https://crrev.com/9b00f3499c1dc74c8e0419384a69f041ebcd2442/chrome/browser/resources/settings/people_page/sync_page.html

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
This needs a merge to M71, pls request a merge.

M71 branch (3578), branched at chromium revision 599034.
Labels: Merge-Request-71
Verified on Canary.
Labels: -Merge-TBD
Removing "Merge-TBD" lable as M71 merge is requested at #7.
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 15

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 15

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fb1f8a5425bbd6cd9e34bb78d37429d0098088b

commit 6fb1f8a5425bbd6cd9e34bb78d37429d0098088b
Author: Thomas Tangl <tangltom@chromium.org>
Date: Mon Oct 15 14:06:54 2018

Fix radio button bug on sync_page.html

The second radio button in the passphrase section
was not visibly checked on selection.

To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.

Additional change:
 - Remove aria-label attribute because the visible text
   is used automatically as radio button title.

Bug:  894385 
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599157}(cherry picked from commit 9b00f3499c1dc74c8e0419384a69f041ebcd2442)
Reviewed-on: https://chromium-review.googlesource.com/c/1280547
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#20}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/6fb1f8a5425bbd6cd9e34bb78d37429d0098088b/chrome/browser/resources/settings/people_page/sync_page.html

Labels: TE-Verified-M71 TE-Verified-71.0.3578.10
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.1) using latest Dev build : 71.0.3578.10 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_Result (Dev).mov
4.4 MB View Download
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6fb1f8a5425bbd6cd9e34bb78d37429d0098088b

Commit: 6fb1f8a5425bbd6cd9e34bb78d37429d0098088b
Author: tangltom@chromium.org
Commiter: tangltom@chromium.org
Date: 2018-10-15 14:06:54 +0000 UTC

Fix radio button bug on sync_page.html

The second radio button in the passphrase section
was not visibly checked on selection.

To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.

Additional change:
 - Remove aria-label attribute because the visible text
   is used automatically as radio button title.

Bug:  894385 
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599157}(cherry picked from commit 9b00f3499c1dc74c8e0419384a69f041ebcd2442)
Reviewed-on: https://chromium-review.googlesource.com/c/1280547
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#20}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment