New issue
Advanced search Search tips

Issue 894372 link

Starred by 1 user
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Oct 12
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Selection highlight is turns from blue to grey after opening context menu on it.

Reported by db...@etouch.net, Oct 11 
Chrome Version: 71.0.3577.0 Revision fc334a55a70eec12fc77853c53979f81e8496c21-refs/branch-heads/3577@{#1}(32/64 bit)
OS: Mac ( 10.13.1,10.13.6, 10.14.1) and Win (7, 8, 8.1, 10),Linux(14.04) LTS.

What steps will reproduce the problem?
(1) Launch chrome, open NTP and open dev tools window on it.
(2) Click on three dots in element section and select 'Edit as HTML' option.
(3) Press Ctrl+A and Right clcik on it, observe selection highlight on text.

Actual: Selection highlight is turns from blue to grey after opening context menu on it.

Expected: Selection highlight should seen blue in color.

This is a regression issue, broken in 'M65' , below is bisect info:

Good Build:65.0.3284.0(Revision:521228)
Bad Build: 65.0.3285.0(Revision:521571)

You are probably looking for a change made after 521419 (known good), but no lat
er than 521430 (first known bad).
CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/8229631e3aca5b48c77211ce443c5947c7c42f4f..6702fd7e6c07f6927b4e67f1ee5cd2804ebf7d45

Suspect: https://chromium.googlesource.com/chromium/src/+/6702fd7e6c07f6927b4e67f1ee5cd2804ebf7d45

@einbinder: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Actual_Highlight.mp4
747 KB View Download
Expected_Highlight.mp4
1.2 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a62fbc18b5720d0653ef2c023510c340d1d9b42d

commit a62fbc18b5720d0653ef2c023510c340d1d9b42d
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Oct 11 23:48:01 2018

[DevTools] fix(elements): preserve active text highlight on contextmenu

Previously we would listen to a blur event coming out of the HTML editor
to know when to commit the text. To prevent an internal focus change
we would cancel mousedown events inside the editor. This confused
codemirror, which expects focus to have moved after a right click
and messed up its text selection color.

This patch removes the mousedown canceling, and checks relatedTarget
on the focus event to only commit when focus leaves the editor.

Bug:  894372 
Change-Id: Id29f26c75d9f5a12c52679c3cd947987d2b8779e
Reviewed-on: https://chromium-review.googlesource.com/c/1277810
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599015}
[modify] https://crrev.com/a62fbc18b5720d0653ef2c023510c340d1d9b42d/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html.js
[modify] https://crrev.com/a62fbc18b5720d0653ef2c023510c340d1d9b42d/third_party/blink/renderer/devtools/front_end/elements/ElementsTreeElement.js

Comment 2 by einbinder@chromium.org, Oct 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment