Need at least r344346 for.

Would like at least r344391 so I can re-enable /opt:ref in libFuzzer on Windows builds.

r344300 might help with issue 841678

r346069 for /dllexportInlines- ( Issue 901709 )
r344190 for the mac size regression ( Issue 891992 )


Getting a roll in is my main goal this week.

r344987 changed inline heuristics, so might affect performance.

Hopefully r346062 will address debug info issues in blob_reader.cc:
https://bugs.llvm.org/show_bug.cgi?id=38857
https://chromium-review.googlesource.com/c/chromium/src/+/1303399/1/storage/browser/blob/blob_reader.cc

There's a lot of redness on the ToT waterfall, but most of it isn't necessarily blocking.

As far as I currently know, this patch should be enough to unblock us from at least attempting a roll:

https://chromium-review.googlesource.com/c/chromium/src/+/1319712

Let's pick up r346265 for the AVX2 cpuid issue.

The Android libstdc++ / libc++ issue made the rel android bot green:
https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/5374

We have a long list of roll blockers, but I don't think they are actually blockers. They're all either worked around or broken-with-stable or other redness not caused by the new clang version.

I speculatively started some packages here:
https://chromium-review.googlesource.com/c/chromium/src/+/1321863

Hans, hopefully you can use them tomorrow morning.

> I speculatively started some packages here:
https://chromium-review.googlesource.com/c/chromium/src/+/1321863

Thanks! Trying it now.

hans@, can I land https://chromium-review.googlesource.com/c/chromium/src/+/1315361 now? Just wanted to double check with you since I don't want to complicate the roll you're working on.

> hans@, can I land https://chromium-review.googlesource.com/c/chromium/src/+/1315361 now?

If you don't mind, it would help reduce the pressure for us if you could wait a day or two, just to remove one source of potential problems. IIUC, this is mostly just a clean-up, not blocking anything right?

Sure, absolutely! Yes, it's supposed to remove unneeded libs, but may accidentally break some builders in case I've removed too many things.

hans@, I only run tools/clang/scripts/upload_revision.py 346388.
https://chromium-review.googlesource.com/c/chromium/src/+/1325575

Can I ask you to take rest of work?
I mean from step 4 in
https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang.md

Thanks, will do.

rnk started packaging here too: https://chromium-review.googlesource.com/c/chromium/src/+/1325199/

But your packages are finished :-)

rnk's roll caused strange behavior for win builder?
It took more than 7hrs now :-(

So I made my CL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da06a02d93545183bc626dc6ec6f67ceeb50fb4f

commit da06a02d93545183bc626dc6ec6f67ceeb50fb4f
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Nov 08 13:00:55 2018

Roll clang 344066:346388.

Bug:  894363 
Change-Id: If32d6e9d3e968b1f063d2b2a59fc84975e34384c
Reviewed-on: https://chromium-review.googlesource.com/c/1325575
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606431}
[modify] https://crrev.com/da06a02d93545183bc626dc6ec6f67ceeb50fb4f/tools/clang/scripts/update.py

The roll is in, but please wait at least 24 hours before landing dependent changes on top.

It's been a while since we last rolled, so there's a change this won't stick.

First fallout: https://bugs.chromium.org/p/chromium/issues/detail?id=900406#c11

Fallout fixed, waiting for more. :)

Thanks!
Jumbo builds saw more -Wshadow warnings: https://bugs.chromium.org/p/chromium/issues/detail?id=895475#c28
But overall things are looking good.

Next roll:  Issue 904337