New issue
Advanced search Search tips

Issue 894354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 853267



Sign in to add a comment

Support AAT through HarfBuzz

Project Member Reported by drott@chromium.org, Oct 11

Issue description

HarfBuzz is gaining native AAT shaping support, without relying on the hb-coretext backend. We should roll HarfBuzz to a version that has AAT support and assist with testing the new functionality.
 
Labels: -Type-Bug Type-Task
Cc: ebra...@gnu.org
Blocking: 853267
Performance analysis building HarfBuzz with -O3, speedup factors over CoreText AAT for shaping hunspell dictionaries for script, measured on a Core i7 3.1GHz MacBook Pro:
Tamil + Tamil Sangam MN.ttc	5.7x
Arabic + GeezaPro.ttc	4.0x
Latin + SFNSText.ttf	12.9x
Latin + Times.ttc	3.7x
Hebrew + LucidaGrande.ttc	3.2x
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c67f53b0b70f33c47159d37f7e59bb44399b0d09

commit c67f53b0b70f33c47159d37f7e59bb44399b0d09
Author: Dominik Röttsches <drott@chromium.org>
Date: Sun Nov 25 17:46:22 2018

Roll HarfBuzz to 2.1.1 plus AAT fixes

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/54d332dd9b0263..ae96c98dfaef3a7

Enables native AAT support in HarfBuzz without relying on CoreText.

Performance improvements compared to Mac OS CoreText implementation
ranging between 3.2x speedup for Hebrew using Lucida Grande up to 12.2x
speedup for Latin with the San Francisco system font. This should
unblock issue 862773 and other AAT performance issues we have seen.

For performance data, see: https://goo.gl/tZJU2y

The following HarfBuzz issues on AAT issues were reported to HarfBuzz
and have been ironed out in the HarfBuzz commit that we're rolling to:
https://github.com/harfbuzz/harfbuzz/issues?q=1263+1264+1278+1303+1305+1331+1342+1348+1343+1393+1405+1406

The rebaselines affect:

* Kerning differences, especially improved kerning with punctuation on
  Windows, unrelated to AAT implementation
* Slight difference in glyph coordinate rounding for AAT fonts
  due to internal computation with subpixel values, but screen placement
  at rounded pixels
* Combining mark placement differences between HarfBuzz AAT and CoreText
  AAT, compare https://github.com/harfbuzz/harfbuzz/issues/1264
* Changes in vertical origin computation in HarfBuzz, unrelated to AAT

IMPORTANT: If HarfBuzz AAT needs to be reverted, consider changing
    if (false) in BUILD.gn to
    if (is_mac)
to re-enable the hb-coretext backend for processing AAT instead of
reverting the whole CL.

Big kudos and a big thank you to behdad@ for the excellent work on
implementing AAT in HarfBuzz and this smooth collaboration in maturing
the implementation.

Binary-Size: Intended functionality add in HarfBuzz to support AAT fonts natively without using CoreText
Bug:  894354 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iab082fbd47cd1df9e1fd9558a12ddf597db77f7b
Reviewed-on: https://chromium-review.googlesource.com/c/1275945
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610734}
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/DEPS
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png
[add] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng/fast/writing-mode/Kusa-Makura-background-canvas-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css1/font_properties/font_family-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css2.1/t1202-counter-04-b-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css2.1/t1202-counters-04-b-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css2.1/t1503-c522-font-family-00-b-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atsui-spacing-features-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/capitalize-boundaries-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/cg-vs-atsui-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/emoticons-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/emphasis-complex-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/emphasis-ellipsis-complextext-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/font-fallback-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/font-format-support-color-cff2-vertical-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/format-control-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/international/complex-character-based-fallback-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/international/hebrew-vowels-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/justify-ideograph-vertical-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/line-initial-and-final-swashes-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/orientation-sideways-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/selection/complex-text-rtl-selection-repaint-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/selection/khmer-selection-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/webfont-synthetic-bold-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/border-vertical-lr-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/japanese-lr-selection-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/japanese-lr-text-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/japanese-rl-selection-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/japanese-rl-text-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/text-orientation-basic-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/selection/japanese-rl-selection-clear-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/subtree-root-skipped-expected.txt
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/text/combining-character-queries-expected.png
[add] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/user-activation-v2/fast/events/context-no-deselect-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[add] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css1/font_properties/font_family-expected.png
[add] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css2.1/t1503-c522-font-family-00-b-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-161-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-19b-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-23-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-24-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-64-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-68-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/html/css3-modsel-69-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-161-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-19b-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-23-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-24-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-64-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-68-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xhtml/css3-modsel-69-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-161-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-19b-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-23-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-24-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-64-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-68-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/selectors3/xml/css3-modsel-69-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/input/caret-at-the-edge-of-input-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/pasteboard/pasting-tabs-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/pasteboard/pasting-tabs-expected.txt
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/replaced-boundaries-3-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/replaced-boundaries-3-expected.txt
[add] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-box-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/selection-button-text-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/block/margin-collapse/103-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/block/positioning/inline-block-relposition-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/css/continuationCrash-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/css/line-height-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/css/margin-top-bottom-dynamic-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/css/text-overflow-input-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/dynamic/008-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/files/file-in-input-display-expected.png
[delete] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/001-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/basic-inputs-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/blankbuttons-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-positioned-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-sizes-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-style-color-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-table-styles-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button-text-transform-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button/button-align-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button/button-cannot-be-nested-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/button/button-white-space-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/control-clip-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/control-clip-overflow-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/control-restrict-line-height-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/file/file-input-direction-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/file/file-input-disabled-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/file/file-input-pressed-state-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/file/input-file-re-render-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/formmove3-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/image/002-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/image/005-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/image/image-alt-text-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/input-align-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/input-appearance-height-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/input-button-sizes-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/input-first-letter-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/input-value-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/minWidthPercent-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/number/number-appearance-rtl-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/plaintext-mode-2-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-cancel-button-style-sharing-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-rtl-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/searchfield-heights-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/004-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/HTMLOptionElement_label01-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/HTMLOptionElement_label02-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/HTMLOptionElement_label03-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/HTMLOptionElement_label04-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/HTMLOptionElement_label05-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/basic-selects-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/disabled-select-change-index-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/listbox-appearance-basic-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/listbox-appearance-separator-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/listbox-bidi-align-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/listbox-scrollbar-incremental-load-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/listbox-width-change-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-basic-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-clip-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-deselect-update-expected.png
[modify] https://crrev.com/c67f53b0b70f33c47159d37f7e59bb44399b0d09/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-no-overflow-expected.png
[modify] https
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf85a0cd0cf94ec248545289f9717e2179adce1

commit fbf85a0cd0cf94ec248545289f9717e2179adce1
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Nov 26 11:37:51 2018

Roll HarfBuzz to fix Tamil MN and Khmer issues

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/992b7128656e72..574d888c8a

Compare https://github.com/harfbuzz/harfbuzz/issues/1410

Bug:  894354 
Change-Id: Ibfaa54ed22e72ed36731f2ca22037d5deb15f81b
Tbr: eae, behdad
Reviewed-on: https://chromium-review.googlesource.com/c/1349978
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610818}
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/DEPS
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/emphasis-complex-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/font-fallback-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/selection/khmer-selection-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac-mac10.11/fast/text/emphasis-complex-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac-mac10.11/fast/text/font-fallback-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac-mac10.11/fast/text/selection/khmer-selection-expected.png
[delete] https://crrev.com/0a73790a0518b1fc218752d11027daeff92f8446/third_party/blink/web_tests/platform/mac-mac10.11/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt
[delete] https://crrev.com/0a73790a0518b1fc218752d11027daeff92f8446/third_party/blink/web_tests/platform/mac-mac10.12/css1/font_properties/font_family-expected.png
[delete] https://crrev.com/0a73790a0518b1fc218752d11027daeff92f8446/third_party/blink/web_tests/platform/mac-mac10.12/css2.1/t1503-c522-font-family-00-b-expected.png
[delete] https://crrev.com/0a73790a0518b1fc218752d11027daeff92f8446/third_party/blink/web_tests/platform/mac-mac10.12/css2.1/t1508-c527-font-03-b-expected.png
[delete] https://crrev.com/0a73790a0518b1fc218752d11027daeff92f8446/third_party/blink/web_tests/platform/mac-mac10.12/fast/block/float/016-expected.png
[delete] https://crrev.com/0a73790a0518b1fc218752d11027daeff92f8446/third_party/blink/web_tests/platform/mac-mac10.12/virtual/layout_ng/fast/block/float/016-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/css1/font_properties/font-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/css1/font_properties/font_family-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/css2.1/t1503-c522-font-family-00-b-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/css2.1/t1508-c527-font-03-b-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/fast/block/float/016-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/fast/text/international/complex-character-based-fallback-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/fonts/cursive-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/svg/text/bbox-with-glyph-overflow-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/svg/text/bbox-with-glyph-overflow-on-path-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/svg/text/bbox-with-glyph-overflow-zoomed-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/svg/text/combining-character-queries-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/svg/text/ligature-queries-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/blink/web_tests/platform/mac/virtual/layout_ng/fast/block/float/016-expected.png
[modify] https://crrev.com/fbf85a0cd0cf94ec248545289f9717e2179adce1/third_party/harfbuzz-ng/README.chromium

Status: Fixed (was: Started)
🎉 Big thanks to Behdad for the fast implementation, performance details see #4 and https://goo.gl/tZJU2y - and Ebrahim for being a great help spotting important remaining issues before we were able to land this.

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1ca1f9af7a6eb64b9f4360ff85af8655f9aad86

commit e1ca1f9af7a6eb64b9f4360ff85af8655f9aad86
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Nov 26 17:22:20 2018

Enable more shaper tests on Mac

Now that HarfBuzz AAT landed, enable more HarfBuzzShaper tests on Mac.

Bug:  894354 
Change-Id: I2d3cdf721187f4366c964bcd982f3954ccd61429
Reviewed-on: https://chromium-review.googlesource.com/c/1350810
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610867}
[modify] https://crrev.com/e1ca1f9af7a6eb64b9f4360ff85af8655f9aad86/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper_test.cc

Cc: e...@chromium.org
After the memory regression was fixed, more visible improvements, 15% improvement in a benchmark that measures jank, 15% better on Google Search India.

https://chromeperf.appspot.com/group_report?rev=612233





eqt_max_india.png
776 KB View Download
Labels: M-72
See also https://bugs.chromium.org/p/chromium/issues/detail?id=908552#c4 for details on the 28% improvement in html5-full-render.

Sign in to add a comment