Regression: [Print Preview] Unnecesary text carat is seen in pages text-box when 'All' radio button is selected.
Reported by
dchau...@etouch.net,
Oct 11
|
||||||||||||
Issue descriptionChrome Version: 71.0.3576.0 (Official Build) Revision bc9a92a53c6a87c2857f18371e9f32b1f0f895cb-refs/branch-heads/3576@{#1} (32/64-bit) OS: Mac (10.12.6, 10.13.1, 10.14.1) and Win (7, 8, 8.1, 10). What steps will reproduce the problem? 1. Launch Chrome and give print command on any webpage . 2. Click in 'Pages' text-box to bring the focus on second radio button and text carat will start blinking in text-box. 3. Now press 'Enter' key from keyboard and observe. Actual: Unnecessary text carat is seen in 'Pages' text-box even 'All' radio button is selected. Expected: Text carat should not seen in 'Pages' text-box when 'All' radio button is selected. This is a regression issue, broken in M-71 series, will soon update other info. Thank you.
,
Oct 12
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa730994107b1bef054c04a2ee339fdfe637a55e commit aa730994107b1bef054c04a2ee339fdfe637a55e Author: rbpotter <rbpotter@chromium.org> Date: Fri Oct 12 18:13:49 2018 Print Preview Refresh: Fix enter key blocked in pages input Bug: 894350 Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278534 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599291} [modify] https://crrev.com/aa730994107b1bef054c04a2ee339fdfe637a55e/chrome/browser/resources/print_preview/new/pages_settings.js [modify] https://crrev.com/aa730994107b1bef054c04a2ee339fdfe637a55e/chrome/test/data/webui/print_preview/pages_settings_test.js [modify] https://crrev.com/aa730994107b1bef054c04a2ee339fdfe637a55e/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
,
Oct 15
Update: Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14) and Linux(14.04) machines using latest Canary #72.0.3581.0 and issue is fixed. Hence adding TE-Verified labels. please refer the attached screen-cast for reference. Thank you.
,
Oct 15
,
Oct 15
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 15
CL landed shortly after the branch cut. As noted by the reporter, this should be fixed for 71. The fix should be safe to merge and is verified by automated tests added in the same CL.
,
Oct 15
,
Oct 15
,
Oct 16
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e commit 82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e Author: rbpotter <rbpotter@chromium.org> Date: Tue Oct 16 18:51:01 2018 Print Preview Refresh: Fix enter key blocked in pages input (M71) Bug: 894350 Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278534 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599291}(cherry picked from commit aa730994107b1bef054c04a2ee339fdfe637a55e) Reviewed-on: https://chromium-review.googlesource.com/c/1284056 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#52} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e/chrome/browser/resources/print_preview/new/pages_settings.js [modify] https://crrev.com/82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e/chrome/test/data/webui/print_preview/pages_settings_test.js [modify] https://crrev.com/82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
,
Oct 16
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e Commit: 82c07f1d3fa81f2eac1d9e227e9adc3e23ac162e Author: rbpotter@chromium.org Commiter: rbpotter@chromium.org Date: 2018-10-16 18:51:01 +0000 UTC Print Preview Refresh: Fix enter key blocked in pages input (M71) Bug: 894350 Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278534 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599291}(cherry picked from commit aa730994107b1bef054c04a2ee339fdfe637a55e) Reviewed-on: https://chromium-review.googlesource.com/c/1284056 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#52} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by dchau...@etouch.net
, Oct 11Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
447 KB
447 KB View Download
406 KB
406 KB View Download