New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894331 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Whitelist kRlzPingDelay switch for guest mode

Project Member Reported by wzang@chromium.org, Oct 11

Issue description

Guest session needs a Chrome restart, and the flags specified in chrome_dev.conf are ignored, unless explicitly whitelisted. This is for the convenience of testing rlz ping. The normal waiting time is 24 hours and it's unrealistic for testing team.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce1b79ba1ca42736a671d94474c58a9fa1a1a3f

commit 8ce1b79ba1ca42736a671d94474c58a9fa1a1a3f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Oct 12 17:00:13 2018

cros: Whitelist kRlzPingDelay in kForwardSwitches

This is for the convenience of testing rlz ping. The normal waiting
time is 24 hours and it's unrealistic for testing team.

Bug:  894331 
Change-Id: Ia5d6d38bc05221672d4ae4a0b6da4e221aaa0607
Reviewed-on: https://chromium-review.googlesource.com/c/1270012
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599256}
[modify] https://crrev.com/8ce1b79ba1ca42736a671d94474c58a9fa1a1a3f/chrome/browser/chromeos/login/chrome_restart_request.cc

Status: Fixed (was: Started)
Colin, this didn't make the M71 branch. Can you request a merge for it?
Labels: Merge-Request-71
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 16

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a493421ce5aa015baddd1040bae320a936f8a3eb

commit a493421ce5aa015baddd1040bae320a936f8a3eb
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Oct 16 17:51:17 2018

[Merge to M71] cros: Whitelist kRlzPingDelay in kForwardSwitches

This is for the convenience of testing rlz ping. The normal waiting
time is 24 hours and it's unrealistic for testing team.

Bug:  894331 
Change-Id: Ia5d6d38bc05221672d4ae4a0b6da4e221aaa0607
Reviewed-on: https://chromium-review.googlesource.com/c/1270012
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599256}(cherry picked from commit 8ce1b79ba1ca42736a671d94474c58a9fa1a1a3f)
Reviewed-on: https://chromium-review.googlesource.com/c/1283991
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#44}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/a493421ce5aa015baddd1040bae320a936f8a3eb/chrome/browser/chromeos/login/chrome_restart_request.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a493421ce5aa015baddd1040bae320a936f8a3eb

Commit: a493421ce5aa015baddd1040bae320a936f8a3eb
Author: wzang@chromium.org
Commiter: wzang@chromium.org
Date: 2018-10-16 17:51:17 +0000 UTC

[Merge to M71] cros: Whitelist kRlzPingDelay in kForwardSwitches

This is for the convenience of testing rlz ping. The normal waiting
time is 24 hours and it's unrealistic for testing team.

Bug:  894331 
Change-Id: Ia5d6d38bc05221672d4ae4a0b6da4e221aaa0607
Reviewed-on: https://chromium-review.googlesource.com/c/1270012
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599256}(cherry picked from commit 8ce1b79ba1ca42736a671d94474c58a9fa1a1a3f)
Reviewed-on: https://chromium-review.googlesource.com/c/1283991
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#44}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment